all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: jgart via Guix-patches via <guix-patches@gnu.org>
To: Sarah Morgensen <iskarian@mgsn.dev>
Cc: 50833@debbugs.gnu.org
Subject: [bug#50833] [PATCH] gnu: Add bower.
Date: Thu, 30 Sep 2021 23:31:16 -0400	[thread overview]
Message-ID: <20210930233116.GB1935@gac.attlocal.net> (raw)
In-Reply-To: <868rzdtrxv.fsf@mgsn.dev>

On Thu, 30 Sep 2021 19:11:24 -0700 Sarah Morgensen <iskarian@mgsn.dev> wrote:
> These are the locations I found.

Thanks! Not sure how I missed that :) I must have done the wrong thing with ripgrep

> default_sendmail_command =
>     command_prefix(shell_quoted("/usr/bin/sendmail -oi -oem"), quote_once).

Should sendmail really be wrapped? I feel like sendmail won't work "out of the" box
without some configuration first. I may be wrong. Not sure what to do there.

Maybe someone in the community can advise us further on that point?

The other ones seem sensible to wrap and as they mostly work without configuration.

I'm using msmtp instead of sendmail in my bower config. Seemed much simpler 
at the time to set up. I think the founding/main author of bower also uses msmtp 
instead of sendmail.

https://github.com/wangp/bower/blob/512b8be936db268d8ea94608cab486725cc2ec60/bower.conf.sample#L125

> Also, I just caught one more thing--usually we write out the full URL in
> the origin, rather than re-use the 'home-page' field.

Good catch! I stopped doing that also. That must have been from the package 
template I started from ;) 

I added a new patch with the home-page swapped below.

> Hope that helps,

Thank you! Yes, it does. Much appreciated :)

I hope to get back to this in a few days when I have more free time. 

Feel free to add patches if you'd like. We can commit together as co-authors.

all best,

jgart




  reply	other threads:[~2021-10-01  3:32 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-26 23:08 [bug#50833] Add bower (it's not what you're thinking) jgart via Guix-patches via
2021-09-26 23:11 ` [bug#50833] [PATCH] gnu: Add bower jgart via Guix-patches via
2021-09-27  1:01   ` Sarah Morgensen
2021-09-29  1:12     ` jgart via Guix-patches via
2021-10-01  2:11       ` Sarah Morgensen
2021-10-01  3:31         ` jgart via Guix-patches via [this message]
2021-10-02  7:58         ` jgart via Guix-patches via
2021-10-25  4:32         ` jgart via Guix-patches via
2021-10-25 12:25           ` [bug#50833] Add bower (it's not what you're thinking) Ludovic Courtès
2022-04-20 21:07             ` [bug#50833] [PATCH] Add Bower (notmuch curses email client) Maxim Cournoyer
2022-05-05 14:31               ` jgart via Guix-patches via
2022-07-07 18:01                 ` Maxim Cournoyer
2022-07-08  0:23                   ` jgart via Guix-patches via
2022-07-08 10:33                     ` Munyoki Kilyungi
2022-07-08 18:47                       ` jgart via Guix-patches via
2022-07-08 19:42                         ` jgart via Guix-patches via
2022-07-14  8:54                           ` Munyoki Kilyungi
2022-07-11 16:09                     ` Maxim Cournoyer
2022-07-15  1:50                       ` jgart via Guix-patches via
2021-09-29  1:12 ` [bug#50833] [PATCH] gnu: Add bower jgart via Guix-patches via
2021-10-01  3:31 ` jgart via Guix-patches via
2022-07-20  5:18 ` [bug#50833] [PATCH v2] " jgart via Guix-patches via
2022-07-20 11:59   ` Maxime Devos
2022-07-24 17:45     ` jgart via Guix-patches via
2022-08-21  6:53 ` [bug#50833] [PATCH v3] " jgart via Guix-patches via
2022-09-02 14:05 ` bug#50833: [PATCH] Add Bower (notmuch curses email client) Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210930233116.GB1935@gac.attlocal.net \
    --to=guix-patches@gnu.org \
    --cc=50833@debbugs.gnu.org \
    --cc=iskarian@mgsn.dev \
    --cc=jgart@dismail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.