* [bug#33868] [PATCH] gnu: calibre: Fix PDF to EPUB conversion.
@ 2018-12-25 11:44 Mathieu Othacehe
2019-01-06 17:56 ` Ludovic Courtès
2019-01-11 23:19 ` Marius Bakke
0 siblings, 2 replies; 5+ messages in thread
From: Mathieu Othacehe @ 2018-12-25 11:44 UTC (permalink / raw)
To: 33868
When trying to convert a PDF to EPUB, the following error occurs:
File "/gnu/store/kz6bgqw9z7akj11zh20wkx14cgq0s3n2-calibre-3.35.0/lib/calibre/calibre/ebooks/pdf/pdftohtml.py", line 76, in pdftohtml
_('Could not find pdftohtml, check it is in your PATH'))
Move poppler which provides pdftohtml from inputs to propagated-inputs to fix it.
* gnu/packages/ebook.scm (calibre)[inputs]: Move poppler from here ...
[propagated-inputs]: ... to here.
---
gnu/packages/ebook.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm
index e750c6cac..70434293a 100644
--- a/gnu/packages/ebook.scm
+++ b/gnu/packages/ebook.scm
@@ -5,6 +5,7 @@
;;; Copyright © 2017 Brendan Tildesley <brendan.tildesley@openmailbox.org>
;;; Copyright © 2017 Roel Janssen <roel@gnu.org>
;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright © 2018 Mathieu Othacehe <m.othacehe@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -121,7 +122,6 @@
("openssl" ,openssl)
("optipng" ,optipng)
("podofo" ,podofo)
- ("poppler" ,poppler)
("python" ,python-2)
("python2-apsw" ,python2-apsw)
("python2-chardet" ,python2-chardet)
@@ -145,9 +145,9 @@
("python2-sip" ,python2-sip)
("python2-regex" ,python2-regex)
;; python2-unrardll is needed for decompressing RAR files.
- ;; A program called 'pdf2html' is needed for reading PDF books
- ;; in the web interface.
("sqlite" ,sqlite)))
+ (propagated-inputs
+ `(("poppler" ,poppler)))
(arguments
`(#:python ,python-2
#:test-target "check"
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#33868] [PATCH] gnu: calibre: Fix PDF to EPUB conversion.
2018-12-25 11:44 [bug#33868] [PATCH] gnu: calibre: Fix PDF to EPUB conversion Mathieu Othacehe
@ 2019-01-06 17:56 ` Ludovic Courtès
2019-01-11 23:19 ` Marius Bakke
1 sibling, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2019-01-06 17:56 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: 33868
Hello,
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
> When trying to convert a PDF to EPUB, the following error occurs:
>
> File "/gnu/store/kz6bgqw9z7akj11zh20wkx14cgq0s3n2-calibre-3.35.0/lib/calibre/calibre/ebooks/pdf/pdftohtml.py", line 76, in pdftohtml
> _('Could not find pdftohtml, check it is in your PATH'))
>
> Move poppler which provides pdftohtml from inputs to propagated-inputs to fix it.
>
> * gnu/packages/ebook.scm (calibre)[inputs]: Move poppler from here ...
> [propagated-inputs]: ... to here.
I haven’t tested it but I’m confident you can go ahead and push it.
Thanks!
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#33868] [PATCH] gnu: calibre: Fix PDF to EPUB conversion.
2018-12-25 11:44 [bug#33868] [PATCH] gnu: calibre: Fix PDF to EPUB conversion Mathieu Othacehe
2019-01-06 17:56 ` Ludovic Courtès
@ 2019-01-11 23:19 ` Marius Bakke
2019-01-12 22:43 ` Leo Famulari
1 sibling, 1 reply; 5+ messages in thread
From: Marius Bakke @ 2019-01-11 23:19 UTC (permalink / raw)
To: Mathieu Othacehe, 33868
[-- Attachment #1: Type: text/plain, Size: 936 bytes --]
Mathieu Othacehe <m.othacehe@gmail.com> writes:
> When trying to convert a PDF to EPUB, the following error occurs:
>
> File "/gnu/store/kz6bgqw9z7akj11zh20wkx14cgq0s3n2-calibre-3.35.0/lib/calibre/calibre/ebooks/pdf/pdftohtml.py", line 76, in pdftohtml
> _('Could not find pdftohtml, check it is in your PATH'))
>
> Move poppler which provides pdftohtml from inputs to propagated-inputs to fix it.
>
> * gnu/packages/ebook.scm (calibre)[inputs]: Move poppler from here ...
> [propagated-inputs]: ... to here.
An less intrusive solution would be to substitute the absolute path to
'pdf2html' in a build step. I.e.:
(substitute* "lib/calibre/calibre/ebooks/pdf/pdftohtml.py"
(("PDFTOHTML = \"pdftohtml\"")
(string-append "PDFTOHTML = \"" (assoc-ref inputs "poppler")
"/bin/pdftohtml\"")))
Either approach is fine by me, but please leave a comment about why
Poppler is propagated if you go that route :-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#33868] [PATCH] gnu: calibre: Fix PDF to EPUB conversion.
2019-01-11 23:19 ` Marius Bakke
@ 2019-01-12 22:43 ` Leo Famulari
2019-01-21 9:57 ` bug#33868: " Mathieu Othacehe
0 siblings, 1 reply; 5+ messages in thread
From: Leo Famulari @ 2019-01-12 22:43 UTC (permalink / raw)
To: Marius Bakke; +Cc: 33868
[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]
On Sat, Jan 12, 2019 at 12:19:54AM +0100, Marius Bakke wrote:
> Mathieu Othacehe <m.othacehe@gmail.com> writes:
>
> > When trying to convert a PDF to EPUB, the following error occurs:
> >
> > File "/gnu/store/kz6bgqw9z7akj11zh20wkx14cgq0s3n2-calibre-3.35.0/lib/calibre/calibre/ebooks/pdf/pdftohtml.py", line 76, in pdftohtml
> > _('Could not find pdftohtml, check it is in your PATH'))
> >
> > Move poppler which provides pdftohtml from inputs to propagated-inputs to fix it.
> >
> > * gnu/packages/ebook.scm (calibre)[inputs]: Move poppler from here ...
> > [propagated-inputs]: ... to here.
>
> An less intrusive solution would be to substitute the absolute path to
> 'pdf2html' in a build step. I.e.:
>
> (substitute* "lib/calibre/calibre/ebooks/pdf/pdftohtml.py"
> (("PDFTOHTML = \"pdftohtml\"")
> (string-append "PDFTOHTML = \"" (assoc-ref inputs "poppler")
> "/bin/pdftohtml\"")))
>
> Either approach is fine by me, but please leave a comment about why
> Poppler is propagated if you go that route :-)
I think this substitution is the better solution.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#33868: [PATCH] gnu: calibre: Fix PDF to EPUB conversion.
2019-01-12 22:43 ` Leo Famulari
@ 2019-01-21 9:57 ` Mathieu Othacehe
0 siblings, 0 replies; 5+ messages in thread
From: Mathieu Othacehe @ 2019-01-21 9:57 UTC (permalink / raw)
To: Leo Famulari; +Cc: 33868-done
>> (substitute* "lib/calibre/calibre/ebooks/pdf/pdftohtml.py"
>> (("PDFTOHTML = \"pdftohtml\"")
>> (string-append "PDFTOHTML = \"" (assoc-ref inputs "poppler")
>> "/bin/pdftohtml\"")))
Pushed as b65b78ff using your substitute snippet.
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-21 9:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-25 11:44 [bug#33868] [PATCH] gnu: calibre: Fix PDF to EPUB conversion Mathieu Othacehe
2019-01-06 17:56 ` Ludovic Courtès
2019-01-11 23:19 ` Marius Bakke
2019-01-12 22:43 ` Leo Famulari
2019-01-21 9:57 ` bug#33868: " Mathieu Othacehe
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.