From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:45555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giS0Z-0001T4-8Q for guix-patches@gnu.org; Sat, 12 Jan 2019 17:44:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1giS0Y-0004Fe-I0 for guix-patches@gnu.org; Sat, 12 Jan 2019 17:44:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57928) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1giS0Y-0004FI-Bq for guix-patches@gnu.org; Sat, 12 Jan 2019 17:44:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1giS0X-0006Pj-W6 for guix-patches@gnu.org; Sat, 12 Jan 2019 17:44:02 -0500 Subject: [bug#33868] [PATCH] gnu: calibre: Fix PDF to EPUB conversion. Resent-Message-ID: Date: Sat, 12 Jan 2019 17:43:09 -0500 From: Leo Famulari Message-ID: <20190112224309.GA16245@jasmine.lan> References: <20181225114427.2777-1-m.othacehe@gmail.com> <878szq7pet.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="azLHFNyN32YCQGCU" Content-Disposition: inline In-Reply-To: <878szq7pet.fsf@fastmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 33868@debbugs.gnu.org --azLHFNyN32YCQGCU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 12, 2019 at 12:19:54AM +0100, Marius Bakke wrote: > Mathieu Othacehe writes: >=20 > > When trying to convert a PDF to EPUB, the following error occurs: > > > > File "/gnu/store/kz6bgqw9z7akj11zh20wkx14cgq0s3n2-calibre-3.35.0/lib/= calibre/calibre/ebooks/pdf/pdftohtml.py", line 76, in pdftohtml > > _('Could not find pdftohtml, check it is in your PATH')) > > > > Move poppler which provides pdftohtml from inputs to propagated-inputs = to fix it. > > > > * gnu/packages/ebook.scm (calibre)[inputs]: Move poppler from here ... > > [propagated-inputs]: ... to here. >=20 > An less intrusive solution would be to substitute the absolute path to > 'pdf2html' in a build step. I.e.: >=20 > (substitute* "lib/calibre/calibre/ebooks/pdf/pdftohtml.py" > (("PDFTOHTML =3D \"pdftohtml\"") > (string-append "PDFTOHTML =3D \"" (assoc-ref inputs "poppler") > "/bin/pdftohtml\""))) >=20 > Either approach is fine by me, but please leave a comment about why > Poppler is propagated if you go that route :-) I think this substitution is the better solution. --azLHFNyN32YCQGCU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlw6bXoACgkQJkb6MLrK fwjzCQ/9Humtck0nakYdl8iDENEI9g3rVAOWblGnakcIAaSkhZFYg2yKfgiNVwXw 6ivY+yCq/3k/yB9TPnpv7NgYICmTPMTz4LbqW9qabZUyaRbW5w+Kwo7lowwGCD5J oNCG/kW4YcbC50+6KfuHROOauajGVHuczQfYmZnOsNeC8G7/BlvWjCYfmXndQkrW b6XCnJ1bEpQySLcsx25CgfG5dqQdKnnLUcZ4w4x93P2OCGdohysNGPBWjG1vBE22 GW3bB3vSG7t2YwdvkFI4H6yuoYqaDCq1I46QtaSqRb2eb+68PdJMVCohZ8pH5JYg /ZsxlxK5FQPLCQKCyYjUhWLDRbtCZdLCouB8/BsRhYphc+pYJlXRiCUqxIeEZmWm YUvm3lE4LEylQ4msSFb6wwdMz8q4nEHrVJ3u3Ue+hWH4tl82uYcRnc29X5jwt+w5 HgPpV+9xW6OBVY2a6HU5HfF3QdIP/FajaWILtcqTju9EDkbkqIYsKH8wsfQ4usQW p6WsYRti3ROcVCCyp8CNb+Apw6HSap/E37+LHLSXyNneeGMbsr8YvqePHhpBdlJJ 1hF9i2RtVNrx+l1wzPBvq100yvHWStrHhdoPhspcjZq7hW5mTA0uCP3W0o8d9gR1 0s3U6IoxoYFV/hIwvVcJuJ+pwiVFH+arF9BOgqQyh0fxamzlbEI= =WeB3 -----END PGP SIGNATURE----- --azLHFNyN32YCQGCU--