Re: 14/14: gnu: gnurl: Add HTTP/2 support.

Re: 14/14: gnu: gnurl: Add HTTP/2 support.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> nckx pushed a commit to branch core-updates
> in repository guix.
>
> commit 3d2d5ebffae6979376d64a6441a44eb4369a1e96
> Author: Tobias Geerinckx-Rice <me@tobias.gr>
> Date:   Thu Jan 4 22:49:22 2018 +0000
>
>     gnu: gnurl: Add HTTP/2 support.
>     
>     * gnu/packages/gnunet.scm (gnurl)[inputs]: Add nghttp2:lib.
> ---
>  gnu/packages/gnunet.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
> index 29bfc81..3b25bce 100644
> --- a/gnu/packages/gnunet.scm
> +++ b/gnu/packages/gnunet.scm
> @@ -198,6 +198,7 @@ authentication and support for SSL3 and TLS.")
>                "doc"))                             ; 1.5 MiB of man3 pages
>     (inputs `(("gnutls" ,gnutls/dane)
>               ("libidn" ,libidn)
> +             ("nghttp2" ,nghttp2 "lib")
>               ("zlib" ,zlib)))
>     (native-inputs
>      `(("libtool" ,libtool)

As far as I can tell, we don't have an nghttp2 package yet :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: 14/14: gnu: gnurl: Add HTTP/2 support.

[ng0]

[-- Attachment #1: Type: text/plain, Size: 1823 bytes --]

Marius Bakke transcribed 1.6K bytes:
> Tobias Geerinckx-Rice <me@tobias.gr> writes:
> 
> > nckx pushed a commit to branch core-updates
> > in repository guix.
> >
> > commit 3d2d5ebffae6979376d64a6441a44eb4369a1e96
> > Author: Tobias Geerinckx-Rice <me@tobias.gr>
> > Date:   Thu Jan 4 22:49:22 2018 +0000
> >
> >     gnu: gnurl: Add HTTP/2 support.
> >     
> >     * gnu/packages/gnunet.scm (gnurl)[inputs]: Add nghttp2:lib.
> > ---
> >  gnu/packages/gnunet.scm | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
> > index 29bfc81..3b25bce 100644
> > --- a/gnu/packages/gnunet.scm
> > +++ b/gnu/packages/gnunet.scm
> > @@ -198,6 +198,7 @@ authentication and support for SSL3 and TLS.")
> >                "doc"))                             ; 1.5 MiB of man3 pages
> >     (inputs `(("gnutls" ,gnutls/dane)
> >               ("libidn" ,libidn)
> > +             ("nghttp2" ,nghttp2 "lib")
> >               ("zlib" ,zlib)))
> >     (native-inputs
> >      `(("libtool" ,libtool)
> 
> As far as I can tell, we don't have an nghttp2 package yet :-)


Why? I don't even intend to support http/2 with gnURL.
gnURL is not cURL. Are there any reasons why this should be build in?

I'm open for suggestions and wouldn't make it a Guix exclusive thing.
I know that for example the inofficial Gentoo ebuild is still being
invoked with wrong configure flags.
I'm not even sure if the resulting gnurl in this case would include
http2 support, unless I missed disabling this in the configure script.

I hate it when more than 1 list is CC'd, but I'd like to get
input from some of the other GNUnet developers.

Thanks for notifying me.
-- 
ng0 ::  https://n0.is | https://crash.cx
A88C8ADD129828D7EAC02E52E22F9BBFEE348588

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: 14/14: gnu: gnurl: Add HTTP/2 support.

[Christian Grothoff]

[-- Attachment #1.1.1: Type: text/plain, Size: 1174 bytes --]

On 02/24/2018 10:43 PM, ng0 wrote:
> Marius Bakke transcribed 1.6K bytes:
>> Tobias Geerinckx-Rice <me@tobias.gr> writes:
>>
>>> nckx pushed a commit to branch core-updates
>>> in repository guix.
>>> +             ("nghttp2" ,nghttp2 "lib")
>> As far as I can tell, we don't have an nghttp2 package yet :-)
> 
> 
> Why? I don't even intend to support http/2 with gnURL.
> gnURL is not cURL. Are there any reasons why this should be build in?

Well, the idea of Gnurl was to be reasonably minimal and to avoid the
kitchen-sink dependencies (and unpredictability wrt SSL support) of the
original Curl. I personally don't see a need for http/2 at this point
(bad), especially as it adds additional dependencies (very bad) and
would not be available equally on all systems Gnurl runs on (very very bad).

My recommendation remains that Curl should be modified to dlopen()
extensions/plugins to load protocol/TLS-support extensions on-demand.
Until that happens, my view is that we should be very, very conservative
in terms of features we add to avoid creating another kitchen-sink. For
those with kitchen-sink requirements, there is always Curl...



[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 162 bytes --]

_______________________________________________
GNUnet-developers mailing list
GNUnet-developers@gnu.org
https://lists.gnu.org/mailman/listinfo/gnunet-developers

Re: 14/14: gnu: gnurl: Add HTTP/2 support.

[ng0]

[-- Attachment #1.1: Type: text/plain, Size: 2100 bytes --]

Christian Grothoff transcribed 3.7K bytes:
> On 02/24/2018 10:43 PM, ng0 wrote:
> > Marius Bakke transcribed 1.6K bytes:
> >> Tobias Geerinckx-Rice <me@tobias.gr> writes:
> >>
> >>> nckx pushed a commit to branch core-updates
> >>> in repository guix.
> >>> +             ("nghttp2" ,nghttp2 "lib")
> >> As far as I can tell, we don't have an nghttp2 package yet :-)
> > 
> > 
> > Why? I don't even intend to support http/2 with gnURL.
> > gnURL is not cURL. Are there any reasons why this should be build in?
> 
> Well, the idea of Gnurl was to be reasonably minimal and to avoid the
> kitchen-sink dependencies (and unpredictability wrt SSL support) of the
> original Curl. I personally don't see a need for http/2 at this point
> (bad), especially as it adds additional dependencies (very bad) and
> would not be available equally on all systems Gnurl runs on (very very bad).

I agree here and wasn't 100% sure on http/2. I just check the list of abilities
to not build only when I do the releases.

> My recommendation remains that Curl should be modified to dlopen()
> extensions/plugins to load protocol/TLS-support extensions on-demand.
> Until that happens,

This will take some time, cURL has some of your early criticism on their
todo list last time I've read the todo list, but we might be faster switching
to wget2. Only time will tell.

> my view is that we should be very, very conservative
> in terms of features we add to avoid creating another kitchen-sink. For
> those with kitchen-sink requirements, there is always Curl...

Okay. With this in mind, could anyone with access to the branches in Guix
revert this commit?
Furthermore, should I add a comment above the gnurl package definition wrt
the goals of gnURL and that it already gets build the way it is intended
to?

> _______________________________________________
> GNUnet-developers mailing list
> GNUnet-developers@gnu.org
> https://lists.gnu.org/mailman/listinfo/gnunet-developers


-- 
ng0 ::  https://n0.is | https://crash.cx
A88C8ADD129828D7EAC02E52E22F9BBFEE348588

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 162 bytes --]

_______________________________________________
GNUnet-developers mailing list
GNUnet-developers@gnu.org
https://lists.gnu.org/mailman/listinfo/gnunet-developers

Re: 14/14: gnu: gnurl: Add HTTP/2 support.

[ng0]

[-- Attachment #1.1: Type: text/plain, Size: 2624 bytes --]

ng0 transcribed 3.1K bytes:
> Christian Grothoff transcribed 3.7K bytes:
> > On 02/24/2018 10:43 PM, ng0 wrote:
> > > Marius Bakke transcribed 1.6K bytes:
> > >> Tobias Geerinckx-Rice <me@tobias.gr> writes:
> > >>
> > >>> nckx pushed a commit to branch core-updates
> > >>> in repository guix.
> > >>> +             ("nghttp2" ,nghttp2 "lib")
> > >> As far as I can tell, we don't have an nghttp2 package yet :-)
> > > 
> > > 
> > > Why? I don't even intend to support http/2 with gnURL.
> > > gnURL is not cURL. Are there any reasons why this should be build in?
> > 
> > Well, the idea of Gnurl was to be reasonably minimal and to avoid the
> > kitchen-sink dependencies (and unpredictability wrt SSL support) of the
> > original Curl. I personally don't see a need for http/2 at this point
> > (bad), especially as it adds additional dependencies (very bad) and
> > would not be available equally on all systems Gnurl runs on (very very bad).
> 
> I agree here and wasn't 100% sure on http/2. I just check the list of abilities
> to not build only when I do the releases.
> 
> > My recommendation remains that Curl should be modified to dlopen()
> > extensions/plugins to load protocol/TLS-support extensions on-demand.
> > Until that happens,
> 
> This will take some time, cURL has some of your early criticism on their
> todo list last time I've read the todo list, but we might be faster switching
> to wget2. Only time will tell.
> 
> > my view is that we should be very, very conservative
> > in terms of features we add to avoid creating another kitchen-sink. For
> > those with kitchen-sink requirements, there is always Curl...
> 
> Okay. With this in mind, could anyone with access to the branches in Guix
> revert this commit?
> Furthermore, should I add a comment above the gnurl package definition wrt
> the goals of gnURL and that it already gets build the way it is intended
> to?

Well there's one fixme, which is the same as for cURL in Guix: Get the certificates
working. patches in gnURL accepted, as well as anything that's better than my last
attempt in gnURL in Guix which broke builds on some systems.
I don't have the time to think of solutions for this at the moment.

> > _______________________________________________
> > GNUnet-developers mailing list
> > GNUnet-developers@gnu.org
> > https://lists.gnu.org/mailman/listinfo/gnunet-developers
> 
> 
> -- 
> ng0 ::  https://n0.is | https://crash.cx
> A88C8ADD129828D7EAC02E52E22F9BBFEE348588



-- 
ng0 ::  https://n0.is | https://crash.cx
A88C8ADD129828D7EAC02E52E22F9BBFEE348588

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 162 bytes --]

_______________________________________________
GNUnet-developers mailing list
GNUnet-developers@gnu.org
https://lists.gnu.org/mailman/listinfo/gnunet-developers

Re: 14/14: gnu: gnurl: Add HTTP/2 support.

[Tobias Geerinckx-Rice]

Hi ng0,

On 2018-02-24 23:07, ng0 wrote:
> Okay. With this in mind, could anyone with access to the branches in 
> Guix
> revert this commit?

Sure, I'll. This was just a thinko on my part, consistently misreading 
‘gnurl’ as ‘curl’ for some reason. A gnurl update wouldn't need to go to 
core-updates, after all.

> Furthermore, should I add a comment above the gnurl package definition 
> wrt
> the goals of gnURL and that it already gets build the way it is 
> intended
> to?

Seems overkill.

Kind regards,

T G-R

Sent from a Web browser. Excuse or enjoy my brevity.