[bug#28720] [PATCH 00/23] Enhance building KDE Frameworks.

[bug#28720] [PATCH 00/23] Enhance building KDE Frameworks.

[Hartmut Goebel]

This is another series of patches enhancing KDE Frameworks. I inspected the
log-files for each of the packages and added more optional inputs, reduced the
number of build warnings, etc.

This series was tested on top of the patches 28719
 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28719>. You can find both
series on the "wip-qt-paths" branch.

Hartmut Goebel (23):
  gnu: grantlee: Enable all tests.
  gnu: qtkeychain: Reduce the number of warnings when configuring.
  gnu: Update prison to 5.37.0.
  gnu: kcoreaddons: Add native-input shared-mime-info and a comment.
  gnu: kconfigwidgets: Add optional native-input kdoctools.
  gnu: kwallet: Add optional input qgpgme.
  gnu: kdesignerplugin: Add optional inputs.
  gnu: phonon: Enable building the Qt Designer plugin.
  gnu: kdnssd: Enable service discovery on local network via avahi.
  gnu: kfilemetadata: Enable support for PDF files and audio files.
  gnu: bluez-qt: Install udev-rules.
  gnu: bluez-qt: Add comment about status of tests.
  gnu: kparts: Make tests pass again.
  gnu: kio: Remove unused input.
  gnu: kio: Adopt a patch from Nix.
  gnu: kio: Symlink some files referred to by different names.
  gnu: kidletime: Enable fallback mode to X-Screensaver based poller.
  gnu: sonnet: Reduce the number of warnings when configuring.
  gnu: kglobalaccel: Reduce the number of warnings when configuring.
  gnu: kdeclarative: Reduce the number of warnings when configuring.
  gnu: Add kdewebkit.
  gnu: ktexteditor: Symlink some files referred to by different names.
  gnu: kdoctools: Symlink some files referred to by different names.

 gnu/packages/kde-frameworks.scm | 140 ++++++++++++++++++++++++++++++++++------
 gnu/packages/qt.scm             |  13 ++--
 2 files changed, 128 insertions(+), 25 deletions(-)

-- 
2.13.5

[bug#28720] [PATCH 00/23] Enhance building KDE Frameworks.

[Hartmut Goebel]

This is another series of patches enhancing KDE Frameworks. I inspected the
log-files for each of the packages and added more optional inputs, reduced the
number of build warnings, etc.

This series was tested on top of the patches 28719
 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28719>. You can find both
series on the "wip-qt-paths" branch.

Hartmut Goebel (23):
  gnu: grantlee: Enable all tests.
  gnu: qtkeychain: Reduce the number of warnings when configuring.
  gnu: Update prison to 5.37.0.
  gnu: kcoreaddons: Add native-input shared-mime-info and a comment.
  gnu: kconfigwidgets: Add optional native-input kdoctools.
  gnu: kwallet: Add optional input qgpgme.
  gnu: kdesignerplugin: Add optional inputs.
  gnu: phonon: Enable building the Qt Designer plugin.
  gnu: kdnssd: Enable service discovery on local network via avahi.
  gnu: kfilemetadata: Enable support for PDF files and audio files.
  gnu: bluez-qt: Install udev-rules.
  gnu: bluez-qt: Add comment about status of tests.
  gnu: kparts: Make tests pass again.
  gnu: kio: Remove unused input.
  gnu: kio: Adopt a patch from Nix.
  gnu: kio: Symlink some files referred to by different names.
  gnu: kidletime: Enable fallback mode to X-Screensaver based poller.
  gnu: sonnet: Reduce the number of warnings when configuring.
  gnu: kglobalaccel: Reduce the number of warnings when configuring.
  gnu: kdeclarative: Reduce the number of warnings when configuring.
  gnu: Add kdewebkit.
  gnu: ktexteditor: Symlink some files referred to by different names.
  gnu: kdoctools: Symlink some files referred to by different names.

 gnu/packages/kde-frameworks.scm | 140 ++++++++++++++++++++++++++++++++++------
 gnu/packages/qt.scm             |  13 ++--
 2 files changed, 128 insertions(+), 25 deletions(-)

-- 
2.13.5

[bug#28720] [PATCH 01/23] gnu: grantlee: Enable all tests.

[Hartmut Goebel]

* gnu/packages/qt.scm (grantlee)[arguments]
  <#:phases>'check-setup': New phase, set QT_QPA_PLATFORM=offscreen.
  <#:phases>'check': Remove phase.
---
 gnu/packages/qt.scm | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 775982757..6446a1043 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -78,6 +78,7 @@
         (sha256
          (base32 "1lf9rkv0i0kd7fvpgg5l8jb87zw8dzcwd1liv6hji7g4wlpmfdiq"))))
     (native-inputs
+     ;; Optional: lcov and cccc, both are for code coverage
      `(("doxygen" ,doxygen)))
     (inputs
      `(("qtbase" ,qtbase)
@@ -86,10 +87,11 @@
     (arguments
      `(#:phases
        (modify-phases %standard-phases
-         (replace 'check
-                  (lambda _
-                    (zero? (system* "ctest" ;; exclude 2 tests which require a display
-                                    "-E" "htmlbuildertest|plainmarkupbuildertest")))))))
+         (add-before 'check 'check-setup
+           (lambda _
+             ;; make Qt render "offscreen", required for tests
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             #t)))))
     (home-page "https://github.com/steveire/grantlee")
     (synopsis "Libraries for text templating with Qt")
     (description "Grantlee Templates can be used for theming and generation of
-- 
2.13.5

[bug#28720] [PATCH 02/23] gnu: qtkeychain: Reduce the number of warnings when configuring.

[Hartmut Goebel]

* gnu/packages/qt.scm (qtkeychain)[native-inputs]: Add pkg-config.
---
 gnu/packages/qt.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 6446a1043..31852b632 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -1561,7 +1561,8 @@ This package provides the Python bindings.")))
          (base32 "0bxi5pfhxdvwk8yxa06lk2d7lcibmfqhahbin82bqf3m341zd4ml"))))
     (build-system cmake-build-system)
     (native-inputs
-     `(("qttools" ,qttools)))
+     `(("pkg-config" ,pkg-config)
+       ("qttools" ,qttools)))
     (inputs
      `(("qtbase" ,qtbase)))
     (arguments
-- 
2.13.5

[bug#28720] [PATCH 03/23] gnu: Update prison to 5.37.0.

[Hartmut Goebel]

Align with the version of other kde-frameworks packages.

* gnu/package/kde-frameworks.scm (prision): Update to 5.37.0
---
 gnu/packages/kde-frameworks.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index a503226d6..51eee8a28 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1223,7 +1223,7 @@ system.")
 (define-public prison
   (package
     (name "prison")
-    (version "5.34.0")
+    (version "5.37.0")
     (source
      (origin
        (method url-fetch)
@@ -1231,7 +1231,7 @@ system.")
                            (version-major+minor version) "/"
                            name "-" version ".tar.xz"))
        (sha256
-        (base32 "00wj4yyfhhcq9b54civ5hy1grz70mmi676x50y12crcbbgkxm1lx"))))
+        (base32 "1icsirwfh7zscm8x9g2gp7aqzhs81ahhjflwjcwpz9bh0r9f1wb7"))))
     (build-system cmake-build-system)
     (native-inputs
      `(("extra-cmake-modules" ,extra-cmake-modules)))
-- 
2.13.5

[bug#28720] [PATCH 04/23] gnu: kcoreaddons: Add native-input shared-mime-info and a comment.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kcoreaddons)[native-inputs]:
  Add shared-mime-info.
---
 gnu/packages/kde-frameworks.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 51eee8a28..c71bec129 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -550,6 +550,8 @@ propagate their changes to their respective configuration files.")
     (native-inputs
      `(("extra-cmake-modules" ,extra-cmake-modules)
        ("qttools" ,qttools)
+       ("shared-mime-info" ,shared-mime-info)
+       ;; TODO: FAM: File alteration notification http://oss.sgi.com/projects/fam
        ("xorg-server" ,xorg-server))) ; for the tests
     (inputs
      `(("qtbase" ,qtbase)))
-- 
2.13.5

[bug#28720] [PATCH 05/23] gnu: kconfigwidgets: Add optional native-input kdoctools.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kconfigwidgets)[native-inputs]:
  Add kdoctools.
---
 gnu/packages/kde-frameworks.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index c71bec129..02685e5a3 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2007,7 +2007,8 @@ KCModules can be created with the KConfigWidgets framework.")
        ("kconfig" ,kconfig)
        ("kwidgetsaddons" ,kwidgetsaddons)))
     (native-inputs
-     `(("extra-cmake-modules" ,extra-cmake-modules)))
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("kdoctools" ,kdoctools)))
     (inputs
      `(("kcoreaddons" ,kcoreaddons)
        ("kguiaddons" ,kguiaddons)
-- 
2.13.5

[bug#28720] [PATCH 06/23] gnu: kwallet: Add optional input qgpgme.

[Hartmut Goebel]

Gpgme was already there, QGpgme was missing.

* gnu/packages/kde-frameworks.scm (kwallet)[inputs]: Add qgpgme.
---
 gnu/packages/kde-frameworks.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 02685e5a3..a4197e5aa 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2874,7 +2874,7 @@ It supports rich text as well as plain text.")
     (native-inputs
      `(("extra-cmake-modules" ,extra-cmake-modules)))
     (inputs
-     `(("gpgme" ,gpgme) ;; TODO: Add gpgme Qt-bindings
+     `(("gpgme" ,gpgme)
        ("kauth" ,kauth)
        ("kcodecs" ,kcodecs)
        ("kconfig" ,kconfig)
@@ -2890,6 +2890,7 @@ It supports rich text as well as plain text.")
        ("kwindowsystem" ,kwindowsystem)
        ("libgcrypt" ,libgcrypt)
        ("phonon" ,phonon)
+       ("qgpgme" ,qgpgme)
        ("qtbase" ,qtbase)))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "Safe desktop-wide storage for passwords")
-- 
2.13.5

[bug#28720] [PATCH 07/23] gnu: kdesignerplugin: Add optional inputs.

[Hartmut Goebel]

Still missing: kwebkit (KF5WebKitConfig.cmake).

* gnu/packages/kde-frameworks.scm (kdesignerplugin)[inputs]: Add kcompletion,
  kconfigwidgets, kiconthemes, kitemviews, kkio, kplotting, ktextwidgets,
  kwidgetsaddons, kxmlgui, sonnet.
---
 gnu/packages/kde-frameworks.scm | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index a4197e5aa..129f96324 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2145,7 +2145,19 @@ started on demand.")
      `(("kconfig" ,kconfig)
        ("kcoreaddons" ,kcoreaddons)
        ("kdoctools" ,kdoctools)
-       ("qtbase" ,qtbase)))
+       ("qtbase" ,qtbase)
+       ;; optional:
+       ("kcompletion" ,kcompletion)
+       ("kconfigwidgets" ,kconfigwidgets)
+       ("kiconthemes" ,kiconthemes)
+       ("kitemviews" ,kitemviews)
+       ("kio" ,kio)
+       ("kplotting" ,kplotting)
+       ("ktextwidgets" ,ktextwidgets)
+       ;; TODO: ("kwebkit" ,kwebkit) KF5WebKitConfig.cmake
+       ("kwidgetsaddons" ,kwidgetsaddons)
+       ("kxmlgui" ,kxmlgui)
+       ("sonnet" ,sonnet)))
     (arguments
      `(#:phases
        (modify-phases %standard-phases
-- 
2.13.5

[bug#28720] [PATCH 08/23] gnu: phonon: Enable building the Qt Designer plugin.

[Hartmut Goebel]

Add native-inputs pkg-config, qttools and update comments.

This enables building the Qt Designer plugin.

* gnu/packages/kde-frameworks.scm (phonon): [native-inputs]: Add pkg-config,
  qttools.  [arguments]<#configure-flags>: Remove
  PHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT
---
 gnu/packages/kde-frameworks.scm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 129f96324..3e3830433 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -138,16 +138,17 @@ common build settings used in software produced by the KDE community.")
                 "177647r2jqfm32hqcz2nqfqv6v48hn5ab2vc31svba2wz23fkgk7"))))
     (build-system cmake-build-system)
     (native-inputs
-     ;; TODO: Add qttools to build the Qt Designer plugin.
      ;; TODO: Think about adding pulseaudio. Is it required for sound?
-     `(("extra-cmake-modules" ,extra-cmake-modules)))
+     ;; TODO: Add bulding the super experimental QML support
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)
+       ("qttools", qttools)))
     (inputs
      `(("qtbase" ,qtbase)))
     (arguments
      `(#:configure-flags
        '("-DCMAKE_CXX_FLAGS=-fPIC"
-         "-DPHONON_BUILD_PHONON4QT5=ON"
-         "-DPHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT=ON")
+         "-DPHONON_BUILD_PHONON4QT5=ON")
        #:phases
        (modify-phases %standard-phases
          (add-before 'install 'patch-installdir
-- 
2.13.5

[bug#28720] [PATCH 09/23] gnu: kdnssd: Enable service discovery on local network via avahi.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kdnssd)[inputs]: Add avahi.
---
 gnu/packages/kde-frameworks.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 3e3830433..9f7bb41b7 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -31,6 +31,7 @@
   #:use-module (gnu packages admin)
   #:use-module (gnu packages aidc)
   #:use-module (gnu packages attr)
+  #:use-module (gnu packages avahi)
   #:use-module (gnu packages base)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages bison)
@@ -637,7 +638,8 @@ as well as an API to create KDED modules.")
      `(("extra-cmake-modules" ,extra-cmake-modules)
        ("qttools" ,qttools)))
     (inputs
-     `(("qtbase" ,qtbase)))
+     `(("avahi" ,avahi) ; alternativly dnssd could be used
+       ("qtbase" ,qtbase)))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "Network service discovery using Zeroconf")
     (description "KDNSSD is a library for handling the DNS-based Service
-- 
2.13.5

[bug#28720] [PATCH 10/23] gnu: kfilemetadata: Enable support for PDF files and audio files.

[Hartmut Goebel]

- Qt5 Multimedia module is needed to bild an extractor for audio files.
- poppler, which was defined as input, is not including the requested Qt
  support, thus poppler-qt is needed.

* gnu/packages/kde-frameworks.scm (kfilemetadata)[inuts]: Add qtmultimedia,
  replace poppler by poppler-qt5. [native-inputs]: Add pkg-config.
---
 gnu/packages/kde-frameworks.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 9f7bb41b7..3134a4c73 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1505,18 +1505,21 @@ from DocBook files.")
              #t)))))
     (native-inputs
      `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)
        ("python-2" ,python-2)))
     (inputs
      `(("attr" ,attr)
+       ;; TODO: EPub http://sourceforge.net/projects/ebook-tools
        ("karchive" ,karchive)
        ("ki18n" ,ki18n)
+       ("qtmultimedia" ,qtmultimedia)
        ("qtbase" ,qtbase)
        ;; Required run-time packages
        ("catdoc" ,catdoc)
        ;; Optional run-time packages
        ("exiv2" ,exiv2)
        ("ffmpeg" ,ffmpeg)
-       ("poppler" ,poppler)
+       ("poppler-qt5" ,poppler-qt5) ;; runtime??
        ("taglib" ,taglib)))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "Extract metadata from different fileformats")
-- 
2.13.5

[bug#28720] [PATCH 11/23] gnu: bluez-qt: Install udev-rules.

[Hartmut Goebel]

This requires setting UDEV_RULES_INSTALL_DIR since the CMakeLists.txt does not
base this any prefix.

* gnu/packages/kde-frameworks.scm (bluez-qt)[arguments]<#:configure-flags>:
  Remove INSTALL_UDEV_RULE=OFF, add UDEV_RULES_INSTALL_DIR.
---
 gnu/packages/kde-frameworks.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 3134a4c73..9bd3f74cf 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -319,7 +319,8 @@ http://freedesktop.org/wiki/Specifications/open-collaboration-services/")
      `(("qtbase" ,qtbase)))
     (arguments
      `(#:configure-flags
-       '("-DINSTALL_UDEV_RULE:BOOL=OFF")
+       (list (string-append
+              "-DUDEV_RULES_INSTALL_DIR=" %output "/lib/udev/rules.d"))
        #:tests? #f)) ; DBUS_FATAL_WARNINGS=0 still yields 7/8 tests failing
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "QML wrapper for BlueZ")
-- 
2.13.5

[bug#28720] [PATCH 12/23] gnu: bluez-qt: Add comment about status of tests.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (bluez-qt)[arguments]: Add comment.
---
 gnu/packages/kde-frameworks.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 9bd3f74cf..2a238b091 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -321,7 +321,9 @@ http://freedesktop.org/wiki/Specifications/open-collaboration-services/")
      `(#:configure-flags
        (list (string-append
               "-DUDEV_RULES_INSTALL_DIR=" %output "/lib/udev/rules.d"))
-       #:tests? #f)) ; DBUS_FATAL_WARNINGS=0 still yields 7/8 tests failing
+       ;; TODO: Make tests pass: DBUS_FATAL_WARNINGS=0 still yields 7/8 tests
+       ;; failing.  When running after install, tests hang.
+       #:tests? #f))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "QML wrapper for BlueZ")
     (description "bluez-qt is a Qt-style library for accessing the bluez
-- 
2.13.5

[bug#28720] [PATCH 13/23] gnu: kparts: Make tests pass again.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kparts)[native-inputs]: Add
  shared-mime-info.
---
 gnu/packages/kde-frameworks.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 2a238b091..633c6630e 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2585,7 +2585,9 @@ notifications which can be embedded in your application.")
        ("ktextwidgets" ,ktextwidgets)
        ("kxmlgui" ,kxmlgui)))
     (native-inputs
-     `(("extra-cmake-modules" ,extra-cmake-modules)))
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("shared-mime-info" ,shared-mime-info)
+       ))
     (inputs
      `(("kauth" ,kauth)
        ("kbookmarks" ,kbookmarks)
-- 
2.13.5

[bug#28720] [PATCH 14/23] gnu: kio: Remove unused input.

[Hartmut Goebel]

This "acl" is not the "libacl" kio wants, but that libacl is not yet
available. Added a commend instead.

* gnu/packages/kde-frameworks.scm (kio)[inputs]: Remove acl.
---
 gnu/packages/kde-frameworks.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 633c6630e..6c13e4647 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2420,7 +2420,7 @@ makes starting KDE applications faster and reduces memory consumption.")
      `(("dbus" ,dbus)
        ("extra-cmake-modules" ,extra-cmake-modules)))
     (inputs
-     `(("acl" ,acl)
+     `(;; TODO:  LibACL , <ftp://oss.sgi.com/projects/xfs/cmd_tars>
        ("krb5" ,mit-krb5)
        ("karchive" ,karchive)
        ("kauth" ,kauth)
-- 
2.13.5

[bug#28720] [PATCH 15/23] gnu: kio: Adopt a patch from Nix.

[Hartmut Goebel]

* gnu/package/kde-frameworks.scm (kio)[arguments]
  <#:phases>'patch': New phase.
---
 gnu/packages/kde-frameworks.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 6c13e4647..50ed4391d 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2445,6 +2445,14 @@ makes starting KDE applications faster and reduces memory consumption.")
      `(#:tests? #f ; FIXME: 41/50 tests fail.
        #:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'patch
+           (lambda _
+             ;; Better error message (taken from nix)
+             (substitute* "src/kiod/kiod_main.cpp"
+               (("(^\\s*qCWarning(KIOD_CATEGORY) << \"Error loading plugin:\")( << loader.errorString();)" _ a b)
+                (string-append a "<< name" b)))
+             ;; TODO: samba-search-path.patch from nix: search smbd on $PATH
+             #t))
          (add-before 'check 'check-setup
            (lambda _
              (setenv "HOME" (getcwd))
-- 
2.13.5

[bug#28720] [PATCH 16/23] gnu: kio: Symlink some files referred to by different names.

[Hartmut Goebel]

* gnu/package/kde-frameworks.scm (kio)[arguments]
  <#:phases>'add-symlinks': New phase.
---
 gnu/packages/kde-frameworks.scm | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 50ed4391d..b180caf8c 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2459,7 +2459,16 @@ makes starting KDE applications faster and reduces memory consumption.")
              (setenv "XDG_RUNTIME_DIR" (getcwd))
              ;; make Qt render "offscreen", required for tests
              (setenv "QT_QPA_PLATFORM" "offscreen")
-             #t)))))
+             #t))
+         (add-after 'install 'add-symlinks
+           ;; Some package(s) (e.g. bluedevil) refer to these service types by
+           ;; the wrong name.  I would prefer to patch those packages, but I
+           ;; cannot find the files!
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((kst5 (string-append (assoc-ref outputs "out")
+                                        "/share/kservicetypes5/")))
+               (symlink (string-append kst5 "kfileitemactionplugin.desktop")
+                        (string-append kst5 "kfileitemaction-plugin.desktop"))))))))
     ;;(replace 'check
     ;;  (lambda _
     ;;    (setenv "DBUS_FATAL_WARNINGS" "0")
-- 
2.13.5

[bug#28720] [PATCH 17/23] gnu: kidletime: Enable fallback mode to X-Screensaver based poller.

[Hartmut Goebel]

Also reduce the number of warnings when configuring.

This does no harm and reduced the number of warnings.

* gnu/packages/kde-frameworks.scm (kidletime)[inputs]: Add
  libxscrnsaver. [native-inputs]: Add pkg-config.
---
 gnu/packages/kde-frameworks.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index b180caf8c..5cd5efd48 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -747,9 +747,11 @@ translation scripting.")
                 "01m4q3l2yq83f2dpbv6jry7cjkj6bqdgfpy5b8byaf1gf9w2firs"))))
     (build-system cmake-build-system)
     (native-inputs
-     `(("extra-cmake-modules" ,extra-cmake-modules)))
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)))
     (inputs
-     `(("qtbase" ,qtbase)
+     `(("libxscrnsaver" ,libxscrnsaver) ; X-Screensaver based poller, fallback mode
+       ("qtbase" ,qtbase)
        ("qtx11extras" ,qtx11extras)))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "Reporting of idle time of user and system")
-- 
2.13.5

[bug#28720] [PATCH 18/23] gnu: sonnet: Reduce the number of warnings when configuring.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (sonnet)[native-inputs]: Add pkg-config.
---
 gnu/packages/kde-frameworks.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 5cd5efd48..88c462d06 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1271,6 +1271,7 @@ provides uniform access to generation of barcodes with data.")
     (build-system cmake-build-system)
     (native-inputs
      `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)
        ("qttools" ,qttools)))
     (inputs
      `(("hunspell" ,hunspell)
-- 
2.13.5

[bug#28720] [PATCH 19/23] gnu: kglobalaccel: Reduce the number of warnings when configuring.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kglobalaccel)[native-inputs]: Add
  pkg-config.
---
 gnu/packages/kde-frameworks.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 88c462d06..3e78caabc 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2274,6 +2274,7 @@ emoticons coming from different providers.")
     (build-system cmake-build-system)
     (native-inputs
      `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)
        ("qttools" ,qttools)))
     (inputs
      `(("kconfig" ,kconfig)
-- 
2.13.5

[bug#28720] [PATCH 20/23] gnu: kdeclarative: Reduce the number of warnings when configuring.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (kdeclarative)[inputs]: Add libepoxy.
  [native-inputs]: Add pkg-config.
---
 gnu/packages/kde-frameworks.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 3e78caabc..90c839e15 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -43,6 +43,7 @@
   #:use-module (gnu packages flex)
   #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages gettext)
+  #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gnupg)
@@ -2061,6 +2062,7 @@ their settings.")
        ("kpackage" ,kpackage)))
     (native-inputs
      `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)
        ("xorg-server" ,xorg-server)))
     (inputs
      `(("kauth" ,kauth)
@@ -2080,6 +2082,7 @@ their settings.")
        ("kwidgetsaddons" ,kwidgetsaddons)
        ("kwindowsystem" ,kwindowsystem)
        ("kxmlgui" ,kxmlgui)
+       ("libepoxy", libepoxy)
        ("qtbase" ,qtbase)
        ("qtdeclarative" ,qtdeclarative)
        ("solid" ,solid)))
-- 
2.13.5

[bug#28720] [PATCH 21/23] gnu: Add kdewebkit.

[Hartmut Goebel]

* gnu/package/kde-frameworks.scm (kdewebkit): New variable.
---
 gnu/packages/kde-frameworks.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 90c839e15..5a4fe2ff0 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2946,6 +2946,38 @@ desktop-wide storage for passwords and the kwalletd daemon used to safely store
 the passwords on KDE work spaces.")
     (license license:lgpl2.1+)))
 
+(define-public kdewebkit
+  (package
+    (name "kdewebkit")
+    (version "5.37.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://kde/stable/frameworks/"
+                    (version-major+minor version) "/"
+                    name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "1ph3a50wix42hmsbc9jbfxla172aihjx9yzp9rza09j1a7va3hg1"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)))
+    (inputs
+     `(("kconfig" ,kconfig)
+       ("kcoreaddons" ,kcoreaddons)
+       ("kio" ,kio)
+       ("kjobwidgets" ,kjobwidgets)
+       ("kparts" ,kparts)
+       ("kservice" ,kservice)
+       ("kwallet" ,kwallet)
+       ("qtbase" ,qtbase)
+       ("qtwebkit" ,qtwebkit)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "KDE Integration for QtWebKit")
+    (description "This library provides KDE integration of the HTML rendering
+engine WebKit via QtWebKit.")
+    (license license:lgpl2.1+)))
+
 (define-public kxmlgui
   (package
     (name "kxmlgui")
-- 
2.13.5

[bug#28720] [PATCH 22/23] gnu: ktexteditor: Symlink some files referred to by different names.

[Hartmut Goebel]

* gnu/package/kde-frameworks.scm (ktexteditor)[arguments]
  <#:phases>'add-symlinks': New phase.
---
 gnu/packages/kde-frameworks.scm | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 5a4fe2ff0..8c0a33677 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2848,7 +2848,16 @@ types or handled by application specific code.")
              (setenv "HOME" (getcwd))
              ;; make Qt render "offscreen", required for tests
              (setenv "QT_QPA_PLATFORM" "offscreen")
-             #t)))))
+             #t))
+         (add-after 'install 'add-symlinks
+           ;; Some package(s) (e.g. plasma-sdk) refer to these service types
+           ;; by the wrong name.  I would prefer to patch those packages, but
+           ;; I cannot find the files!
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((kst5 (string-append (assoc-ref outputs "out")
+                                        "/share/kservicetypes5/")))
+               (symlink (string-append kst5 "ktexteditorplugin.desktop")
+                        (string-append kst5 "ktexteditor-plugin.desktop"))))))))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "Full text editor component")
     (description "KTextEditor provides a powerful text editor component that you
-- 
2.13.5

[bug#28720] [PATCH 23/23] gnu: kdoctools: Symlink some files referred to by different names.

[Hartmut Goebel]

* gnu/package/kde-frameworks.scm (kdoctools)[arguments]
  <#:phases>'add-symlinks': New phase.
---
 gnu/packages/kde-frameworks.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 8c0a33677..1c725413b 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2034,7 +2034,15 @@ KCModules can be created with the KConfigWidgets framework.")
            (lambda _
              ;; make Qt render "offscreen", required for tests
              (setenv "QT_QPA_PLATFORM" "offscreen")
-             #t)))))
+             #t))
+         (add-after 'install 'add-symlinks
+           ;; Some package(s) (e.g. plasma-desktop) refer to these locales by
+           ;; a different spelling.
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((xsl (string-append (assoc-ref outputs "out")
+                                        "share/kf5/kdoctools/customization/xsl/")))
+               (symlink (string-append kst5 "pt_br.xml")
+                        (string-append kst5 "pt-BR.xml"))))))))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "Widgets for configuration dialogs")
     (description "KConfigWidgets provides easy-to-use classes to create
-- 
2.13.5

[bug#28720] [PATCH 08/23] gnu: phonon: Enable building the Qt Designer plugin.

[Thomas Danckaert]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> Add native-inputs pkg-config, qttools and update comments.
>
> This enables building the Qt Designer plugin.
>
> * gnu/packages/kde-frameworks.scm (phonon): [native-inputs]: Add pkg-config,
>   qttools.  [arguments]<#configure-flags>: Remove
>   PHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT

I'm not sure what this does (or: used to do), so I don't know if this
removal needs a further comment.

> +     ;; TODO: Add bulding the super experimental QML support

There's a typo in your TODO ;-)

Just to comment on something, because otherwise all these patches LGTM (assuming
they still build, which I didn't verify).

Thomas

[bug#28720] [PATCH 10/23] gnu: kfilemetadata: Enable support for PDF files and audio files.

[Thomas Danckaert]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> - Qt5 Multimedia module is needed to bild an extractor for audio files.
> - poppler, which was defined as input, is not including the requested Qt
>   support, thus poppler-qt is needed.
>
> * gnu/packages/kde-frameworks.scm (kfilemetadata)[inuts]: Add qtmultimedia,
>   replace poppler by poppler-qt5. [native-inputs]: Add pkg-config.
>
> [...]
>
> -       ("poppler" ,poppler)
> +       ("poppler-qt5" ,poppler-qt5) ;; runtime??

What do you mean with this comment?

Thomas

[bug#28720] [PATCH 17/23] gnu: kidletime: Enable fallback mode to X-Screensaver based poller.

[Thomas Danckaert]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> Also reduce the number of warnings when configuring.
>
> This does no harm and reduced the number of warnings.

1 of this sentences is redundant?

Thomas

[bug#28720] [PATCH 07/23] gnu: kdesignerplugin: Add optional inputs.

[Thomas Danckaert]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> Still missing: kwebkit (KF5WebKitConfig.cmake).

One of your later patches adds kwebkit, so this could be fixed?  Or is
something wrong with KF5WebKitConfig.cmake even after adding kwebkit?

Thomas

[bug#28720] [PATCH 00/23] Enhance building KDE Frameworks.

[Thomas Danckaert]

Hi Hartmut,

thanks for your work on this!

I think most of these patches are fine.  Maybe you can still shorten the
commit messages here and there?  (I think comments like "Align with the
version of other kde-frameworks packages."  as you wrote with the prison
update, can be left out.)  Otherwise I only commented on a few patches,
really nitpicking actually...

Thomas

[bug#28720] [PATCH 08/23] gnu: phonon: Enable building the Qt Designer plugin.

[Hartmut Goebel]

Hallo Thomas,

thanks for reviewing to quickly :-)

Am 06.10.2017 um 16:02 schrieb Thomas Danckaert:
> Hartmut Goebel <h.goebel@crazy-compilers.com> writes:
>
>> * gnu/packages/kde-frameworks.scm (phonon): [native-inputs]: Add pkg-config,
>>   qttools.  [arguments]<#configure-flags>: Remove
>>   PHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT
> I'm not sure what this does (or: used to do), so I don't know if this
> removal needs a further comment.

Without this change the Phonon Qt-Extension would be installed into
/gnu/store/…-qtbase-…/. I'll add this to the change
>> +     ;; TODO: Add bulding the super experimental QML support
> There's a typo in your TODO ;-)

Well spotted.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

[bug#28720] [PATCH 10/23] gnu: kfilemetadata: Enable support for PDF files and audio files.

[Hartmut Goebel]

Am 06.10.2017 um 16:04 schrieb Thomas Danckaert:
> Hartmut Goebel <h.goebel@crazy-compilers.com> writes:
>
>> [...]
>>
>> -       ("poppler" ,poppler)
>> +       ("poppler-qt5" ,poppler-qt5) ;; runtime??
> What do you mean with this comment?

Thanks for spotting. Most proably this means "is this a run-time-only
dependency"?) I'll have to check and change.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

[bug#28720] [PATCH 17/23] gnu: kidletime: Enable fallback mode to X-Screensaver based poller.

[Hartmut Goebel]

Am 06.10.2017 um 16:08 schrieb Thomas Danckaert:
> 1 of this sentences is redundant?

Not really. Adding pkgconfig only has the use of reducing the number of
warnings when configuring.

What do you think about:

"This does no harm and reduced the number of warnings. Also pkg-config
was added to reduce the number of warnings further."

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

[bug#28720] [PATCH 07/23] gnu: kdesignerplugin: Add optional inputs.

[Hartmut Goebel]

Am 06.10.2017 um 16:12 schrieb Thomas Danckaert:
> One of your later patches adds kwebkit, so this could be fixed?  Or is
> something wrong with KF5WebKitConfig.cmake even after adding kwebkit?

I assume we can enable kwebkit here. I added kwebkit much later so I did
not remember this one. I will try and update the patch accordingly.

Well spotted :-)

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

[bug#28720] [PATCH 00/23] Enhance building KDE Frameworks.

[Hartmut Goebel]

Am 06.10.2017 um 16:16 schrieb Thomas Danckaert:
> Maybe you can still shorten the
> commit messages here and there?  (I think comments like "Align with the
> version of other kde-frameworks packages."  as you wrote with the prison
> update, can be left out.)

Well, this may be a matter of taste. While maintaining PyInstaller, i
learned that it is important to not only state *what* has been changed,
but often also *why* [*]. This will help to understand years later if
this change is still relevant or not. And regarding notes like "Align
with the rest": These are just to avoid somebody is wasting time
thinking "Why the h*ll was only this package updated and not the others."

[*] I have to admit that I'm not doing this here consistently. See
PHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

[bug#28720] [PATCH 17/23] gnu: kidletime: Enable fallback mode to X-Screensaver based poller.

[Thomas Danckaert]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>
Subject: Re: [bug#28720] [PATCH 17/23] gnu: kidletime: Enable 
fallback mode to X-Screensaver based poller.
Date: Fri, 6 Oct 2017 16:35:34 +0200

> What do you think about:
>
> "This does no harm and reduced the number of warnings. Also 
> pkg-config
> was added to reduce the number of warnings further."

Yes, that's clearer.

Thank you!

Thomas

[bug#28720] [PATCH 00/23] Enhance building KDE Frameworks.

[Thomas Danckaert]

From: Hartmut Goebel <h.goebel@crazy-compilers.com>
Subject: Re: [bug#28720] [PATCH 00/23] Enhance building KDE 
Frameworks.
Date: Fri, 6 Oct 2017 16:59:30 +0200

>> Maybe you can still shorten the
>> commit messages here and there?  (I think comments like "Align 
>> with the
>> version of other kde-frameworks packages."  as you wrote with the 
>> prison
>> update, can be left out.)
>
> Well, this may be a matter of taste.

Yes, I think so too.

(FYI: I don't have any more comments on this patch series, so from my 
side: feel free to push this when you're satisfied with it.)

Thomas

bug#28720: merged

[Hartmut Goebel]

Pushed as 109461f919141522a2fdd5e0779f78b98bd1e0e8, addressing Thomas'
comments, esp. adding kebwebkit to kdesignerplugin

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |