From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0U6i-0005i3-6e for guix-patches@gnu.org; Fri, 06 Oct 2017 11:00:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0U6d-0000WE-7L for guix-patches@gnu.org; Fri, 06 Oct 2017 11:00:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:44807) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0U6d-0000Vx-3t for guix-patches@gnu.org; Fri, 06 Oct 2017 11:00:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e0U6c-0003Hb-Pi for guix-patches@gnu.org; Fri, 06 Oct 2017 11:00:02 -0400 Subject: [bug#28720] [PATCH 00/23] Enhance building KDE Frameworks. Resent-Message-ID: References: <20171006121420.30821-1-h.goebel@crazy-compilers.com> <20171006121636.30904-1-h.goebel@crazy-compilers.com> From: Hartmut Goebel Message-ID: Date: Fri, 6 Oct 2017 16:59:30 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Thomas Danckaert Cc: 28720@debbugs.gnu.org Am 06.10.2017 um 16:16 schrieb Thomas Danckaert: > Maybe you can still shorten the > commit messages here and there? (I think comments like "Align with the= > version of other kde-frameworks packages." as you wrote with the priso= n > update, can be left out.) Well, this may be a matter of taste. While maintaining PyInstaller, i learned that it is important to not only state *what* has been changed, but often also *why* [*]. This will help to understand years later if this change is still relevant or not. And regarding notes like "Align with the rest": These are just to avoid somebody is wasting time thinking "Why the h*ll was only this package updated and not the others."= [*] I have to admit that I'm not doing this here consistently. See PHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT. --=20 Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |