bug#25728: [PATCH 2/2] gnu: Add colorforth.

bug#25728: [PATCH 2/2] gnu: Add colorforth.

[ng0]

Ricardo Wurmus transcribed 3.5K bytes:
> 
> contact.ng0@cryptolab.net writes:
> 
> > From: ng0 <ngillmann@runbox.com>
> >
> > * gnu/packages/forth.scm (colorforth): New variable.
> > ---
> 
> The patch to change the module name is fine (although I’d move the
> copyright update to this patch).
> 
> >  gnu/packages/forth.scm | 38 ++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 38 insertions(+)
> >
> > diff --git a/gnu/packages/forth.scm b/gnu/packages/forth.scm
> > index 21a0fc2de..8854a9246 100644
> > --- a/gnu/packages/forth.scm
> > +++ b/gnu/packages/forth.scm
> > @@ -21,7 +21,9 @@
> >    #:use-module ((guix licenses) #:prefix license:)
> >    #:use-module (guix packages)
> >    #:use-module (guix download)
> > +  #:use-module (guix git-download)
> >    #:use-module (guix build-system gnu)
> > +  #:use-module (gnu packages assembly)
> >    #:use-module (gnu packages m4))
> >  
> >  (define-public gforth
> > @@ -58,3 +60,39 @@ and history.  A generic virtual machine environment, vmgen, is also
> >  included.")
> >      (home-page "https://www.gnu.org/software/gforth/")
> >      (license license:gpl3+)))
> > +
> > +(define-public colorforth
> > +  (let ((commit "94aec438f1ded202681f18801b98c52dc3beee41")
> > +        (revision "1"))
> > +    (package
> > +      (name "colorforth")
> > +      (version (string-append "0.0.0-" revision "." (string-take commit 7)))
> > +      (source (origin
> > +                (method git-fetch)
> > +                (uri (git-reference
> > +                      (url "https://github.com/narke/colorForth")
> > +                      (commit commit)))
> > +                (sha256
> > +                 (base32
> > +                  "0s602k568bm6vmvpahsms77liicg38vksn59j5m8ax4h9l9ca77r"))))
> > +      (arguments
> > +       `(#:tests? #f
> > +         #:phases
> > +         (modify-phases %standard-phases
> > +           (delete 'configure) ; no configure script
> > +           (replace 'install ; There is no 'install
> 
> Please change the comment to “no install target” or similar.  “no
> 'install” is confusing because “'install” is a quoted symbol and that
> has no meaning outside of Scheme.
> 
> > +             (lambda _
> > +               (install-file "cf2012.img"
> > +                             (string-append (assoc-ref %outputs "out")
> > +                                            "/bin")))))))
> 
> Please use “outputs” instead of “%outputs”.  Is the target “bin”
> directory created during the build?
> 
> Please also make the phase end with “#t”.
> 
> > +      (native-inputs
> > +       `(("nasm" ,nasm)))
> > +      (build-system gnu-build-system)
> > +      (home-page "https://github.com/narke/colorForth")
> > +      (synopsis "Native 32-bit colorForth for PCs, Bochs and Qemu")
> > +      (description
> > +       "Native colorForth for 32-bit PCs, at least compilable on Linux
> > + and runnable on both Bochs and Qemu.  It is adapted from
> > + @url{http://sourceforge.net/projects/colorforth, colorforth}.
> > + The original colorforth is public domain software.")
> 
> Please change the description.  The first sentence fragment should be a
> full sentence.  I don’t think “32-bit PCs” should be mentioned, nor
> should compatibility with Linux be mentioned (do they mean the kernel or
> GNU?).  Also the last sentence should not be included.

Okay.

> Could you write a description that describes the package, i.e. tells
> potential users why they would want to use it?

I will try, I'm not a colorforth user myself.

> Looks like it’s written in x86 assembly.  This would be worth mentioning
> (and I think that’s what “32-bit PCs” implied).
> 
> Could you please send an updated patch?
> 
> -- 
> Ricardo
> 
> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
> https://elephly.net
> 

-- 
PGP and more: https://people.pragmatique.xyz/ng0/

bug#25728: [PATCH 2/2] gnu: Add colorforth.

[ng0]

[-- Attachment #1: Type: text/plain, Size: 91 bytes --]

Version two of the patches attached.
-- 
PGP and more: https://people.pragmatique.xyz/ng0/

[-- Attachment #2: 0001-gnu-Rename-gforth-module-to-forth.patch --]
[-- Type: text/plain, Size: 1830 bytes --]

From 56502e9a3b9b0cbb84322238233ad70a9057750e Mon Sep 17 00:00:00 2001
From: ng0 <ngillmann@runbox.com>
Date: Thu, 6 Oct 2016 22:08:31 +0000
Subject: [PATCH 1/2] gnu: Rename gforth module to forth.

* gnu/local.mk (GNU_SYSTEM_MODULES): Rename gforth.scm to forth.scm.
* gnu/packages/gforth.scm: Rename file to forth.scm.
* gnu/packages/forth.scm: Renamed from gforth.scm.
---
 gnu/local.mk                           | 2 +-
 gnu/packages/{gforth.scm => forth.scm} | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
 rename gnu/packages/{gforth.scm => forth.scm} (98%)

diff --git a/gnu/local.mk b/gnu/local.mk
index 82e94171b..385e323aa 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -140,6 +140,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/fonts.scm			\
   %D%/packages/fontutils.scm			\
   %D%/packages/fpga.scm				\
+  %D%/packages/forth.scm			\
   %D%/packages/freedesktop.scm			\
   %D%/packages/freeipmi.scm			\
   %D%/packages/ftp.scm				\
@@ -154,7 +155,6 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/gdb.scm				\
   %D%/packages/geo.scm				\
   %D%/packages/gettext.scm			\
-  %D%/packages/gforth.scm			\
   %D%/packages/ghostscript.scm			\
   %D%/packages/gimp.scm				\
   %D%/packages/gkrellm.scm			\
diff --git a/gnu/packages/gforth.scm b/gnu/packages/forth.scm
similarity index 98%
rename from gnu/packages/gforth.scm
rename to gnu/packages/forth.scm
index b2a67ce58..6d66faf5d 100644
--- a/gnu/packages/gforth.scm
+++ b/gnu/packages/forth.scm
@@ -17,7 +17,7 @@
 ;;; You should have received a copy of the GNU General Public License
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
-(define-module (gnu packages gforth)
+(define-module (gnu packages forth)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix download)
-- 
2.12.2


[-- Attachment #3: 0002-gnu-Add-colorforth.patch --]
[-- Type: text/plain, Size: 3037 bytes --]

From 9c0221c7558b6d87124563fdc4fdde5c32a0374d Mon Sep 17 00:00:00 2001
From: ng0 <ngillmann@runbox.com>
Date: Thu, 6 Oct 2016 22:31:46 +0000
Subject: [PATCH 2/2] gnu: Add colorforth.

* gnu/packages/forth.scm (colorforth): New variable.
---
 gnu/packages/forth.scm | 44 +++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 43 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/forth.scm b/gnu/packages/forth.scm
index 6d66faf5d..42723b2a5 100644
--- a/gnu/packages/forth.scm
+++ b/gnu/packages/forth.scm
@@ -1,5 +1,5 @@
 ;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
+;;; Copyright © 2016, 2017 ng0 <ng0@no-reply.pragmatique.xyz>
 ;;; Copyright © 2016 Sou Bunnbu <iyzsong@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -21,7 +21,9 @@
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
+  #:use-module (gnu packages assembly)
   #:use-module (gnu packages m4))
 
 (define-public gforth
@@ -58,3 +60,43 @@ and history.  A generic virtual machine environment, vmgen, is also
 included.")
     (home-page "https://www.gnu.org/software/gforth/")
     (license license:gpl3+)))
+
+(define-public colorforth
+  (let ((commit "94aec438f1ded202681f18801b98c52dc3beee41")
+        (revision "1"))
+    (package
+      (name "colorforth")
+      (version (string-append "0.0.0-" revision "." (string-take commit 7)))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/narke/colorForth")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "0s602k568bm6vmvpahsms77liicg38vksn59j5m8ax4h9l9ca77r"))))
+      (arguments
+       `(#:tests? #f
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'configure) ;No configure script
+           (replace 'install ;No install target
+             (lambda* (#:key outputs #:allow-other-keys)
+               (install-file "cf2012.img"
+                             (string-append (assoc-ref outputs "out")
+                                            "/bin"))
+               #t)))))
+      (native-inputs
+       `(("nasm" ,nasm)))
+      (build-system gnu-build-system)
+      (home-page "https://github.com/narke/colorForth")
+      (synopsis "Native 32-bit colorForth for PCs, Bochs and Qemu")
+      (description
+       "Colorforth is a @code{colorForth} implementation written in
+x86 assembly.  It is a dialect of Forth that uses color to replace
+punctation, includes its own operating system and produces extremely
+compact programs.  Applications compile from pre-parsed source.
+Colorforth applications can be run using @code{Bochs} and @code{Qemu}.
+It is adapted from @url{http://sourceforge.net/projects/colorforth,
+colorforth}.")
+      (license license:public-domain))))
-- 
2.12.2

[bug#25728] [PATCH 2/2] gnu: Add colorforth.

[Ricardo Wurmus]

ng0 <contact.ng0@cryptolab.net> writes:

> Version two of the patches attached.
> --
[…]

>>From 9c0221c7558b6d87124563fdc4fdde5c32a0374d Mon Sep 17 00:00:00 2001
> From: ng0 <ngillmann@runbox.com>
> Date: Thu, 6 Oct 2016 22:31:46 +0000
> Subject: [PATCH 2/2] gnu: Add colorforth.
>
> * gnu/packages/forth.scm (colorforth): New variable.
> ---
[…]
> +
> +(define-public colorforth
> +  (let ((commit "94aec438f1ded202681f18801b98c52dc3beee41")
> +        (revision "1"))
> +    (package
> +      (name "colorforth")
> +      (version (string-append "0.0.0-" revision "." (string-take commit 7)))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/narke/colorForth")
> +                      (commit commit)))
> +                (sha256
> +                 (base32
> +                  "0s602k568bm6vmvpahsms77liicg38vksn59j5m8ax4h9l9ca77r"))))
> +      (arguments
> +       `(#:tests? #f

There should be a comment to explain why tests are disabled.

> +         #:phases
> +         (modify-phases %standard-phases
> +           (delete 'configure) ;No configure script
> +           (replace 'install ;No install target
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (install-file "cf2012.img"
> +                             (string-append (assoc-ref outputs "out")
> +                                            "/bin"))
> +               #t)))))

If I understood this correctly, this is not an executable.  One is
supposed to run this with qemu.  This means that it doesn’t belong in
“bin”.

> +      (native-inputs
> +       `(("nasm" ,nasm)))
> +      (build-system gnu-build-system)
> +      (home-page "https://github.com/narke/colorForth")
> +      (synopsis "Native 32-bit colorForth for PCs, Bochs and Qemu")
> +      (description
> +       "Colorforth is a @code{colorForth} implementation written in
> +x86 assembly.  It is a dialect of Forth that uses color to replace
> +punctation, includes its own operating system and produces extremely
> +compact programs.  Applications compile from pre-parsed source.
> +Colorforth applications can be run using @code{Bochs} and @code{Qemu}.
> +It is adapted from @url{http://sourceforge.net/projects/colorforth,
> +colorforth}.")
> +      (license license:public-domain))))

I could not find a license statement anywhere in the repository.  How do
you know it’s public domain software?

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

[bug#25728] [PATCH 2/2] gnu: Add colorforth.

[ng0]

[-- Attachment #1: Type: text/plain, Size: 3181 bytes --]

Ricardo Wurmus transcribed 2.5K bytes:
> 
> ng0 <contact.ng0@cryptolab.net> writes:
> 
> > Version two of the patches attached.
> > --
> […]
> 
> >>From 9c0221c7558b6d87124563fdc4fdde5c32a0374d Mon Sep 17 00:00:00 2001
> > From: ng0 <ngillmann@runbox.com>
> > Date: Thu, 6 Oct 2016 22:31:46 +0000
> > Subject: [PATCH 2/2] gnu: Add colorforth.
> >
> > * gnu/packages/forth.scm (colorforth): New variable.
> > ---
> […]
> > +
> > +(define-public colorforth
> > +  (let ((commit "94aec438f1ded202681f18801b98c52dc3beee41")
> > +        (revision "1"))
> > +    (package
> > +      (name "colorforth")
> > +      (version (string-append "0.0.0-" revision "." (string-take commit 7)))
> > +      (source (origin
> > +                (method git-fetch)
> > +                (uri (git-reference
> > +                      (url "https://github.com/narke/colorForth")
> > +                      (commit commit)))
> > +                (sha256
> > +                 (base32
> > +                  "0s602k568bm6vmvpahsms77liicg38vksn59j5m8ax4h9l9ca77r"))))
> > +      (arguments
> > +       `(#:tests? #f
> 
> There should be a comment to explain why tests are disabled.
> 
> > +         #:phases
> > +         (modify-phases %standard-phases
> > +           (delete 'configure) ;No configure script
> > +           (replace 'install ;No install target
> > +             (lambda* (#:key outputs #:allow-other-keys)
> > +               (install-file "cf2012.img"
> > +                             (string-append (assoc-ref outputs "out")
> > +                                            "/bin"))
> > +               #t)))))
> 
> If I understood this correctly, this is not an executable.  One is
> supposed to run this with qemu.  This means that it doesn’t belong in
> “bin”.

Could you propose a directory? I would pick 'share/colorforth/'.

> > +      (native-inputs
> > +       `(("nasm" ,nasm)))
> > +      (build-system gnu-build-system)
> > +      (home-page "https://github.com/narke/colorForth")
> > +      (synopsis "Native 32-bit colorForth for PCs, Bochs and Qemu")
> > +      (description
> > +       "Colorforth is a @code{colorForth} implementation written in
> > +x86 assembly.  It is a dialect of Forth that uses color to replace
> > +punctation, includes its own operating system and produces extremely
> > +compact programs.  Applications compile from pre-parsed source.
> > +Colorforth applications can be run using @code{Bochs} and @code{Qemu}.
> > +It is adapted from @url{http://sourceforge.net/projects/colorforth,
> > +colorforth}.")
> > +      (license license:public-domain))))
> 
> I could not find a license statement anywhere in the repository.  How do
> you know it’s public domain software?

I think I assumed by the software it was based on.
Great, one of these github-style software productions.
Thanks, I'll ask the author to include a statement.

> --
> Ricardo
> 
> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
> https://elephly.net
> 

-- 
ng0
OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
https://krosos.org/~/ng0/ https://www.infotropique.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#25728] [PATCH 2/2] gnu: Add colorforth.

[Ricardo Wurmus]

ng0 <ng0@infotropique.org> writes:

>> > +         #:phases
>> > +         (modify-phases %standard-phases
>> > +           (delete 'configure) ;No configure script
>> > +           (replace 'install ;No install target
>> > +             (lambda* (#:key outputs #:allow-other-keys)
>> > +               (install-file "cf2012.img"
>> > +                             (string-append (assoc-ref outputs "out")
>> > +                                            "/bin"))
>> > +               #t)))))
>> 
>> If I understood this correctly, this is not an executable.  One is
>> supposed to run this with qemu.  This means that it doesn’t belong in
>> “bin”.
>
> Could you propose a directory? I would pick 'share/colorforth/'.

That sounds good to me.  It’s a bit sad that there’s no executable.
Users (like myself) may not know how to actually run this without
a dive into the manual.

>> > +      (license license:public-domain))))
>> 
>> I could not find a license statement anywhere in the repository.  How do
>> you know it’s public domain software?
>
> I think I assumed by the software it was based on.
> Great, one of these github-style software productions.
> Thanks, I'll ask the author to include a statement.

Thank you.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

[bug#25728] [PATCH 2/2] gnu: Add colorforth.

[ng0]

[-- Attachment #1: Type: text/plain, Size: 2278 bytes --]

Ricardo Wurmus transcribed 1.3K bytes:
> 
> ng0 <ng0@infotropique.org> writes:
> 
> >> > +         #:phases
> >> > +         (modify-phases %standard-phases
> >> > +           (delete 'configure) ;No configure script
> >> > +           (replace 'install ;No install target
> >> > +             (lambda* (#:key outputs #:allow-other-keys)
> >> > +               (install-file "cf2012.img"
> >> > +                             (string-append (assoc-ref outputs "out")
> >> > +                                            "/bin"))
> >> > +               #t)))))
> >> 
> >> If I understood this correctly, this is not an executable.  One is
> >> supposed to run this with qemu.  This means that it doesn’t belong in
> >> “bin”.
> >
> > Could you propose a directory? I would pick 'share/colorforth/'.
> 
> That sounds good to me.  It’s a bit sad that there’s no executable.
> Users (like myself) may not know how to actually run this without
> a dive into the manual.
> 
> >> > +      (license license:public-domain))))
> >> 
> >> I could not find a license statement anywhere in the repository.  How do
> >> you know it’s public domain software?
> >
> > I think I assumed by the software it was based on.
> > Great, one of these github-style software productions.
> > Thanks, I'll ask the author to include a statement.

->->->
Date: Wed, 28 Jun 2017 04:16:23 -0400
From: Konstantin Tcholokachvili
To: ng0
Subject: Re: colorforth has no license statement

Hi,
It's the original colorForth, modified by some people to port it from MASM to NASM but I didn't modified anything, I just make it easy to build and test.
It's of course in public domain, I updated the README to make it much more clear.

Ask more questions if you desire.

Regards,

Sent with [ProtonMail](https://protonmail.com) Secure Email.
->->->

There's now a note in the readme that it is in the
public domain. If that is enough I will update the
patch and send an update.

> Thank you.
> 
> -- 
> Ricardo
> 
> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
> https://elephly.net
> 
> 

-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
infotropique: https://www.infotropique.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#25728] [PATCH 2/2] gnu: Add colorforth.

[Ricardo Wurmus]

ng0 <ng0@infotropique.org> writes:

[…]
> ->->->
> Date: Wed, 28 Jun 2017 04:16:23 -0400
> From: Konstantin Tcholokachvili
> To: ng0
> Subject: Re: colorforth has no license statement
>
> Hi,
> It's the original colorForth, modified by some people to port it from MASM to NASM but I didn't modified anything, I just make it easy to build and test.
> It's of course in public domain, I updated the README to make it much more clear.
>
> Ask more questions if you desire.
>
> Regards,
>
> Sent with [ProtonMail](https://protonmail.com) Secure Email.
> ->->->
>
> There's now a note in the readme that it is in the
> public domain. If that is enough I will update the
> patch and send an update.

Thank you for asking for clarification on the license.  In principle
it’s all good now and I was about to commit it when I tried to run it…

I updated to the latest commit to include the license notice and changed
the install directory to what we agreed on.  Unfortunately, I cannot
actually run it.

--8<---------------cut here---------------start------------->8---
[…]
@ build-succeeded /gnu/store/0rpv1wy7kvv24bq3d7zdmx355akgzjm3-colorforth-0.0.0-1.b518ff9.drv -
/gnu/store/n8zzma00m0hy2i688brixbfq33r6icxp-colorforth-0.0.0-1.b518ff9
rekado in guix [env]: qemu-system-i386 -boot a  -fda /gnu/store/n8zzma00m0hy2i688brixbfq33r6icxp-colorforth-0.0.0-1.b518ff9/share/colorforth/cf2012.img 
qemu-system-i386: -fda /gnu/store/n8zzma00m0hy2i688brixbfq33r6icxp-colorforth-0.0.0-1.b518ff9/share/colorforth/cf2012.img: Could not open '/gnu/store/n8zzma00m0hy2i688brixbfq33r6icxp-colorforth-0.0.0-1.b518ff9/share/colorforth/cf2012.img': Permission denied
rekado in guix [env]: cp /gnu/store/n8zzma00m0hy2i688brixbfq33r6icxp-colorforth-0.0.0-1.b518ff9/share/colorforth/cf2012.img .
rekado in guix [env]: qemu-system-i386 -boot a  -fda cf2012.img 
qemu-system-i386: -fda cf2012.img: Could not open 'cf2012.img': Permission denied
rekado in guix [env]: chmod +w cf2012.img 
rekado in guix [env]: qemu-system-i386 -boot a  -fda cf2012.img 
WARNING: Image format was not specified for 'cf2012.img' and probing guessed raw.
         Automatically detecting the format is dangerous for raw images, write operations on block 0 will be restricted.
         Specify the 'raw' format explicitly to remove the restrictions.
qemu-system-i386: Trying to execute code outside RAM or ROM at 0x8998c426
This usually means one of the following happened:

(1) You told QEMU to execute a kernel for the wrong machine type, and it crashed on startup (eg trying to run a raspberry pi kernel on a versatilepb QEMU machine)
(2) You didn't give QEMU a kernel or BIOS filename at all, and QEMU executed a ROM full of no-op instructions until it fell off the end
(3) Your guest kernel has a bug and crashed by jumping off into nowhere

This is almost always one of the first two, so check your command line and that you are using the right type of kernel for this machine.
If you think option (3) is likely then you can try debugging your guest with the -d debug options; in particular -d guest_errors will cause the log to include a dump of the guest register state at this point.

Execution cannot continue; stopping here.
--8<---------------cut here---------------end--------------->8---

It won’t work when it’s in the store because we cannot write to the
store.  Even after copying it out of the store and changing permissions
it would simply crash.  This could be a problem with my Libreboot
machine, but the first problem is bad enough.

If the software cannot be used when it is installed to the store then I
don’t think it should be in the store at all.  I think we should drop
this patch as the package is not actually usable.

What do you think?

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

[bug#25728] [PATCH 2/2] gnu: Add colorforth.

[Ricardo Wurmus]

Ricardo Wurmus <rekado@elephly.net> writes:

> It won’t work when it’s in the store because we cannot write to the
> store.  Even after copying it out of the store and changing permissions
> it would simply crash.  This could be a problem with my Libreboot
> machine, but the first problem is bad enough.
>
> If the software cannot be used when it is installed to the store then I
> don’t think it should be in the store at all.  I think we should drop
> this patch as the package is not actually usable.
>
> What do you think?

The alternative is to also install a wrapper script to “bin” that
essentially does this:

    #!/bin/sh
    qemu-system-i386 -snapshot -boot a -fda $prefix/share/colorforth/cf2012.img

It still crashes for me but at least it doesn’t complain about store
permissions.  If you can get this to run on your computer then please
send a final patch that incorporates all of these suggestions.
Otherwise I think it may not be worth spending more time on a toy
package like this.

What do you think?

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

[bug#25728] [PATCH 2/2] gnu: Add colorforth.

[Ricardo Wurmus]

Ricardo Wurmus <rekado@elephly.net> writes:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> It won’t work when it’s in the store because we cannot write to the
>> store.  Even after copying it out of the store and changing permissions
>> it would simply crash.  This could be a problem with my Libreboot
>> machine, but the first problem is bad enough.
>>
>> If the software cannot be used when it is installed to the store then I
>> don’t think it should be in the store at all.  I think we should drop
>> this patch as the package is not actually usable.
>>
>> What do you think?
>
> The alternative is to also install a wrapper script to “bin” that
> essentially does this:
>
>     #!/bin/sh
>     qemu-system-i386 -snapshot -boot a -fda $prefix/share/colorforth/cf2012.img
>
> It still crashes for me but at least it doesn’t complain about store
> permissions.  If you can get this to run on your computer then please
> send a final patch that incorporates all of these suggestions.
> Otherwise I think it may not be worth spending more time on a toy
> package like this.
>
> What do you think?

FWIW here’s the latest version of the diff:

--8<---------------cut here---------------start------------->8---
diff --git a/gnu/packages/forth.scm b/gnu/packages/forth.scm
index 6d66faf5d..4ab8f20a9 100644
--- a/gnu/packages/forth.scm
+++ b/gnu/packages/forth.scm
@@ -1,5 +1,5 @@
 ;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
+;;; Copyright © 2016, 2017 ng0 <ng0@no-reply.pragmatique.xyz>
 ;;; Copyright © 2016 Sou Bunnbu <iyzsong@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -21,7 +21,9 @@
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix download)
+  #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
+  #:use-module (gnu packages assembly)
   #:use-module (gnu packages m4))
 
 (define-public gforth
@@ -58,3 +60,42 @@ and history.  A generic virtual machine environment, vmgen, is also
 included.")
     (home-page "https://www.gnu.org/software/gforth/")
     (license license:gpl3+)))
+
+(define-public colorforth
+  (let ((commit "b518ff966955f0b196e7bb8f85337284fa23e29e")
+        (revision "1"))
+    (package
+      (name "colorforth")
+      (version (string-append "0.0.0-" revision "." (string-take commit 7)))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/narke/colorForth.git")
+                      (commit commit)))
+                (sha256
+                 (base32
+                  "1q5szb9yi3nspbvnq0js6w24sb936ahjk828il760p0xpj5dsl45"))))
+      (arguments
+       `(#:tests? #f
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'configure)          ; No configure script
+           (replace 'install            ; No install target
+             (lambda* (#:key outputs #:allow-other-keys)
+               (install-file "cf2012.img"
+                             (string-append (assoc-ref outputs "out")
+                                            "/share/colorforth/"))
+               #t)))))
+      (native-inputs
+       `(("nasm" ,nasm)))
+      (build-system gnu-build-system)
+      (home-page "https://github.com/narke/colorForth")
+      (synopsis "Native 32-bit colorForth for PCs, Bochs and Qemu")
+      (description
+       "Colorforth is a @code{colorForth} implementation written in x86
+assembly.  It is a dialect of Forth that uses color to replace punctation,
+includes its own operating system and produces extremely compact programs.
+Applications compile from pre-parsed source.  Colorforth applications can be
+run using @code{Bochs} and @code{Qemu}.  It is adapted from
+@url{http://sourceforge.net/projects/colorforth, colorforth}.")
+      (license license:public-domain))))
--8<---------------cut here---------------end--------------->8---


-- 
Ricardo
  
  GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
  https://elephly.net

[bug#25728] [PATCH 2/2] gnu: Add colorforth.

[ng0]

[-- Attachment #1: Type: text/plain, Size: 4836 bytes --]

Hi Ricardo,

I myself am running Coreboot and libreboot, but I have Vendor BIOS
machines I can test on aswell.

Thanks for your testing and notes. I will try this as soon as I have
time and get back to you with results.

Ricardo Wurmus transcribed 4.0K bytes:
> 
> Ricardo Wurmus <rekado@elephly.net> writes:
> 
> > Ricardo Wurmus <rekado@elephly.net> writes:
> >
> >> It won’t work when it’s in the store because we cannot write to the
> >> store.  Even after copying it out of the store and changing permissions
> >> it would simply crash.  This could be a problem with my Libreboot
> >> machine, but the first problem is bad enough.
> >>
> >> If the software cannot be used when it is installed to the store then I
> >> don’t think it should be in the store at all.  I think we should drop
> >> this patch as the package is not actually usable.
> >>
> >> What do you think?
> >
> > The alternative is to also install a wrapper script to “bin” that
> > essentially does this:
> >
> >     #!/bin/sh
> >     qemu-system-i386 -snapshot -boot a -fda $prefix/share/colorforth/cf2012.img
> >
> > It still crashes for me but at least it doesn’t complain about store
> > permissions.  If you can get this to run on your computer then please
> > send a final patch that incorporates all of these suggestions.
> > Otherwise I think it may not be worth spending more time on a toy
> > package like this.
> >
> > What do you think?
> 
> FWIW here’s the latest version of the diff:
> 
> --8<---------------cut here---------------start------------->8---
> diff --git a/gnu/packages/forth.scm b/gnu/packages/forth.scm
> index 6d66faf5d..4ab8f20a9 100644
> --- a/gnu/packages/forth.scm
> +++ b/gnu/packages/forth.scm
> @@ -1,5 +1,5 @@
>  ;;; GNU Guix --- Functional package management for GNU
> -;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
> +;;; Copyright © 2016, 2017 ng0 <ng0@no-reply.pragmatique.xyz>
>  ;;; Copyright © 2016 Sou Bunnbu <iyzsong@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
> @@ -21,7 +21,9 @@
>    #:use-module ((guix licenses) #:prefix license:)
>    #:use-module (guix packages)
>    #:use-module (guix download)
> +  #:use-module (guix git-download)
>    #:use-module (guix build-system gnu)
> +  #:use-module (gnu packages assembly)
>    #:use-module (gnu packages m4))
>  
>  (define-public gforth
> @@ -58,3 +60,42 @@ and history.  A generic virtual machine environment, vmgen, is also
>  included.")
>      (home-page "https://www.gnu.org/software/gforth/")
>      (license license:gpl3+)))
> +
> +(define-public colorforth
> +  (let ((commit "b518ff966955f0b196e7bb8f85337284fa23e29e")
> +        (revision "1"))
> +    (package
> +      (name "colorforth")
> +      (version (string-append "0.0.0-" revision "." (string-take commit 7)))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/narke/colorForth.git")
> +                      (commit commit)))
> +                (sha256
> +                 (base32
> +                  "1q5szb9yi3nspbvnq0js6w24sb936ahjk828il760p0xpj5dsl45"))))
> +      (arguments
> +       `(#:tests? #f
> +         #:phases
> +         (modify-phases %standard-phases
> +           (delete 'configure)          ; No configure script
> +           (replace 'install            ; No install target
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (install-file "cf2012.img"
> +                             (string-append (assoc-ref outputs "out")
> +                                            "/share/colorforth/"))
> +               #t)))))
> +      (native-inputs
> +       `(("nasm" ,nasm)))
> +      (build-system gnu-build-system)
> +      (home-page "https://github.com/narke/colorForth")
> +      (synopsis "Native 32-bit colorForth for PCs, Bochs and Qemu")
> +      (description
> +       "Colorforth is a @code{colorForth} implementation written in x86
> +assembly.  It is a dialect of Forth that uses color to replace punctation,
> +includes its own operating system and produces extremely compact programs.
> +Applications compile from pre-parsed source.  Colorforth applications can be
> +run using @code{Bochs} and @code{Qemu}.  It is adapted from
> +@url{http://sourceforge.net/projects/colorforth, colorforth}.")
> +      (license license:public-domain))))
> --8<---------------cut here---------------end--------------->8---
> 
> 
> -- 
> Ricardo
>   
>   GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
>   https://elephly.net
> 
> 

-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#25728] [PATCH 2/2] gnu: Add colorforth.

[ng0]

[-- Attachment #1: Type: text/plain, Size: 5043 bytes --]

Ricardo Wurmus transcribed 4.0K bytes:
> 
> Ricardo Wurmus <rekado@elephly.net> writes:
> 
> > Ricardo Wurmus <rekado@elephly.net> writes:
> >
> >> It won’t work when it’s in the store because we cannot write to the
> >> store.  Even after copying it out of the store and changing permissions
> >> it would simply crash.  This could be a problem with my Libreboot
> >> machine, but the first problem is bad enough.
> >>
> >> If the software cannot be used when it is installed to the store then I
> >> don’t think it should be in the store at all.  I think we should drop
> >> this patch as the package is not actually usable.

I can confirm the crashes on coreboot.
Last October (patch date) is a while back so I can't be sure if
my memory of colorforth working on vendor BIOS is correct.

> >> What do you think?

I have another theory: We both don't know how this is supposed
to be used and the example on the github page is not helping.

I CC'd the author of the software. Konstantin, do you know if we are doing anything
obviously wrong in what we've tried in this bug/qa thread?

> > The alternative is to also install a wrapper script to “bin” that
> > essentially does this:
> >
> >     #!/bin/sh
> >     qemu-system-i386 -snapshot -boot a -fda $prefix/share/colorforth/cf2012.img
> >
> > It still crashes for me but at least it doesn’t complain about store
> > permissions.  If you can get this to run on your computer then please
> > send a final patch that incorporates all of these suggestions.
> > Otherwise I think it may not be worth spending more time on a toy
> > package like this.
> >
> > What do you think?
> 
> FWIW here’s the latest version of the diff:
> 
> --8<---------------cut here---------------start------------->8---
> diff --git a/gnu/packages/forth.scm b/gnu/packages/forth.scm
> index 6d66faf5d..4ab8f20a9 100644
> --- a/gnu/packages/forth.scm
> +++ b/gnu/packages/forth.scm
> @@ -1,5 +1,5 @@
>  ;;; GNU Guix --- Functional package management for GNU
> -;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
> +;;; Copyright © 2016, 2017 ng0 <ng0@no-reply.pragmatique.xyz>
>  ;;; Copyright © 2016 Sou Bunnbu <iyzsong@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
> @@ -21,7 +21,9 @@
>    #:use-module ((guix licenses) #:prefix license:)
>    #:use-module (guix packages)
>    #:use-module (guix download)
> +  #:use-module (guix git-download)
>    #:use-module (guix build-system gnu)
> +  #:use-module (gnu packages assembly)
>    #:use-module (gnu packages m4))
>  
>  (define-public gforth
> @@ -58,3 +60,42 @@ and history.  A generic virtual machine environment, vmgen, is also
>  included.")
>      (home-page "https://www.gnu.org/software/gforth/")
>      (license license:gpl3+)))
> +
> +(define-public colorforth
> +  (let ((commit "b518ff966955f0b196e7bb8f85337284fa23e29e")
> +        (revision "1"))
> +    (package
> +      (name "colorforth")
> +      (version (string-append "0.0.0-" revision "." (string-take commit 7)))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/narke/colorForth.git")
> +                      (commit commit)))
> +                (sha256
> +                 (base32
> +                  "1q5szb9yi3nspbvnq0js6w24sb936ahjk828il760p0xpj5dsl45"))))
> +      (arguments
> +       `(#:tests? #f
> +         #:phases
> +         (modify-phases %standard-phases
> +           (delete 'configure)          ; No configure script
> +           (replace 'install            ; No install target
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (install-file "cf2012.img"
> +                             (string-append (assoc-ref outputs "out")
> +                                            "/share/colorforth/"))
> +               #t)))))
> +      (native-inputs
> +       `(("nasm" ,nasm)))
> +      (build-system gnu-build-system)
> +      (home-page "https://github.com/narke/colorForth")
> +      (synopsis "Native 32-bit colorForth for PCs, Bochs and Qemu")
> +      (description
> +       "Colorforth is a @code{colorForth} implementation written in x86
> +assembly.  It is a dialect of Forth that uses color to replace punctation,
> +includes its own operating system and produces extremely compact programs.
> +Applications compile from pre-parsed source.  Colorforth applications can be
> +run using @code{Bochs} and @code{Qemu}.  It is adapted from
> +@url{http://sourceforge.net/projects/colorforth, colorforth}.")
> +      (license license:public-domain))))
> --8<---------------cut here---------------end--------------->8---
> 
> 
> -- 
> Ricardo
>   
>   GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
>   https://elephly.net
> 
> 

-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#25728] [PATCH 2/2] gnu: Add colorforth.

[Konstantin Tcholokachvili]

[-- Attachment #1: Type: text/plain, Size: 5493 bytes --]

Hi ng0,

I've been on holidays and I didn't checked my emails.
Sadly, in fact there is a regression with qemu version 2.6 onwards, I filed a bug report to qemu team but they didn't investigated yet. For the moment the only solution is to:
1. Use older qemu ;
2. Usse Bochs.

This issue was reported here: https://github.com/narke/colorForth/issues/2

I'm also writing another implementation of colorForth in C but it's not finished yet.

Regards.

Sent with [ProtonMail](https://protonmail.com) Secure Email.

> -------- Original Message --------
> Subject: Re: [bug#25728] [PATCH 2/2] gnu: Add colorforth.
> Local Time: July 23, 2017 10:35 AM
> UTC Time: July 23, 2017 8:35 AM
> From: ng0@infotropique.org
> To: Ricardo Wurmus <rekado@elephly.net>
> ng0 <ng0@infotropique.org>, 25728@debbugs.gnu.org, Konstantin Tcholokachvili <konstantin.tcholokachvili@protonmail.com>
>
> Ricardo Wurmus transcribed 4.0K bytes:
>>
>> Ricardo Wurmus <rekado@elephly.net> writes:
>>
>> > Ricardo Wurmus <rekado@elephly.net> writes:
>> >
>> >> It won’t work when it’s in the store because we cannot write to the
>> >> store. Even after copying it out of the store and changing permissions
>> >> it would simply crash. This could be a problem with my Libreboot
>> >> machine, but the first problem is bad enough.
>> >>
>> >> If the software cannot be used when it is installed to the store then I
>> >> don’t think it should be in the store at all. I think we should drop
>> >> this patch as the package is not actually usable.
>
> I can confirm the crashes on coreboot.
> Last October (patch date) is a while back so I can"t be sure if
> my memory of colorforth working on vendor BIOS is correct.
>
>> >> What do you think?
>
> I have another theory: We both don"t know how this is supposed
> to be used and the example on the github page is not helping.
>
> I CC"d the author of the software. Konstantin, do you know if we are doing anything
> obviously wrong in what we"ve tried in this bug/qa thread?
>
>> > The alternative is to also install a wrapper script to “bin” that
>> > essentially does this:
>> >
>> > #!/bin/sh
>> > qemu-system-i386 -snapshot -boot a -fda $prefix/share/colorforth/cf2012.img
>> >
>> > It still crashes for me but at least it doesn’t complain about store
>> > permissions. If you can get this to run on your computer then please
>> > send a final patch that incorporates all of these suggestions.
>> > Otherwise I think it may not be worth spending more time on a toy
>> > package like this.
>> >
>> > What do you think?
>>
>> FWIW here’s the latest version of the diff:
>>
>> --8<---------------cut here---------------start------------->8---
>> diff --git a/gnu/packages/forth.scm b/gnu/packages/forth.scm
>> index 6d66faf5d..4ab8f20a9 100644
>> --- a/gnu/packages/forth.scm
>> +++ b/gnu/packages/forth.scm
>> @@ -1,5 +1,5 @@
>> ;;; GNU Guix --- Functional package management for GNU
>> -;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
>> +;;; Copyright © 2016, 2017 ng0 <ng0@no-reply.pragmatique.xyz>
>> ;;; Copyright © 2016 Sou Bunnbu <iyzsong@gmail.com>
>> ;;;
>> ;;; This file is part of GNU Guix.
>> @@ -21,7 +21,9 @@
>> #:use-module ((guix licenses) #:prefix license:)
>> #:use-module (guix packages)
>> #:use-module (guix download)
>> + #:use-module (guix git-download)
>> #:use-module (guix build-system gnu)
>> + #:use-module (gnu packages assembly)
>> #:use-module (gnu packages m4))
>>
>> (define-public gforth
>> @@ -58,3 +60,42 @@ and history. A generic virtual machine environment, vmgen, is also
>> included.")
>> (home-page "https://www.gnu.org/software/gforth/")
>> (license license:gpl3+)))
>> +
>> +(define-public colorforth
>> + (let ((commit "b518ff966955f0b196e7bb8f85337284fa23e29e")
>> + (revision "1"))
>> + (package
>> + (name "colorforth")
>> + (version (string-append "0.0.0-" revision "." (string-take commit 7)))
>> + (source (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://github.com/narke/colorForth.git")
>> + (commit commit)))
>> + (sha256
>> + (base32
>> + "1q5szb9yi3nspbvnq0js6w24sb936ahjk828il760p0xpj5dsl45"))))
>> + (arguments
>> + `(#:tests? #f
>> + #:phases
>> + (modify-phases %standard-phases
>> + (delete "configure) ; No configure script
>> + (replace "install ; No install target
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (install-file "cf2012.img"
>> + (string-append (assoc-ref outputs "out")
>> + "/share/colorforth/"))
>> + #t)))))
>> + (native-inputs
>> + `(("nasm" ,nasm)))
>> + (build-system gnu-build-system)
>> + (home-page "https://github.com/narke/colorForth")
>> + (synopsis "Native 32-bit colorForth for PCs, Bochs and Qemu")
>> + (description
>> + "Colorforth is a @code{colorForth} implementation written in x86
>> +assembly. It is a dialect of Forth that uses color to replace punctation,
>> +includes its own operating system and produces extremely compact programs.
>> +Applications compile from pre-parsed source. Colorforth applications can be
>> +run using @code{Bochs} and @code{Qemu}. It is adapted from
>> +@url{http://sourceforge.net/projects/colorforth, colorforth}.")
>> + (license license:public-domain))))
>> --8<---------------cut here---------------end--------------->8---
>>
>>
>> --
>> Ricardo
>>
>> GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
>> https://elephly.net
>>
>>
>
> --
> ng0
> GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> GnuPG: https://n0is.noblogs.org/my-keys
> https://www.infotropique.org https://krosos.org

[-- Attachment #2: Type: text/html, Size: 8632 bytes --]

[bug#25728] [PATCH 2/2] gnu: Add colorforth.

[ng0]

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

Konstantin Tcholokachvili transcribed 18K bytes:
> Hi ng0,
> 
> I've been on holidays and I didn't checked my emails.
> Sadly, in fact there is a regression with qemu version 2.6 onwards, I filed a bug report to qemu team but they didn't investigated yet. For the moment the only solution is to:
> 1. Use older qemu ;
> 2. Usse Bochs.
> 
> This issue was reported here: https://github.com/narke/colorForth/issues/2
> 
> I'm also writing another implementation of colorForth in C but it's not finished yet.
> 
> Regards.
> 
> Sent with [ProtonMail](https://protonmail.com) Secure Email.

Hi Konstantin,

thanks for filing a bug with upstream.
I'll consider sending colorForth in C for QA when it's ready,
for now I agree with Ricardos action to close this report.

I had other things on my mind, thanks for your patience.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://dist.ng0.infotropique.org/dist/keys/
https://www.infotropique.org https://ng0.infotropique.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#25728: [PATCH 2/2] gnu: Add colorforth.

[ng0]

It seems like I re-opened this. Closing.
ng0 transcribed 2.0K bytes:
> Konstantin Tcholokachvili transcribed 18K bytes:
> > Hi ng0,
> > 
> > I've been on holidays and I didn't checked my emails.
> > Sadly, in fact there is a regression with qemu version 2.6 onwards, I filed a bug report to qemu team but they didn't investigated yet. For the moment the only solution is to:
> > 1. Use older qemu ;
> > 2. Usse Bochs.
> > 
> > This issue was reported here: https://github.com/narke/colorForth/issues/2
> > 
> > I'm also writing another implementation of colorForth in C but it's not finished yet.
> > 
> > Regards.
> > 
> > Sent with [ProtonMail](https://protonmail.com) Secure Email.
> 
> Hi Konstantin,
> 
> thanks for filing a bug with upstream.
> I'll consider sending colorForth in C for QA when it's ready,
> for now I agree with Ricardos action to close this report.
> 
> I had other things on my mind, thanks for your patience.
> -- 
> ng0
> GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> GnuPG: https://dist.ng0.infotropique.org/dist/keys/
> https://www.infotropique.org https://ng0.infotropique.org



-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://dist.ng0.infotropique.org/dist/keys/
https://www.infotropique.org https://ng0.infotropique.org