From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMXw6-00005H-6A for guix-patches@gnu.org; Sun, 18 Jun 2017 07:00:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMXw3-00020U-0V for guix-patches@gnu.org; Sun, 18 Jun 2017 07:00:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51331) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dMXw2-00020M-Td for guix-patches@gnu.org; Sun, 18 Jun 2017 07:00:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dMXw2-000394-Fo for guix-patches@gnu.org; Sun, 18 Jun 2017 07:00:02 -0400 Subject: [bug#25728] [PATCH 2/2] gnu: Add colorforth. Resent-Message-ID: References: <20170214185339.25538-1-contact.ng0@cryptolab.net> <20170214185339.25538-2-contact.ng0@cryptolab.net> <871suvu8yu.fsf@elephly.net> <20170415152843.2vyk7uhycuny5rov@abyayala> <20170415160053.qqqpga27hqsdhet3@abyayala> From: Ricardo Wurmus In-reply-to: <20170415160053.qqqpga27hqsdhet3@abyayala> Date: Sun, 18 Jun 2017 12:59:35 +0200 Message-ID: <87d1a17e94.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ng0 Cc: 25728@debbugs.gnu.org ng0 writes: > Version two of the patches attached. > -- […] >>>From 9c0221c7558b6d87124563fdc4fdde5c32a0374d Mon Sep 17 00:00:00 2001 > From: ng0 > Date: Thu, 6 Oct 2016 22:31:46 +0000 > Subject: [PATCH 2/2] gnu: Add colorforth. > > * gnu/packages/forth.scm (colorforth): New variable. > --- […] > + > +(define-public colorforth > + (let ((commit "94aec438f1ded202681f18801b98c52dc3beee41") > + (revision "1")) > + (package > + (name "colorforth") > + (version (string-append "0.0.0-" revision "." (string-take commit 7))) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/narke/colorForth") > + (commit commit))) > + (sha256 > + (base32 > + "0s602k568bm6vmvpahsms77liicg38vksn59j5m8ax4h9l9ca77r")))) > + (arguments > + `(#:tests? #f There should be a comment to explain why tests are disabled. > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) ;No configure script > + (replace 'install ;No install target > + (lambda* (#:key outputs #:allow-other-keys) > + (install-file "cf2012.img" > + (string-append (assoc-ref outputs "out") > + "/bin")) > + #t))))) If I understood this correctly, this is not an executable. One is supposed to run this with qemu. This means that it doesn’t belong in “bin”. > + (native-inputs > + `(("nasm" ,nasm))) > + (build-system gnu-build-system) > + (home-page "https://github.com/narke/colorForth") > + (synopsis "Native 32-bit colorForth for PCs, Bochs and Qemu") > + (description > + "Colorforth is a @code{colorForth} implementation written in > +x86 assembly. It is a dialect of Forth that uses color to replace > +punctation, includes its own operating system and produces extremely > +compact programs. Applications compile from pre-parsed source. > +Colorforth applications can be run using @code{Bochs} and @code{Qemu}. > +It is adapted from @url{http://sourceforge.net/projects/colorforth, > +colorforth}.") > + (license license:public-domain)))) I could not find a license statement anywhere in the repository. How do you know it’s public domain software? -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net