Heads-up: git.sv.gnu.org now rejects unsigned commits

Heads-up: git.sv.gnu.org now rejects unsigned commits

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

Hello!

All the Guix repositories on Savannah now reject unsigned Git commits:

  http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22883#112

Please report any problems.

In the future the hook will also check that commits are signed by
authorized keys, but the details need to be laid out.

Ludo’.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: Heads-up: git.sv.gnu.org now rejects unsigned commits

[Cyril Roelandt]

[-- Attachment #1.1: Type: text/plain, Size: 442 bytes --]

On 07/25/2016 10:59 AM, Ludovic Courtès wrote:
> Hello!
> 
> All the Guix repositories on Savannah now reject unsigned Git commits:
> 
>   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22883#112
> 

This could probably be useful:
https://git-scm.com/book/en/v2/Git-Tools-Signing-Your-Work


What will we do about patches sent by casual contributors, that will
probably be unsigned? Should the committer sign them?


Cyril.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Heads-up: git.sv.gnu.org now rejects unsigned commits

[Tobias Geerinckx-Rice]

Cyril,

On 2016-07-25 12:02, Cyril Roelandt wrote:
> What will we do about patches sent by casual contributors, that will
> probably be unsigned? Should the committer sign them?

Yes. (Most already do this, though.)

Kind regards,

T G-R
-- 
Sent from a web browser. Excuse my brevity.

Re: Heads-up: git.sv.gnu.org now rejects unsigned commits

[Leo Famulari]

On Mon, Jul 25, 2016 at 12:02:11PM +0200, Cyril Roelandt wrote:
> On 07/25/2016 10:59 AM, Ludovic Courtès wrote:
> > Hello!
> > 
> > All the Guix repositories on Savannah now reject unsigned Git commits:
> > 
> >   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22883#112
> > 
> 
> This could probably be useful:
> https://git-scm.com/book/en/v2/Git-Tools-Signing-Your-Work
> 
> 
> What will we do about patches sent by casual contributors, that will
> probably be unsigned? Should the committer sign them?

Yes. Signing a patch that is emailed is a separate action from signing a
Git commit (`git commit --gpg-sign`). Submitters are invited to sign
their emails, but those signatures will not appear in the Git repo.

Re: Heads-up: git.sv.gnu.org now rejects unsigned commits

[Andreas Enge]

On Mon, Jul 25, 2016 at 12:02:11PM +0200, Cyril Roelandt wrote:
> This could probably be useful:
> https://git-scm.com/book/en/v2/Git-Tools-Signing-Your-Work

Indeed, thanks a lot!

Andreas

Re: Heads-up: git.sv.gnu.org now rejects unsigned commits

[Leo Famulari]

On Mon, Jul 25, 2016 at 10:59:07AM +0200, Ludovic Courtès wrote:
> All the Guix repositories on Savannah now reject unsigned Git commits:
> 
>   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22883#112
> 
> Please report any problems.

Since the repo disables forced-pushing, we instead delete branches and
recreate them to get the same effect. We do this for WIP branches, and
perhaps some others?

If those branches contain unsigned commits (from before we decided to
sign everything), we won't be able to push them to Savannah. I ran into
this problem with my pre-push hook that prevents me from pushing
unsigned commits.

Just a heads up. I don't know whether or not it will be a problem in
practice.