Re: [PATCH 2/7] gnu: Add virglrenderer.

[Leo Famulari <leo@famulari.name>]

On Sat, Jul 23, 2016 at 03:18:54PM +0200, David Craven wrote:
> * gnu/packages/spice.scm: Add it.

> +(define-public virglrenderer

> +    (inputs
> +      `(("libepoxy" ,libepoxy)
> +        ("mesa" ,mesa)
> +        ("udev" ,eudev)))
> +    (native-inputs
> +      `(("pkg-config" ,pkg-config)))

I noticed the output has the following refernces:

$ guix gc --references $(./pre-inst-env guix build virglrenderer)
[...]
/gnu/store/35d9mmbdfk7fsgjwralbws88nm2d50qd-virglrenderer-0.5.0
/gnu/store/8m00x5x8ykmar27s9248cmhnkdb2n54a-glibc-2.22
/gnu/store/asr3mf4chdyadyqx8ml6jgvsa16s8j42-libepoxy-1.2
/gnu/store/lnrclizlj6kj5dag7f6fgc68nqybb941-mesa-11.0.9
/gnu/store/lp7dg7avv90rfdvis6hwbbwkxaqcx044-expat-2.1.0
/gnu/store/rhms73ac93maz7gxf8s00l9aj7ikwlx7-libdrm-2.4.65
/gnu/store/v39bh3ln3ncnzhyw0kd12d46kww9747v-gcc-4.9.3-lib

What do you think? Will it be a problem that virglrenderer will not know
how to find eudev?

And what about expat and libdrm? Should those be added to 'inputs',
since they are referred to by the virglrenderer shared library?

> +    (license license:expat)))

There is also some bsd-3 code.

And, it bundles something called Gallium, which is expat licensed. Do
you think this is something that should be packaged separately?