From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 2/7] gnu: Add virglrenderer.
Date: Sat, 23 Jul 2016 18:04:05 -0400
Message-ID: <20160723220405.GB26113@jasmine>
References: <20160723131859.13525-1-david@craven.ch>
	<20160723131859.13525-2-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55865)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bR51w-0007C7-Ha
	for guix-devel@gnu.org; Sat, 23 Jul 2016 18:04:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bR51s-0002kB-Av
	for guix-devel@gnu.org; Sat, 23 Jul 2016 18:04:19 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:57659)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bR51r-0002jk-46
	for guix-devel@gnu.org; Sat, 23 Jul 2016 18:04:16 -0400
Content-Disposition: inline
In-Reply-To: <20160723131859.13525-2-david@craven.ch>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

On Sat, Jul 23, 2016 at 03:18:54PM +0200, David Craven wrote:
> * gnu/packages/spice.scm: Add it.

> +(define-public virglrenderer

> +    (inputs
> +      `(("libepoxy" ,libepoxy)
> +        ("mesa" ,mesa)
> +        ("udev" ,eudev)))
> +    (native-inputs
> +      `(("pkg-config" ,pkg-config)))

I noticed the output has the following refernces:

$ guix gc --references $(./pre-inst-env guix build virglrenderer)
[...]
/gnu/store/35d9mmbdfk7fsgjwralbws88nm2d50qd-virglrenderer-0.5.0
/gnu/store/8m00x5x8ykmar27s9248cmhnkdb2n54a-glibc-2.22
/gnu/store/asr3mf4chdyadyqx8ml6jgvsa16s8j42-libepoxy-1.2
/gnu/store/lnrclizlj6kj5dag7f6fgc68nqybb941-mesa-11.0.9
/gnu/store/lp7dg7avv90rfdvis6hwbbwkxaqcx044-expat-2.1.0
/gnu/store/rhms73ac93maz7gxf8s00l9aj7ikwlx7-libdrm-2.4.65
/gnu/store/v39bh3ln3ncnzhyw0kd12d46kww9747v-gcc-4.9.3-lib

What do you think? Will it be a problem that virglrenderer will not know
how to find eudev?

And what about expat and libdrm? Should those be added to 'inputs',
since they are referred to by the virglrenderer shared library?

> +    (license license:expat)))

There is also some bsd-3 code.

And, it bundles something called Gallium, which is expat licensed. Do
you think this is something that should be packaged separately?