all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 5/7] gnu: Add spice.
Date: Sat, 23 Jul 2016 18:40:08 -0400	[thread overview]
Message-ID: <20160723224008.GE26113@jasmine> (raw)
In-Reply-To: <20160723131859.13525-5-david@craven.ch>

On Sat, Jul 23, 2016 at 03:18:57PM +0200, David Craven wrote:
> * gnu/packages/spice.scm: Add it.

> +(define-public spice

> +    (propagated-inputs
> +      `(("openssl" ,openssl)
> +        ("pixman" ,pixman)
> +        ("spice-protocol" ,spice-protocol)))

Same questions as with the previous patch. Do these need to be
propagated?

> +    (inputs
> +      `(("glib" ,glib)
> +        ("libjpeg" ,libjpeg)
> +        ("lz4" ,lz4)
> +        ("opus" ,opus)
> +        ("python" ,python)
> +        ("spice-gtk" ,spice-gtk)
> +        ("zlib" ,zlib)))

The built package is missing references to python and spice-gtk. Do you
think that's a problem? Are they needed?

> +      `(#:configure-flags
> +        '("--disable-celt051" 

Would a comment like "Disable support for unpackaged audio codec"
explain this flag?

> +    (license license:gpl2)))

Released under lgpl2.1+ with a few lgpl2.0+ files.

  reply	other threads:[~2016-07-23 22:40 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-23 13:18 [PATCH 1/7] gnu: Add usbredir David Craven
2016-07-23 13:18 ` [PATCH 2/7] gnu: Add virglrenderer David Craven
2016-07-23 22:04   ` Leo Famulari
2016-07-24 11:07     ` David Craven
2016-07-24 20:29       ` Leo Famulari
2016-07-23 13:18 ` [PATCH 3/7] gnu: Add spice-protocol David Craven
2016-07-23 22:06   ` Leo Famulari
2016-07-23 13:18 ` [PATCH 4/7] gnu: Add spice-gtk David Craven
2016-07-23 22:39   ` Leo Famulari
2016-07-24 11:12     ` David Craven
2016-07-24 11:34       ` David Craven
2016-07-24 16:21         ` Leo Famulari
2016-07-24 17:59           ` David Craven
2016-07-24 22:14         ` Ludovic Courtès
2016-07-25  7:55           ` David Craven
2016-07-27  9:31             ` David Craven
2016-07-27 22:12               ` Ludovic Courtès
2016-07-27 23:08                 ` Leo Famulari
2016-07-28 16:30                   ` David Craven
2016-07-28 16:59           ` Leo Famulari
2016-07-23 13:18 ` [PATCH 5/7] gnu: Add spice David Craven
2016-07-23 22:40   ` Leo Famulari [this message]
2016-07-24 11:19     ` David Craven
2016-07-23 13:18 ` [PATCH 6/7] gnu: Add spice-vdagent David Craven
2016-07-23 22:40   ` Leo Famulari
2016-07-24 11:20     ` David Craven
2016-07-23 13:18 ` [PATCH 7/7] gnu: Add virt-viewer David Craven
2016-07-23 22:40   ` Leo Famulari
2016-07-24 11:31     ` David Craven
2016-07-23 21:46 ` [PATCH 1/7] gnu: Add usbredir Leo Famulari
2016-07-24 17:52   ` David Craven
2016-07-24 17:52     ` [PATCH 2/7] gnu: Add virglrenderer David Craven
2016-07-28 21:09       ` Leo Famulari
2016-07-24 17:52     ` [PATCH 3/7] gnu: Add spice-protocol David Craven
2016-07-28 21:09       ` Leo Famulari
2016-07-24 17:52     ` [PATCH 4/7] gnu: Add spice-gtk David Craven
2016-07-28 21:09       ` Leo Famulari
2016-07-24 17:52     ` [PATCH 5/7] gnu: Add spice David Craven
2016-07-28 21:09       ` Leo Famulari
2016-07-24 17:52     ` [PATCH 6/7] gnu: Add spice-vdagent David Craven
2016-07-28 21:09       ` Leo Famulari
2016-07-24 17:52     ` [PATCH 7/7] gnu: Add virt-viewer David Craven
2016-07-28 21:09       ` Leo Famulari
2016-07-28 21:09     ` [PATCH 1/7] gnu: Add usbredir Leo Famulari
2016-07-29  8:09       ` David Craven
2016-07-29 15:16         ` Leo Famulari
2016-07-29 15:23           ` David Craven
2016-07-30 21:01             ` Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160723224008.GE26113@jasmine \
    --to=leo@famulari.name \
    --cc=david@craven.ch \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.