From: Arun Isaac <arunisaac@systemreboot.net>
To: nee <nee@cock.li>
Cc: 26488@debbugs.gnu.org
Subject: bug#26488: [PATCH] gnu: Add crawl.
Date: Fri, 14 Apr 2017 23:34:50 +0530 [thread overview]
Message-ID: <17796233.AEMAJMF3UlYAAAAAAAAAAAO02gcAAAACwQwAAAAAAAW9WABY8Q9P@mailjet.com> (raw)
In-Reply-To: <f0593d7a-2db6-fad7-99c9-3b180c55e068@cock.li>
>> Why do we need two URIs? Shouldn't the latest release alone be enough?
>> Isn't that the only release we need to build?
>>
> My thought is that this way the build won't break in the same moment a
> new version is released, since the referenced tar 404s when they move it.
Ok, that's fine, then.
>>>> + (arguments
>>>> + '(#:tests? #f
>>
>> The release tarball does seem to come with tests. Could you package them
>> as well?
>>
> Ah, I missed those because they are in make test and not make check.
> I tried to package them now, but the tests need to create a directory in
> home. This fails and I don't know how to handle this with guix.
> I need some help here.
Try (setenv "HOME" "/tmp") as Danny mentioned.
>> licence.txt mentions multiple licenses. Could you mention them all as a
>> list of licenses?
>>
> I did both now. I hope this is the right way.
Yes, the licenses are correct now.
> + (arguments
> + '(#:make-flags
> + (let* ((sqlite (assoc-ref %build-inputs "sqlite"))
> + (out (assoc-ref %outputs "out")))
> + (list (string-append "SQLITE_INCLUDE_DIR=" sqlite "/include")
> + (string-append "prefix=" out)
> + "SAVEDIR=~/.crawl"
> + "TILES="
> + "BUILD_LUA="
> + "BUILD_SQLITE="
> + "BUILD_ZLIB="
> + "-Csource"))
Only a matter of aesthetics, but you could split "-C" and "source" into
separate strings.
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure)
> + (replace
> + 'check
Put 'check on the same line as replace. In emacs, you can use
guix-devel-mode from emacs-guix to help you with indenting correctly.
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out")))
> + (and
> + (mkdir-p "~/.crawl/saves")
> + (zero? (system*
> + "make" "test"
> + (string-append "prefix=" out)
> + "TILES="
> + "BUILD_LUA="
> + "BUILD_SQLITE="
> + "BUILD_ZLIB="
> + "-Csource")))))))))
You can drop the `and' function call, and just make it individual calls
to `mkdir-p' and `zero?'
Looking good so far! Only the check phase remains...
next prev parent reply other threads:[~2017-04-14 18:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 21:26 bug#26488: [PATCH] gnu: Add crawl nee
[not found] ` <cu7shlbed1g.fsf@systemreboot.net>
2017-04-14 8:07 ` Arun Isaac
2017-04-14 16:10 ` nee
2017-04-14 17:23 ` Danny Milosavljevic
2017-04-14 18:04 ` Arun Isaac [this message]
[not found] ` <c09ea559.AEMAJMF3UlcAAAAAAAAAAAO0_XAAAAACwQwAAAAAAAW9WABY8Q9P@mailjet.com>
2017-04-17 4:46 ` nee
2017-04-17 18:37 ` Arun Isaac
2017-04-18 22:15 ` nee
2017-04-19 6:11 ` Arun Isaac
2017-04-21 17:10 ` Christopher Allan Webber
2017-04-21 20:25 ` Arun Isaac
2017-04-17 19:29 ` Arun Isaac
2017-04-17 21:29 ` nee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17796233.AEMAJMF3UlYAAAAAAAAAAAO02gcAAAACwQwAAAAAAAW9WABY8Q9P@mailjet.com \
--to=arunisaac@systemreboot.net \
--cc=26488@debbugs.gnu.org \
--cc=nee@cock.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.