From: Arun Isaac <arunisaac@systemreboot.net>
To: 26488@debbugs.gnu.org
Subject: bug#26488: [PATCH] gnu: Add crawl.
Date: Fri, 14 Apr 2017 13:37:01 +0530 [thread overview]
Message-ID: <791d5ba7.AEQAJP3OyzEAAAAAAAAAAAO02gcAAAACwQwAAAAAAAW9WABY8IM9@mailjet.com> (raw)
In-Reply-To: <cu7shlbed1g.fsf@systemreboot.net>
Thanks for the patch!
>> + (uri (list
>> + ;; Older releases get moved into a versioned directory
>> + (string-append "http://crawl.develz.org/release/"
>> + (version-major+minor version) "/stone_soup-"
>> + version "-nodeps.tar.xz")
>> + ;; Only the latest release is in this directory
>> + (string-append "http://crawl.develz.org/release/stone_soup-"
>> + version "-nodeps.tar.xz")))
Why do we need two URIs? Shouldn't the latest release alone be enough?
Isn't that the only release we need to build?
>> + (arguments
>> + '(#:tests? #f
The release tarball does seem to come with tests. Could you package them
as well?
>> + #:phases
>> + (modify-phases
>> + %standard-phases
Please put modify-phases and %standard-phases on the same line like:
(modify-phases %standard-phases
>> + (add-after
>> + 'unpack 'prepare-before-make
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (chdir "source")))
I haven't actually tried building the package, but is this phase
necessary? If you do want to change directory before running make, you
can pass "-C" and "source" as #:make-flags.
>> + (add-before
>> + 'configure 'patch-makefile
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (substitute*
>> + "Makefile"
>> + (("SQLITE_INCLUDE_DIR := /usr/include")
>> + "SQLITE_INCLUDE_DIR := ${sqlite}/include"))
>> + (substitute*
>> + "Makefile"
>> + (("/usr/share/fonts /usr/local/share/fonts /usr/*/lib/X11/fonts;")
>> + "${dejavu_fonts}/share/fonts;"))))
>> + (delete 'configure))))
You should be able to do this using #:make-flags. See
https://www.gnu.org/software/make/manual/html_node/Overriding.html
>> + (description "A roguelike adventure through dungeons filled with dangerous
>> +monsters in a quest to find the mystifyingly fabulous Orb of Zot.
>> +The game is also known under the name 'Dungeon Crawl Stone Soup'.")
Could you make this "Dungeon Crawl Stone Soup is a roguelike adventure
... "? Also, remove the last sentence "The game is also known as ...".
>> + (license license:gpl2+)))
licence.txt mentions multiple licenses. Could you mention them all as a
list of licenses?
next prev parent reply other threads:[~2017-04-14 8:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 21:26 bug#26488: [PATCH] gnu: Add crawl nee
[not found] ` <cu7shlbed1g.fsf@systemreboot.net>
2017-04-14 8:07 ` Arun Isaac [this message]
2017-04-14 16:10 ` nee
2017-04-14 17:23 ` Danny Milosavljevic
2017-04-14 18:04 ` Arun Isaac
[not found] ` <c09ea559.AEMAJMF3UlcAAAAAAAAAAAO0_XAAAAACwQwAAAAAAAW9WABY8Q9P@mailjet.com>
2017-04-17 4:46 ` nee
2017-04-17 18:37 ` Arun Isaac
2017-04-18 22:15 ` nee
2017-04-19 6:11 ` Arun Isaac
2017-04-21 17:10 ` Christopher Allan Webber
2017-04-21 20:25 ` Arun Isaac
2017-04-17 19:29 ` Arun Isaac
2017-04-17 21:29 ` nee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=791d5ba7.AEQAJP3OyzEAAAAAAAAAAAO02gcAAAACwQwAAAAAAAW9WABY8IM9@mailjet.com \
--to=arunisaac@systemreboot.net \
--cc=26488@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.