From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cz5bh-0002Eo-Bm for guix-patches@gnu.org; Fri, 14 Apr 2017 14:06:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cz5be-0006PT-7G for guix-patches@gnu.org; Fri, 14 Apr 2017 14:06:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49243) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cz5bd-0006PM-VK for guix-patches@gnu.org; Fri, 14 Apr 2017 14:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cz5bd-0002my-Kn for guix-patches@gnu.org; Fri, 14 Apr 2017 14:06:01 -0400 Subject: bug#26488: [PATCH] gnu: Add crawl. Resent-Message-ID: Message-Id: <17796233.AEMAJMF3UlYAAAAAAAAAAAO02gcAAAACwQwAAAAAAAW9WABY8Q9P@mailjet.com> MIME-Version: 1.0 From: Arun Isaac Date: Fri, 14 Apr 2017 23:34:50 +0530 In-reply-to: References: <9758282d-96a4-8fe4-183b-a60a43a9eab9@cock.li> <791d5ba7.AEQAJP3OyzEAAAAAAAAAAAO02gcAAAACwQwAAAAAAAW9WABY8IM9@mailjet.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: nee Cc: 26488@debbugs.gnu.org >> Why do we need two URIs? Shouldn't the latest release alone be enough? >> Isn't that the only release we need to build? >> > My thought is that this way the build won't break in the same moment a > new version is released, since the referenced tar 404s when they move it. Ok, that's fine, then. >>>> + (arguments >>>> + '(#:tests? #f >> >> The release tarball does seem to come with tests. Could you package them >> as well? >> > Ah, I missed those because they are in make test and not make check. > I tried to package them now, but the tests need to create a directory in > home. This fails and I don't know how to handle this with guix. > I need some help here. Try (setenv "HOME" "/tmp") as Danny mentioned. >> licence.txt mentions multiple licenses. Could you mention them all as a >> list of licenses? >> > I did both now. I hope this is the right way. Yes, the licenses are correct now. > + (arguments > + '(#:make-flags > + (let* ((sqlite (assoc-ref %build-inputs "sqlite")) > + (out (assoc-ref %outputs "out"))) > + (list (string-append "SQLITE_INCLUDE_DIR=3D" sqlite "/include") > + (string-append "prefix=3D" out) > + "SAVEDIR=3D~/.crawl" > + "TILES=3D" > + "BUILD_LUA=3D" > + "BUILD_SQLITE=3D" > + "BUILD_ZLIB=3D" > + "-Csource")) Only a matter of aesthetics, but you could split "-C" and "source" into separate strings. > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) > + (replace > + 'check Put 'check on the same line as replace. In emacs, you can use guix-devel-mode from emacs-guix to help you with indenting correctly. > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out"))) > + (and > + (mkdir-p "~/.crawl/saves") > + (zero? (system* > + "make" "test" > + (string-append "prefix=3D" out) > + "TILES=3D" > + "BUILD_LUA=3D" > + "BUILD_SQLITE=3D" > + "BUILD_ZLIB=3D" > + "-Csource"))))))))) You can drop the `and' function call, and just make it individual calls to `mkdir-p' and `zero?' Looking good so far! Only the check phase remains... =