From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id aHpzDswoY2XsJAEAauVa8A:P1 (envelope-from ) for ; Sun, 26 Nov 2023 12:15:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id aHpzDswoY2XsJAEAauVa8A (envelope-from ) for ; Sun, 26 Nov 2023 12:15:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CF45E1405A for ; Sun, 26 Nov 2023 12:15:23 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=landt.email header.s=MBO0001 header.b=U5LBIkwP; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=landt.email (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1700997324; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=XAn2LVxhRgX3Agq1Wm9pu+XR6yhVy1XLvMyQPH0ubjs=; b=i1a31q42Lgp7zgWLNF9uK+nwQSzjRERCCSjjQPkhqOtn9d2yn8OAzrJfKdaVnhtP5RMwMC 5r2ThaaRnX0gbUcqkcPjwbXxaTIgn5Ecc2v/0KwWMy3686htN1Ujg4c16OLKtBaLmJMTf2 DsRZwS4SaZx8N0BU8sH1EOWul+eOO9WwmqfJMVqtnkP6PLtsGbh/eaa76sDFTQ4YlzoEMk ijkHEEvsO5hhWbo8cTMHrJ4pGHrrfrmZLcbZpD4vzOlG4GHEBNANR3YbIl5rTyqTXmVzKL DuWt6sAROXseZXrwSzvTUpG+kXX22jDeEW1HfpbsPVrdAbxhqtRKoYYcmcoLLA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=landt.email header.s=MBO0001 header.b=U5LBIkwP; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=landt.email (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1700997324; a=rsa-sha256; cv=none; b=HLfQFKXiQsrQFZ038d5565hYF3C6yc32rzRDS0Pr/8/nhXmjUowMBqVtlCgd8eorB7wSeH YW4Z5Owkj8j2ENnrumjz5x0zhBECj1N7b1Wt3Bs7cPb9R+c00Ry+p+lpmDMWPsbdYg3yjQ uc6ASRy51Ly9xbnTlz+azksJmoz9E9PcW5mBuWORBlX7ZdqKzIFWrONmEzoLDbFd/ZkHc/ i1qOcWVFAw87hZ4BiaJ7sS9tYNQIXN711DHwo0lNjIr7G8nNCENjR0qqaG2OyXz1hThm1s x4eJW1ukvN9r5WVkoovTVlTyM5/M8T3tfkYGKSj+lFaCvjDdX9ExkD1lhKkILA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r7D6J-0006PE-UM; Sun, 26 Nov 2023 06:14:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7D6G-0006P3-PN for guix-patches@gnu.org; Sun, 26 Nov 2023 06:14:56 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r7D6G-0004Rt-Gp for guix-patches@gnu.org; Sun, 26 Nov 2023 06:14:56 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r7D6L-0008HM-ON for guix-patches@gnu.org; Sun, 26 Nov 2023 06:15:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#66557] [PATCH] home: services: Add goimapnotify service. References: In-Reply-To: Resent-From: Nils Landt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Nov 2023 11:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66557 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "66557@debbugs.gnu.org" <66557@debbugs.gnu.org> Cc: "rekado@elephly.net" , "mirai@makinata.eu" Received: via spool by 66557-submit@debbugs.gnu.org id=B66557.170099727831773 (code B ref 66557); Sun, 26 Nov 2023 11:15:01 +0000 Received: (at 66557) by debbugs.gnu.org; 26 Nov 2023 11:14:38 +0000 Received: from localhost ([127.0.0.1]:40785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7D5y-0008GO-1B for submit@debbugs.gnu.org; Sun, 26 Nov 2023 06:14:38 -0500 Received: from mout-p-101.mailbox.org ([80.241.56.151]:37422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7D5v-0008G8-7u for 66557@debbugs.gnu.org; Sun, 26 Nov 2023 06:14:36 -0500 Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4SdR1n5dsWz9sQr; Sun, 26 Nov 2023 12:14:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=landt.email; s=MBO0001; t=1700997261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XAn2LVxhRgX3Agq1Wm9pu+XR6yhVy1XLvMyQPH0ubjs=; b=U5LBIkwPFC4NC8tqehv+xvY2LewUaB82LMkZoCDVQbNdyU1LmC/iv0q+dtkl1bkGYZXd8B oVYhwudUx4smEbI8wzGSNU9+vFmh9SLc4hFW+8xJ77h2zfNA1vLkuIM+6nIdVj3HSVhKDI fwC1P3M8FfwXam3WZylRlZOidloobR6JdNcV14aJPPuEdFqcRec/5r6i1s+fs+1Q7PKxaX CvzUelUZvsSh9IlD8OyTm6GfbqNAs4iIs5HUfzHPuA1hO5cD2RFk0pSXQwbLWqmlFxgf7a hShYwff6LS3o+Y1DbtKiedton1quZbs3EhZ24nkVmGcnHb0Nf7gPWod2tz0ZRg== Date: Sun, 26 Nov 2023 12:14:20 +0100 (CET) From: Nils Landt Message-ID: <1635724009.68147.1700997260830@office.mailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: CF45E1405A X-Spam-Score: -4.53 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -4.53 X-TUID: 6ysK5ifziEpF Hello, I have pushed a new version. Compared to the version you reviewed, I made the following changes: - docs: Stdin -> stdin - docs: use file-append for "pass" example - docs: re-add trailing whitespace - rework filter + map to use fold instead - update link to upstream config documentation from master to current commi= t - ignore first element in list-of-goimapnotify-accounts? - add question mark suffix to boolean fields (e.g. tls -> tls?) - fix "on-new-mail" option in docstring - remove parentheses around configuration field types Lastly, some comments on review requests I was unable to implement. Ricardo: > So I think it would be better to let these fields accept command lists. > FILE-APPEND should only join the package value with the file name of the > executable, but not include any arguments. I did not understand what this meant. Do you have any examples? I implement= ed your second suggestion of using file-append for pass instead. > Could this be (cons (goimapnotify-format-field field-name) value) > instead? I don=E2=80=99t think we need this wrapping and unwrapping with= G-exp > syntax. This results in e.g. ("boxes" . #("INBOX")) , leading to a syntax error in = the generated guile script. I'm open to suggestions here. Bruno: > This isn't needed, fields whose maybe-values are unset don't call the > serializing procedures. combined with > You can use 'serialize-configuration' instead which accounts for the unse= t maybe-values. I put some time into this, but I don't see how serialize-configuration, whi= ch returns a gexp including string-append, could be used to turn a configur= ation record into the format required by guile-json.