* [bug#54328] [PATCH] Add emacs-org-remark-1.0.3
@ 2022-03-10 10:45 Алексей Дроздов
2022-03-10 17:28 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Алексей Дроздов @ 2022-03-10 10:45 UTC (permalink / raw)
To: 54328
[-- Attachment #1: Type: text/html, Size: 2528 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [bug#54328] [PATCH] Add emacs-org-remark-1.0.3
2022-03-10 10:45 [bug#54328] [PATCH] Add emacs-org-remark-1.0.3 Алексей Дроздов
@ 2022-03-10 17:28 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2022-03-10 17:28 UTC (permalink / raw)
To: Алексей Дроздов
Cc: 54328
Hello,
Алексей Дроздов <drozdov@portalenergy.tech> writes:
> Subject: [PATCH] Add emacs-org-remark-1.0.3
Thanks. Some comments follow.
First, our commit messages are somewhat normalized, so this should be:
gnu: Add emacs-org-remark.
* gnu/packages/emacs-xyz.scm (emacs-org-remark): New variable.
Note the message doesn't contain the version, but specify the exact name
of the variable being added.
> +(define-public emacs-org-remark
> + (let ((commit "b2e632cf66c748951910bc493915759ee8a9c22c")
> + (revision "0"))
You don't need to specify a revision since this pair matches an
un-tagged version bump.
> + (package
> + (name "emacs-org-remark")
> + (version (git-version "1.0.3" revision commit))
Per above, this should be plain "1.0.3".
> + (description "@code{emacs-org-remark} lets you highlight and annotate any text file with using Org mode.")
I think the name is Org-remark, not emacs-org-remark, which is the name
of the Guix variable.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-10 17:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-10 10:45 [bug#54328] [PATCH] Add emacs-org-remark-1.0.3 Алексей Дроздов
2022-03-10 17:28 ` Nicolas Goaziou
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.