From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Алексей Дроздов" <drozdov@portalenergy.tech>
Cc: 54328@debbugs.gnu.org
Subject: [bug#54328] [PATCH] Add emacs-org-remark-1.0.3
Date: Thu, 10 Mar 2022 18:28:46 +0100 [thread overview]
Message-ID: <87tuc567jl.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <1159731646908990@mail.yandex.ru> ("Алексей Дроздов"'s message of "Thu, 10 Mar 2022 13:45:25 +0300")
Hello,
Алексей Дроздов <drozdov@portalenergy.tech> writes:
> Subject: [PATCH] Add emacs-org-remark-1.0.3
Thanks. Some comments follow.
First, our commit messages are somewhat normalized, so this should be:
gnu: Add emacs-org-remark.
* gnu/packages/emacs-xyz.scm (emacs-org-remark): New variable.
Note the message doesn't contain the version, but specify the exact name
of the variable being added.
> +(define-public emacs-org-remark
> + (let ((commit "b2e632cf66c748951910bc493915759ee8a9c22c")
> + (revision "0"))
You don't need to specify a revision since this pair matches an
un-tagged version bump.
> + (package
> + (name "emacs-org-remark")
> + (version (git-version "1.0.3" revision commit))
Per above, this should be plain "1.0.3".
> + (description "@code{emacs-org-remark} lets you highlight and annotate any text file with using Org mode.")
I think the name is Org-remark, not emacs-org-remark, which is the name
of the Guix variable.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2022-03-10 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 10:45 [bug#54328] [PATCH] Add emacs-org-remark-1.0.3 Алексей Дроздов
2022-03-10 17:28 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuc567jl.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=54328@debbugs.gnu.org \
--cc=drozdov@portalenergy.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.