[bug#56884] [PATCH] Make x265 build on ppc64le

[bug#56884] [PATCH] Make x265 build on ppc64le

[Marcel van der Boom]

* gnu/packages/video.scm: disable ALTIVEC for target-ppc64le
---
 gnu/packages/video.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 04049fd9c8..09f8b7fd23 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1252,6 +1252,9 @@ (define-public x265
                  ,@(if (target-aarch64?)
                      '("-DENABLE_ASSEMBLY=OFF")
                      '())
+                 ,@(if (target-ppc64le?)
+                     '("-DENABLE_ALTIVEC=OFF")
+                     '())
                  "-DHIGH_BIT_DEPTH=ON"
                  "-DEXPORT_C_API=OFF"
                  "-DENABLE_CLI=OFF"
@@ -1272,6 +1275,9 @@ (define-public x265
                  ,@(if (target-aarch64?)
                      '("-DENABLE_ASSEMBLY=OFF")
                      '())
+                 ,@(if (target-ppc64le?)
+                     '("-DENABLE_ALTIVEC=OFF")
+                     '())
                  "-DHIGH_BIT_DEPTH=ON"
                  "-DEXPORT_C_API=OFF"
                  "-DENABLE_CLI=OFF"

base-commit: a1f7d98a9c7380be5815fd13b519bbab145757c2
-- 
2.37.1

[bug#56884] [PATCH] Make x265 build on ppc64le

[Marcel van der Boom]

Anything else needed here?

The patch seems consistent with other packagers I think. Others 
are also confused on what is needed for the altivec code between 
different POWER processors.

[bug#56884] [PATCH] Make x265 build on ppc64le

[Thiago Jung Bauermann via Guix-patches via]

Hello Marcel,

Marcel van der Boom <marcel@van-der-boom.nl> writes:

> Anything else needed here?
>
> The patch seems consistent with other packagers I think.

Thank you for the patch! It looks good to me. I only have one
suggestion: IMHO it would be a good idea to have a short comment above
the “(if (target-ppc64le?) …)” line explaining why it's needed, such as
“Enabling AltiVec support causes compilation errors.” or something
similar.

Ideally upstream should be notified about this problem so that they are
aware of it, but looking at the x265 website I can't find any bug
tracker.

> Others are also confused on what is needed for the altivec code
> between different POWER processors.

Sorry, I'm not sure what you mean.

PS: Just for the sake of documenting in the issue tracker why x265 isn't
building on ppc64le — the build fails because of many errors such as:

/tmp/guix-build-x265-3.5.drv-0/x265_3.5/source/common/ppc/pixel_altivec.cpp:4199:42: error: no matches converting function ‘sad16_altivec’ to type ‘x265_12bit::pixelcmp_t’ {aka ‘int (*)(const short unsigned int*, long int, const short unsigned int*, long int)’}
 4199 |         p.pu[LUMA_ ## W ## x ## H].sad = sad16_altivec<W, H>; \
      |                                          ^~~~~~~~~~~~~~~~~~~

-- 
Thanks
Thiago

[bug#56884] [PATCH] Make x265 build on ppc64le

[Marcel van der Boom]

* gnu/packages/video.scm: disable ALTIVEC for target-ppc64le

  Build produces many errors. The altivec code needs adjusting each type of
  POWER processor specifically.
---
 gnu/packages/video.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 04049fd9c8..bf033c7d84 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1252,6 +1252,10 @@ (define-public x265
                  ,@(if (target-aarch64?)
                      '("-DENABLE_ASSEMBLY=OFF")
                      '())
+                 ;; Altivec code produces many build errors
+                 ,@(if (target-ppc64le?)
+                     '("-DENABLE_ALTIVEC=OFF")
+                     '())
                  "-DHIGH_BIT_DEPTH=ON"
                  "-DEXPORT_C_API=OFF"
                  "-DENABLE_CLI=OFF"
@@ -1272,6 +1276,10 @@ (define-public x265
                  ,@(if (target-aarch64?)
                      '("-DENABLE_ASSEMBLY=OFF")
                      '())
+                 ;; Altivec code produces many build errors
+                 ,@(if (target-ppc64le?)
+                     '("-DENABLE_ALTIVEC=OFF")
+                     '())
                  "-DHIGH_BIT_DEPTH=ON"
                  "-DEXPORT_C_API=OFF"
                  "-DENABLE_CLI=OFF"
-- 
2.37.1

[bug#56884] [PATCH] Make x265 build on ppc64le

[Thiago Jung Bauermann via Guix-patches via]

user guix
usertag 56884 reviewed looks-good
quit

Hello Marcel,

Marcel van der Boom <marcel@van-der-boom.nl> writes:

> * gnu/packages/video.scm: disable ALTIVEC for target-ppc64le
>
>   Build produces many errors. The altivec code needs adjusting each type of
>   POWER processor specifically.

Thank you for the new version. This one looks good to me.

I'm not a maintainer though, so we need to wait for one to chime in.

-- 
Thanks
Thiago

bug#56884: [PATCH] Make x265 build on ppc64le

[Mathieu Othacehe]

Hello,

Thanks for reviewing Thiago. I fixed the indentation and edited the
commit message before pushing.

Mathieu

[bug#56884] [PATCH] Make x265 build on ppc64le

[Thiago Jung Bauermann via Guix-patches via]

Hello Mathieu,

Mathieu Othacehe <othacehe@gnu.org> writes:

> Thanks for reviewing Thiago. I fixed the indentation and edited the
> commit message before pushing.

Thank you!

-- 
Thanks
Thiago