From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yCanIyIa82JheAAAbAwnHQ (envelope-from ) for ; Wed, 10 Aug 2022 04:38:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WDBjIyIa82IWPAEAauVa8A (envelope-from ) for ; Wed, 10 Aug 2022 04:38:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3733B124B for ; Wed, 10 Aug 2022 04:38:26 +0200 (CEST) Received: from localhost ([::1]:34806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLbc1-0001Oa-9g for larch@yhetil.org; Tue, 09 Aug 2022 22:38:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLbbf-0001OB-5M for guix-patches@gnu.org; Tue, 09 Aug 2022 22:38:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55878) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLbbe-0002Qo-Og for guix-patches@gnu.org; Tue, 09 Aug 2022 22:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLbbe-0002Ub-9s for guix-patches@gnu.org; Tue, 09 Aug 2022 22:38:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56884] [PATCH] Make x265 build on ppc64le Resent-From: Thiago Jung Bauermann Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 Aug 2022 02:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56884 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marcel van der Boom Cc: 56884@debbugs.gnu.org Received: via spool by 56884-submit@debbugs.gnu.org id=B56884.16600990489518 (code B ref 56884); Wed, 10 Aug 2022 02:38:02 +0000 Received: (at 56884) by debbugs.gnu.org; 10 Aug 2022 02:37:28 +0000 Received: from localhost ([127.0.0.1]:45621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLbb5-0002TS-R1 for submit@debbugs.gnu.org; Tue, 09 Aug 2022 22:37:28 -0400 Received: from mx.kolabnow.com ([212.103.80.155]:35762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLbb0-0002TB-Rg for 56884@debbugs.gnu.org; Tue, 09 Aug 2022 22:37:26 -0400 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 96C474293; Wed, 10 Aug 2022 04:37:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:in-reply-to:date:date:subject:subject:from:from :references:received:received:received; s=dkim20160331; t= 1660099036; x=1661913437; bh=fh05oEFzottzmGKPS+dGidZe0kZVAjgSCbA hOaoCMhI=; b=aEtOkdPQ1JC69ZF8raVPYc64vSNMocjNkRS/ArCtTQ6J8mc+rWC bMeMHdcG1HLSqSDH05NXVQYbqsuVhiwQxvCBNpQKq9wGQqG1v8Y8slBvLi1oft6S EbHK8XIWrqgkDUmZ7mLqI7s8U+GF1jps53YUv2ZXCW2f9tVoo1CbJw1TNbFHiO0I wtq3ob1Rjvbk1/xNbcJQtoivqY+pMPHtGbc4B9tqt7fmlPuEGQMA1TcyQGdySVRu v30Wj4dB/O5MstQjxjhAupjrbtYEzVjBMDdzhVZpkOOIzdM+M/BMUrqN7omPZedz nMN55eIaPWmfHVyPUf730KZThsWOmiaVqRntW3T25bYNQPv1+NhzpJgQxonJqgSo Veyl/mrkGJ4Zu6B6CHhy5c8DA46PW09/z3xjmFJeytDRP4LD6aOA/s4WHTi5D1Uu vi1MW+HgDMPD1i9h6uf2ionotgs7o6Jl+/dYY+YgrQw8ORT4w1fmPE7Plv0r0scy Qf+Y/yRTzP4vrlIk2YHWtihW6+4PzcqC/xIz7KwjcYrVINC3AMegK9qPuL9qREiP l0TGWJLti9Aj8d8oKJBbt45gvBCXVKn/iRm/4yW9difiu6FP+hl7E9w1kgL8U5Y7 nEzvreCQgi5jC/K1MpzvdJvj3W3Ho2hXOLhCcWS4i9lS5cHZwnno5tE4= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6WRR7EZkJCin; Wed, 10 Aug 2022 04:37:16 +0200 (CEST) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by mx.kolabnow.com (Postfix) with ESMTPS id 811CA4291; Wed, 10 Aug 2022 04:37:15 +0200 (CEST) Received: from ext-subm003.mykolab.com (unknown [10.9.6.3]) by int-mx001.mykolab.com (Postfix) with ESMTPS id 3F304806; Wed, 10 Aug 2022 04:37:15 +0200 (CEST) References: <87wnbhder7.fsf@van-der-boom.nl> Date: Tue, 09 Aug 2022 23:16:35 -0300 In-reply-to: <87wnbhder7.fsf@van-der-boom.nl> Message-ID: <87r11oddt9.fsf@kolabnow.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Thiago Jung Bauermann X-ACL-Warn: , Thiago Jung Bauermann via Guix-patches From: Thiago Jung Bauermann via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660099106; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=fh05oEFzottzmGKPS+dGidZe0kZVAjgSCbAhOaoCMhI=; b=Y3CFM00l4thYIWw8Lrx8xBRbTaICvZqZXc2/tYu924Ki0iDIZqnGvnU2kHxhLTAYSg9Ql+ qjpYE/MqAAKpKopk6ycvVlhl+WrwoKALJxsBL8zX1s4hOSPAFpl8DZQW2PHZK9rrahkNet dp3EcnF6om86+MihbotYmjChze2RJoybqFytP+SBglvCjSzFXdIogj0+S3mHh0UhQg5F2o DEl4Rq+nyY/YRI6+SdwhWM+oIWV5Suw1oVDZS5NMNjU91gi3klny7RU0erSQ8H+bdYsx1O w1VTXdBtevEGjsqT5WkaC+g1IGpW5jFxKUbL9PwCTuNaDCpjmJaoQmfi/fzJNg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660099106; a=rsa-sha256; cv=none; b=jzhnNqt/oKAaK3QyXqSpvtk1xnUQLpnYRy1Z8wj5Bt3PsJWMciyK7gPUN/yKMWVPacnJfF FV92FAiRdjRAOqXaL7u/YYEPMtgj83z2GJWmtZahiqULHCQDslelWYVCTAW4KAdtxqeCCw gimT00CJHGlIzc7U1B2nwx8CH2sn7+vtDU+3aJwDYeUZ/XX+WwqUU2e4G9uE5vNomVFryu ZXZtRvrEo0CtmRI2WjylTV87mH/+xJuQxKOCdKVILQEUuXSTjlaD9zRreDRSDJCOdj6X/t HAMEoJq7jE3BXAk6rbebPotD6yX172+TxqqXdTT53MKWtb6IYL8JWDoni3BisQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=aEtOkdPQ; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.99 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=aEtOkdPQ; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3733B124B X-Spam-Score: -4.99 X-Migadu-Scanner: scn0.migadu.com X-TUID: 63vLP8Tk0Xow Hello Marcel, Marcel van der Boom writes: > Anything else needed here? > > The patch seems consistent with other packagers I think. Thank you for the patch! It looks good to me. I only have one suggestion: IMHO it would be a good idea to have a short comment above the =E2=80=9C(if (target-ppc64le?) =E2=80=A6)=E2=80=9D line explaining why = it's needed, such as =E2=80=9CEnabling AltiVec support causes compilation errors.=E2=80=9D or so= mething similar. Ideally upstream should be notified about this problem so that they are aware of it, but looking at the x265 website I can't find any bug tracker. > Others are also confused on what is needed for the altivec code > between different POWER processors. Sorry, I'm not sure what you mean. PS: Just for the sake of documenting in the issue tracker why x265 isn't building on ppc64le =E2=80=94 the build fails because of many errors such a= s: /tmp/guix-build-x265-3.5.drv-0/x265_3.5/source/common/ppc/pixel_altivec.cpp= :4199:42: error: no matches converting function =E2=80=98sad16_altivec=E2= =80=99 to type =E2=80=98x265_12bit::pixelcmp_t=E2=80=99 {aka =E2=80=98int (= *)(const short unsigned int*, long int, const short unsigned int*, long int= )=E2=80=99} 4199 | p.pu[LUMA_ ## W ## x ## H].sad =3D sad16_altivec; \ | ^~~~~~~~~~~~~~~~~~~ --=20 Thanks Thiago