* [bug#41510] [PATCH] guix: print: Update deprecated method
@ 2020-05-24 16:41 Ekaitz Zarraga
2020-05-30 14:17 ` Ludovic Courtès
2020-12-07 11:40 ` bug#41510: " Ludovic Courtès
0 siblings, 2 replies; 4+ messages in thread
From: Ekaitz Zarraga @ 2020-05-24 16:41 UTC (permalink / raw)
To: 41510
Hi,
This patch corrects the following warning:
guix/import/print.scm:77:21: warning: 'origin-sha256' is deprecated, use 'origin-hash' instead
Best,
Ekaitz
From ac21251092570bd426505f98d4415781e7c66147 Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz@elenq.tech>
Date: Sun, 24 May 2020 18:36:59 +0200
Subject: [PATCH] guix: print: Update deprecated method
* guix/import/print.scm (source->code): Replace origin-sha256 with
origin-hash
---
guix/import/print.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guix/import/print.scm b/guix/import/print.scm
index 11cc218285..afbb680607 100644
--- a/guix/import/print.scm
+++ b/guix/import/print.scm
@@ -74,7 +74,7 @@ when evaluated."
(define (source->code source version)
(let ((uri (origin-uri source))
(method (origin-method source))
- (sha256 (origin-sha256 source))
+ (sha256 (origin-hash source))
(file-name (origin-file-name source))
(patches (origin-patches source)))
`(origin
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [bug#41510] [PATCH] guix: print: Update deprecated method
2020-05-24 16:41 [bug#41510] [PATCH] guix: print: Update deprecated method Ekaitz Zarraga
@ 2020-05-30 14:17 ` Ludovic Courtès
2020-05-30 14:20 ` Ekaitz Zarraga
2020-12-07 11:40 ` bug#41510: " Ludovic Courtès
1 sibling, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2020-05-30 14:17 UTC (permalink / raw)
To: Ekaitz Zarraga; +Cc: 41510
Hi,
Ekaitz Zarraga <ekaitz@elenq.tech> skribis:
> guix/import/print.scm:77:21: warning: 'origin-sha256' is deprecated, use 'origin-hash' instead
[...]
> - (sha256 (origin-sha256 source))
> + (sha256 (origin-hash source))
This is quite correct (contrary to what the warning suggests). You also
have to use ‘content-hash-value’. The code also needs to check whether
it’s actually sha256 or some other algorithm.
Make sure to run:
make check TESTS=tests/print.scm
afterwards!
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#41510] [PATCH] guix: print: Update deprecated method
2020-05-30 14:17 ` Ludovic Courtès
@ 2020-05-30 14:20 ` Ekaitz Zarraga
0 siblings, 0 replies; 4+ messages in thread
From: Ekaitz Zarraga @ 2020-05-30 14:20 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 41510@debbugs.gnu.org
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Saturday, May 30, 2020 4:17 PM, Ludovic Courtès <ludo@gnu.org> wrote:
> Hi,
>
> Ekaitz Zarraga ekaitz@elenq.tech skribis:
>
> > guix/import/print.scm:77:21: warning: 'origin-sha256' is deprecated, use 'origin-hash' instead
>
> [...]
>
> > - (sha256 (origin-sha256 source))
> >
> >
> >
> > - (sha256 (origin-hash source))
> >
> >
>
> This is quite correct (contrary to what the warning suggests). You also
> have to use ‘content-hash-value’. The code also needs to check whether
> it’s actually sha256 or some other algorithm.
>
> Make sure to run:
>
> make check TESTS=tests/print.scm
>
> afterwards!
>
> Thanks,
> Ludo’.
LOL
Time to fix the warning then? ;)
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#41510: [PATCH] guix: print: Update deprecated method
2020-05-24 16:41 [bug#41510] [PATCH] guix: print: Update deprecated method Ekaitz Zarraga
2020-05-30 14:17 ` Ludovic Courtès
@ 2020-12-07 11:40 ` Ludovic Courtès
1 sibling, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2020-12-07 11:40 UTC (permalink / raw)
To: Ekaitz Zarraga; +Cc: 41510-done
Hi,
Ekaitz Zarraga <ekaitz@elenq.tech> skribis:
> This patch corrects the following warning:
>
> guix/import/print.scm:77:21: warning: 'origin-sha256' is deprecated, use 'origin-hash' instead
This was fixed in a9105c2c4c97ffbdb1b09dadc14773566924ab59.
Closing!
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-07 12:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-24 16:41 [bug#41510] [PATCH] guix: print: Update deprecated method Ekaitz Zarraga
2020-05-30 14:17 ` Ludovic Courtès
2020-05-30 14:20 ` Ekaitz Zarraga
2020-12-07 11:40 ` bug#41510: " Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).