From: Ekaitz Zarraga <ekaitz@elenq.tech>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: "41510@debbugs.gnu.org" <41510@debbugs.gnu.org>
Subject: [bug#41510] [PATCH] guix: print: Update deprecated method
Date: Sat, 30 May 2020 14:20:30 +0000 [thread overview]
Message-ID: <L8urT0ZiySdxrZ0C-Akgm8Smcy_BZhzqzq9x0HD21ZChb-BPOl5nVGY6LbK_0jcOtL0BgoasBWjIgEqRHzucrHaN2RxhNX2E4qR8GiFf5kc=@elenq.tech> (raw)
In-Reply-To: <87eer1tskr.fsf@gnu.org>
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Saturday, May 30, 2020 4:17 PM, Ludovic Courtès <ludo@gnu.org> wrote:
> Hi,
>
> Ekaitz Zarraga ekaitz@elenq.tech skribis:
>
> > guix/import/print.scm:77:21: warning: 'origin-sha256' is deprecated, use 'origin-hash' instead
>
> [...]
>
> > - (sha256 (origin-sha256 source))
> >
> >
> >
> > - (sha256 (origin-hash source))
> >
> >
>
> This is quite correct (contrary to what the warning suggests). You also
> have to use ‘content-hash-value’. The code also needs to check whether
> it’s actually sha256 or some other algorithm.
>
> Make sure to run:
>
> make check TESTS=tests/print.scm
>
> afterwards!
>
> Thanks,
> Ludo’.
LOL
Time to fix the warning then? ;)
next prev parent reply other threads:[~2020-05-30 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 16:41 [bug#41510] [PATCH] guix: print: Update deprecated method Ekaitz Zarraga
2020-05-30 14:17 ` Ludovic Courtès
2020-05-30 14:20 ` Ekaitz Zarraga [this message]
2020-12-07 11:40 ` bug#41510: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='L8urT0ZiySdxrZ0C-Akgm8Smcy_BZhzqzq9x0HD21ZChb-BPOl5nVGY6LbK_0jcOtL0BgoasBWjIgEqRHzucrHaN2RxhNX2E4qR8GiFf5kc=@elenq.tech' \
--to=ekaitz@elenq.tech \
--cc=41510@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).