From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wBXhG9Rr0l6eOQAA0tVLHw (envelope-from ) for ; Sat, 30 May 2020 14:21:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 2M8DGNRr0l4+ZwAAB5/wlQ (envelope-from ) for ; Sat, 30 May 2020 14:21:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E2B659401AE for ; Sat, 30 May 2020 14:21:07 +0000 (UTC) Received: from localhost ([::1]:37036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jf2ME-00080G-UB for larch@yhetil.org; Sat, 30 May 2020 10:21:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jf2MA-000805-HM for guix-patches@gnu.org; Sat, 30 May 2020 10:21:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47298) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jf2MA-0007c3-8C for guix-patches@gnu.org; Sat, 30 May 2020 10:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jf2MA-00034P-4z for guix-patches@gnu.org; Sat, 30 May 2020 10:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41510] [PATCH] guix: print: Update deprecated method Resent-From: Ekaitz Zarraga Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 30 May 2020 14:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41510 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: "41510@debbugs.gnu.org" <41510@debbugs.gnu.org> Received: via spool by 41510-submit@debbugs.gnu.org id=B41510.159084845811771 (code B ref 41510); Sat, 30 May 2020 14:21:02 +0000 Received: (at 41510) by debbugs.gnu.org; 30 May 2020 14:20:58 +0000 Received: from localhost ([127.0.0.1]:58844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf2Lv-00033W-1F for submit@debbugs.gnu.org; Sat, 30 May 2020 10:20:57 -0400 Received: from mail1.protonmail.ch ([185.70.40.18]:32651) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf2Lt-00033K-Cf for 41510@debbugs.gnu.org; Sat, 30 May 2020 10:20:45 -0400 Date: Sat, 30 May 2020 14:20:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=protonmail; t=1590848439; bh=QnCrtHhSENf7urO+ut0XKjCT8digGLsczoXtf6AhmmQ=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=RZtkTQ1LMKTBokaI6vDW7EEWw+mWUGprS29HESzggK3XvCz95GZt1TpJ1ODaWWeXi Vzv1+F/bm6BJFi4ESVJFfO2GzwOYA13wRfEANLaWDPUxiKeHNXgyj4ZzsNGaud/HII jY1kqotTLKJbWbj1PooiDYcQO1ScrrF/hZSSildQ= From: Ekaitz Zarraga Message-ID: In-Reply-To: <87eer1tskr.fsf@gnu.org> References: <87eer1tskr.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Ekaitz Zarraga Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=elenq.tech header.s=protonmail header.b=RZtkTQ1L; dmarc=fail reason="SPF not aligned (relaxed)" header.from=elenq.tech (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: bgiJIUw5jjt8 =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Saturday, May 30, 2020 4:17 PM, Ludovic Court=C3=A8s wrot= e: > Hi, > > Ekaitz Zarraga ekaitz@elenq.tech skribis: > > > guix/import/print.scm:77:21: warning: 'origin-sha256' is deprecated, us= e 'origin-hash' instead > > [...] > > > - (sha256 (origin-sha256 source)) > > > > > > > > - (sha256 (origin-hash source)) > > > > > > This is quite correct (contrary to what the warning suggests). You also > have to use =E2=80=98content-hash-value=E2=80=99. The code also needs to = check whether > it=E2=80=99s actually sha256 or some other algorithm. > > Make sure to run: > > make check TESTS=3Dtests/print.scm > > afterwards! > > Thanks, > Ludo=E2=80=99. LOL Time to fix the warning then? ;)