[bug#49575] [PATCH] Add date2name

[bug#49575] [PATCH] Add date2name

[phodina via Guix-patches via]

---
index d8c3fbec07..ac9a5f940d 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -105,6 +105,7 @@
 ;;; Copyright © 2021 Danial Behzadi <dani.behzi@ubuntu.com>
 ;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be>
 ;;; Copyright © 2021 Hugo Lecomte <hugo.lecomte@inria.fr>
+;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -904,6 +905,37 @@ iotop, uptime, pidof, tty, taskset, pmap.")
     (properties `((python2-variant . ,(delay python2-psutil))))
     (license license:bsd-3)))

+(define-public python-date2name
+(package
+  (name "date2name")
+  (version "6c8f37277e8ec82aa50f90b8921422be30c4e798")
+  (source (origin
+            (method git-fetch)
+            (uri
+	      (git-reference
+		(url "https://github.com/novoid/date2name")
+		(commit version)))
+            (sha256
+             (base32
+              "1vq96b7n16d932nyfhnzwdwxff0zrqanidmwr4cxj2p67ad9y3w7"))))
+  (build-system python-build-system)
+  (arguments
+    `(#:tests? #f
+      #:phases
+      (modify-phases %standard-phases
+	(delete 'build)
+	(replace 'install
+	 (lambda* (#:key outputs #:allow-other-keys)
+	  (let* ((bindir (string-append (assoc-ref outputs "out") "/bin"))
+		 (binary (string-append bindir "/date2name")))
+	    (mkdir-p bindir)
+	    (copy-file "date2name/__init__.py" binary)
+	    (chmod binary #o555)))))))
+  (synopsis "Handling time-stamps and date-stamps in file names")
+  (description "Per default, date2name gets the modification time of matching files and directories and adds a datestamp in standard ISO 8601+ format YYYY-MM-DD (http://datestamps.org/index.shtml) at the beginning of the file- or directoryname.")
+  (home-page "https://github.com/novoid/date2name")
+  (license license:gpl3)))
+
 (define-public python2-psutil
   (let ((base (package-with-python2 (strip-python2-variant python-psutil))))
     (package/inherit base
--
2.31.1

[bug#49575] [PATCH] Add date2name

[phodina via Guix-patches via]

Here's updated patch with following changes:
- removed trailing whitespace
- add comment for git commit
- add comment for no tests
- lines have less than 80 chars

---
index 2a4f50ad46..220ac39e1d 100644
--- a/gnu/packages/python-check.scm
+++ b/gnu/packages/python-check.scm
@@ -905,6 +905,40 @@ for the @code{pytest} framework.")
 rounds that are calibrated to the chosen timer.")
     (license license:bsd-2)))

+
+(define-public python-date2name
+(package
+  (name "date2name")
+  (version "6c8f37277e8ec82aa50f90b8921422be30c4e798") ; no tags
+  (source (origin
+            (method git-fetch)
+            (uri (git-reference
+                  (url "https://github.com/novoid/date2name")
+                  (commit version)))
+            (sha256
+             (base32
+              "1vq96b7n16d932nyfhnzwdwxff0zrqanidmwr4cxj2p67ad9y3w7"))))
+  (build-system python-build-system)
+  (arguments
+    `(#:tests? #f ; no tests
+      #:phases
+      (modify-phases %standard-phases
+       (delete 'build)
+       (replace 'install
+        (lambda* (#:key outputs #:allow-other-keys)
+         (let* ((bindir (string-append (assoc-ref outputs "out") "/bin"))
+                (binary (string-append bindir "/date2name")))
+          (mkdir-p bindir)
+          (copy-file "date2name/__init__.py" binary)
+          (chmod binary #o555)))))))
+  (synopsis "Handling time-stamps and date-stamps in file names")
+  (description "Per default, date2name gets the modification time of matching
+files and directories and adds a datestamp in standard ISO 8601+ format
+YYYY-MM-DD (http://datestamps.org/index.shtml) at the beginning of the file-
+or directoryname.")
+  (home-page "https://github.com/novoid/date2name")
+  (license license:gpl3)))
+
 (define-public python-pytest-xvfb
   (package
     (name "python-pytest-xvfb")
--
2.31.1

[bug#49575] [PATCH] Add date2name

[Ludovic Courtès]

Hi phodina,

phodina <phodina@protonmail.com> skribis:

> Here's updated patch with following changes:
> - removed trailing whitespace
> - add comment for git commit
> - add comment for no tests
> - lines have less than 80 chars

Thanks for your patch!  Overall it looks like it’s almost ready.  Here
are suggestions to complete it:

> +(define-public python-date2name
> +(package
> +  (name "date2name")

This should be indented; please check the indentation of the packages
around, and consider running ./etc/indent-code.el as mentioned at:

  https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

> +  (version "6c8f37277e8ec82aa50f90b8921422be30c4e798") ; no tags

Please check
<https://guix.gnu.org/manual/en/html_node/Version-Numbers.html> for how
to choose version numbers.

> +  (source (origin
> +            (method git-fetch)
> +            (uri (git-reference
> +                  (url "https://github.com/novoid/date2name")
> +                  (commit version)))
> +            (sha256
> +             (base32
> +              "1vq96b7n16d932nyfhnzwdwxff0zrqanidmwr4cxj2p67ad9y3w7"))))

‘guix lint’ would probably warn you about the file name of the checkout;
you can add a ‘file-name’ field to the origin to fix that.

> +  (build-system python-build-system)
> +  (arguments
> +    `(#:tests? #f ; no tests
> +      #:phases
> +      (modify-phases %standard-phases
> +       (delete 'build)
> +       (replace 'install
> +        (lambda* (#:key outputs #:allow-other-keys)
> +         (let* ((bindir (string-append (assoc-ref outputs "out") "/bin"))
> +                (binary (string-append bindir "/date2name")))
> +          (mkdir-p bindir)
> +          (copy-file "date2name/__init__.py" binary)
> +          (chmod binary #o555)))))))
> +  (synopsis "Handling time-stamps and date-stamps in file names")
> +  (description "Per default, date2name gets the modification time of matching

s/Per/By/

> +files and directories and adds a datestamp in standard ISO 8601+ format
> +YYYY-MM-DD (http://datestamps.org/index.shtml) at the beginning of the file-
> +or directoryname.")

s/file-/file/ and s/directoryname/directory name/

Please use @uref for the URL (Texinfo markup).

> +  (home-page "https://github.com/novoid/date2name")
> +  (license license:gpl3)))

This should be ‘license:gpl3+’ because nothing in the code says “version
3 only”.

Could you send an updated patch?

Thank you!

Ludo’.

[bug#49575] [PATCH v3] gnu: Add python-date2name.

[phodina via Guix-patches via]

Hi Ludo,

thanks for the suggestions and excellent documentation! Here's the updated patch.
-------------------------------------

* gnu/packages/python-check.scm (date2name): New variable.

diff --git a/gnu/packages/python-check.scm b/gnu/packages/python-check.scm
index 2a4f50ad46..afd5cb5cb9 100644
--- a/gnu/packages/python-check.scm
+++ b/gnu/packages/python-check.scm
@@ -13,6 +13,7 @@
 ;;; Copyright © 2021 Brendan Tildesley <mail@brendan.scot>
 ;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
 ;;; Copyright © 2021 Bonface Munyoki Kilyungi <me@bonfacemunyoki.com>
+;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -905,6 +906,42 @@ for the @code{pytest} framework.")
 rounds that are calibrated to the chosen timer.")
     (license license:bsd-2)))

+(define-public python-date2name
+  (let ((commit "6c8f37277e8ec82aa50f90b8921422be30c4e798")
+        (revision "1"))
+    (package
+      (name "python-date2name")
+      (version (git-version "" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/novoid/date2name")
+               (commit version)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "1vq96b7n16d932nyfhnzwdwxff0zrqanidmwr4cxj2p67ad9y3w7"))))
+      (build-system python-build-system)
+      (arguments
+       `(#:tests? #f                    ; no tests
+         #:phases
+         (modify-phases %standard-phases
+           (delete 'build)
+           (replace 'install
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let* ((bindir (string-append (assoc-ref outputs "out") "/bin"))
+                      (binary (string-append bindir "/date2name")))
+                 (mkdir-p bindir)
+                 (copy-file "date2name/__init__.py" binary)
+                 (chmod binary #o555)))))))
+      (synopsis "Handling time-stamps and date-stamps in file names")
+      (description "By default, date2name gets the modification time of matching
+files and directories and adds a datestamp in standard ISO 8601+ format
+YYYY-MM-DD at the beginning of the file or directory name.")
+      (home-page "https://github.com/novoid/date2name")
+      (license license:gpl3+))))
+
 (define-public python-pytest-xvfb
   (package
     (name "python-pytest-xvfb")
--
2.32.0

bug#49575: [PATCH v3] gnu: Add python-date2name.

[Ludovic Courtès]

Hello,

phodina <phodina@protonmail.com> skribis:

> Hi Ludo,
>
> thanks for the suggestions and excellent documentation! Here's the updated patch.
> -------------------------------------
>
> * gnu/packages/python-check.scm (date2name): New variable.

I applied it with a couple of changes I forgot to suggest earlier:
moving it to python-xyz.scm (python-check.scm is for tools related to
test suites), renaming it to “date2name” since it’s a command-line tool
and not a Python library, and having the ‘commit’ field of
‘git-reference’ refer to the commit, not the version number.

Thanks!

Ludo’.