From: "Ludovic Courtès" <ludo@gnu.org>
To: phodina <phodina@protonmail.com>
Cc: 49575@debbugs.gnu.org
Subject: [bug#49575] [PATCH] Add date2name
Date: Thu, 29 Jul 2021 21:43:44 +0200 [thread overview]
Message-ID: <87eebg29e7.fsf_-_@gnu.org> (raw)
In-Reply-To: <gHjvOIOOkGRdbmGmB40mbTNr9jRjJGH8UJ7ggEOhHRmmQJUa67jCdVc6AhXD8iPlArcId65nCpiwgXelarQBjooRtxokmKDnh3Ej5vWcg3w=@protonmail.com> (phodina@protonmail.com's message of "Sun, 18 Jul 2021 10:24:06 +0000")
Hi phodina,
phodina <phodina@protonmail.com> skribis:
> Here's updated patch with following changes:
> - removed trailing whitespace
> - add comment for git commit
> - add comment for no tests
> - lines have less than 80 chars
Thanks for your patch! Overall it looks like it’s almost ready. Here
are suggestions to complete it:
> +(define-public python-date2name
> +(package
> + (name "date2name")
This should be indented; please check the indentation of the packages
around, and consider running ./etc/indent-code.el as mentioned at:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html
> + (version "6c8f37277e8ec82aa50f90b8921422be30c4e798") ; no tags
Please check
<https://guix.gnu.org/manual/en/html_node/Version-Numbers.html> for how
to choose version numbers.
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/novoid/date2name")
> + (commit version)))
> + (sha256
> + (base32
> + "1vq96b7n16d932nyfhnzwdwxff0zrqanidmwr4cxj2p67ad9y3w7"))))
‘guix lint’ would probably warn you about the file name of the checkout;
you can add a ‘file-name’ field to the origin to fix that.
> + (build-system python-build-system)
> + (arguments
> + `(#:tests? #f ; no tests
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'build)
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((bindir (string-append (assoc-ref outputs "out") "/bin"))
> + (binary (string-append bindir "/date2name")))
> + (mkdir-p bindir)
> + (copy-file "date2name/__init__.py" binary)
> + (chmod binary #o555)))))))
> + (synopsis "Handling time-stamps and date-stamps in file names")
> + (description "Per default, date2name gets the modification time of matching
s/Per/By/
> +files and directories and adds a datestamp in standard ISO 8601+ format
> +YYYY-MM-DD (http://datestamps.org/index.shtml) at the beginning of the file-
> +or directoryname.")
s/file-/file/ and s/directoryname/directory name/
Please use @uref for the URL (Texinfo markup).
> + (home-page "https://github.com/novoid/date2name")
> + (license license:gpl3)))
This should be ‘license:gpl3+’ because nothing in the code says “version
3 only”.
Could you send an updated patch?
Thank you!
Ludo’.
next prev parent reply other threads:[~2021-07-29 19:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 16:05 [bug#49575] [PATCH] Add date2name phodina via Guix-patches via
2021-07-18 10:24 ` phodina via Guix-patches via
2021-07-29 19:43 ` Ludovic Courtès [this message]
2021-08-31 11:15 ` [bug#49575] [PATCH v3] gnu: Add python-date2name phodina via Guix-patches via
2021-09-01 21:04 ` bug#49575: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eebg29e7.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=49575@debbugs.gnu.org \
--cc=phodina@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).