From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OG83HAkFA2EkQgEAgWs5BA (envelope-from ) for ; Thu, 29 Jul 2021 21:44:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id IOrTFwkFA2FKIAAAB5/wlQ (envelope-from ) for ; Thu, 29 Jul 2021 19:44:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E4E1D27866 for ; Thu, 29 Jul 2021 21:44:08 +0200 (CEST) Received: from localhost ([::1]:54584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9Bwt-0001B0-TL for larch@yhetil.org; Thu, 29 Jul 2021 15:44:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9Bwo-0001Ap-Bh for guix-patches@gnu.org; Thu, 29 Jul 2021 15:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46771) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m9Bwo-0005dr-4W for guix-patches@gnu.org; Thu, 29 Jul 2021 15:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m9Bwo-00075b-3L for guix-patches@gnu.org; Thu, 29 Jul 2021 15:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49575] [PATCH] Add date2name Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 29 Jul 2021 19:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49575 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: phodina Cc: 49575@debbugs.gnu.org Received: via spool by 49575-submit@debbugs.gnu.org id=B49575.162758783327230 (code B ref 49575); Thu, 29 Jul 2021 19:44:02 +0000 Received: (at 49575) by debbugs.gnu.org; 29 Jul 2021 19:43:53 +0000 Received: from localhost ([127.0.0.1]:58317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9Bwf-000757-3y for submit@debbugs.gnu.org; Thu, 29 Jul 2021 15:43:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m9Bwd-00074v-BD for 49575@debbugs.gnu.org; Thu, 29 Jul 2021 15:43:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46750) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9BwX-0005Sn-Uw; Thu, 29 Jul 2021 15:43:45 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45322 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9BwX-0001qM-Na; Thu, 29 Jul 2021 15:43:45 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Thu, 29 Jul 2021 21:43:44 +0200 In-Reply-To: (phodina@protonmail.com's message of "Sun, 18 Jul 2021 10:24:06 +0000") Message-ID: <87eebg29e7.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627587849; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=72zr2480PNVF1ndNBb92zIBnJwmThi6OxXp2uk40ZGo=; b=KLGMxFqJjlO2LbIO/RgzR0mNY/+yqByHEbN/PSyC0esRxnazsXouL0vGq0s4RbIsbAb6dU DFlkk23md5Hx2ulMqWpaTzZDVvYcYhzEqeUAMfl+Mj1p7DcOpKWnoIQaOOQo3YxTTLx+Tu 78erRe8nIj0oVnJc8fOuzxLiWUguWzPxoqddWvTGGQEtziwalnR7X3C8H1XFRDxGnW5vhi fScWQAJRY6V0tHxsn/un3YuRQPuORPRRvItAID/E2WZEvFQYwx9+iDnzyg1HshCTKoC3U3 Lw/+ys+ehv2bYtB1icUE9CYgIuy39xGAIzmeLvqgLt56PRjf+sqqIYpCO9qutg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627587849; a=rsa-sha256; cv=none; b=tgEwzDaCv/4jSK2J0HpT0Qwok4sPAOPZmpJKpMa+fKEBCQ4UDX5b2hNmHgwU8CW7IUbwRU 14Lu3qL6SrlU4MuqfU/S7lPxt3FcNXEYzp4bfVdr2E/DNwJKvUoXkxiLx9lKyIA2ixk5Bg oIkOzMvXzpaN8RA8K1DC9dTl2gZkAxJHx44Ep7E7u29Q4lfpHFD2KOxV9c7NmEGzD9jznk wfgtcoN56wD9p3upW2kHGlUq4DD0U/GJZppEnemVN03LqLsusPcmZCzATAuIVcSlNzj0fy 3+Opm2+z/XHFsI9ZtVm/ygiVBls9fY2bFebUYZDEAmCWdpQBFFZKCA/3wnu0CA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E4E1D27866 X-Spam-Score: -2.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: XHabm4HCuxQa Hi phodina, phodina skribis: > Here's updated patch with following changes: > - removed trailing whitespace > - add comment for git commit > - add comment for no tests > - lines have less than 80 chars Thanks for your patch! Overall it looks like it=E2=80=99s almost ready. H= ere are suggestions to complete it: > +(define-public python-date2name > +(package > + (name "date2name") This should be indented; please check the indentation of the packages around, and consider running ./etc/indent-code.el as mentioned at: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html > + (version "6c8f37277e8ec82aa50f90b8921422be30c4e798") ; no tags Please check for how to choose version numbers. > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/novoid/date2name") > + (commit version))) > + (sha256 > + (base32 > + "1vq96b7n16d932nyfhnzwdwxff0zrqanidmwr4cxj2p67ad9y3w7")))) =E2=80=98guix lint=E2=80=99 would probably warn you about the file name of = the checkout; you can add a =E2=80=98file-name=E2=80=99 field to the origin to fix that. > + (build-system python-build-system) > + (arguments > + `(#:tests? #f ; no tests > + #:phases > + (modify-phases %standard-phases > + (delete 'build) > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((bindir (string-append (assoc-ref outputs "out") "/bin")) > + (binary (string-append bindir "/date2name"))) > + (mkdir-p bindir) > + (copy-file "date2name/__init__.py" binary) > + (chmod binary #o555))))))) > + (synopsis "Handling time-stamps and date-stamps in file names") > + (description "Per default, date2name gets the modification time of mat= ching s/Per/By/ > +files and directories and adds a datestamp in standard ISO 8601+ format > +YYYY-MM-DD (http://datestamps.org/index.shtml) at the beginning of the f= ile- > +or directoryname.") s/file-/file/ and s/directoryname/directory name/ Please use @uref for the URL (Texinfo markup). > + (home-page "https://github.com/novoid/date2name") > + (license license:gpl3))) This should be =E2=80=98license:gpl3+=E2=80=99 because nothing in the code = says =E2=80=9Cversion 3 only=E2=80=9D. Could you send an updated patch? Thank you! Ludo=E2=80=99.