* [bug#57133] [PATCH] gnu: Add rizin. @ 2022-08-11 6:37 iyzsong--- via Guix-patches via 2022-08-11 12:44 ` Jean Pierre De Jesus DIAZ via Guix-patches via 2022-08-11 19:07 ` Maxime Devos 0 siblings, 2 replies; 8+ messages in thread From: iyzsong--- via Guix-patches via @ 2022-08-11 6:37 UTC (permalink / raw) To: 57133; +Cc: 宋文武 From: 宋文武 <iyzsong@member.fsf.org> * gnu/packages/engineering.scm (rizin): New variable. --- gnu/packages/engineering.scm | 68 ++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index ed87cd8d6a..7752e92f09 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -67,6 +67,7 @@ (define-module (gnu packages engineering) #:use-module (guix build-system cmake) #:use-module (guix build-system emacs) #:use-module (guix build-system gnu) + #:use-module (guix build-system meson) #:use-module (guix build-system python) #:use-module (guix build-system qt) #:use-module (gnu packages) @@ -88,6 +89,7 @@ (define-module (gnu packages engineering) #:use-module (gnu packages digest) #:use-module (gnu packages docbook) #:use-module (gnu packages documentation) + #:use-module (gnu packages file) #:use-module (gnu packages flex) #:use-module (gnu packages fontutils) #:use-module (gnu packages fpga) @@ -142,6 +144,7 @@ (define-module (gnu packages engineering) #:use-module (gnu packages tbb) #:use-module (gnu packages tcl) #:use-module (gnu packages texinfo) + #:use-module (gnu packages text-editors) #:use-module (gnu packages tls) #:use-module (gnu packages tex) #:use-module (gnu packages version-control) @@ -3757,3 +3760,68 @@ (define-public candle @item Visualizing G-code files. @end itemize") (license license:gpl3+)))) + +(define-public rizin + (package + (name "rizin") + (version "0.4.0") + (source (origin + (method url-fetch) + (uri (string-append + "https://github.com/rizinorg/rizin/releases/download/v" + version "/rizin-src-v" version ".tar.xz")) + (sha256 + (base32 + "0nkb6v9lks25w5sv5s6p2ghgqnnnsf39md8nlx1cy4z89xlaisq9")))) + (build-system meson-build-system) + (arguments + (list + #:configure-flags + #~(list "-Dpackager=guix" + (string-append "-Dpackager_version=" #$version) + "-Duse_sys_capstone=enabled" + "-Duse_sys_magic=enabled" + "-Duse_sys_libzip=enabled" + "-Duse_sys_zlib=enabled" + "-Duse_sys_lz4=enabled" + "-Duse_sys_xxhash=enabled" + "-Duse_sys_openssl=enabled" + "-Duse_sys_tree_sitter=enabled" + "-Duse_sys_libuv=enabled" + "-Duse_gpl=true") + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'prepare-testbins + (lambda _ + (copy-recursively + #$(origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/rizinorg/rizin-testbins") + (commit "7d0c31ac7711de9c4d37f5047200dc5a407ff713"))) + (sha256 + (base32 + "00cmc7pws9m4hcm0bpdjm6n4agl5mqgczc4ccswfhywyzzvr7sqh"))) + "test/bins"))) + (add-before 'configure 'skip-failing-tests + (lambda _ + ;; Skip 2 failing tests, reported upstream: + ;; <https://github.com/rizinorg/rizin/issues/2905>. + (substitute* "test/integration/meson.build" + (("'analysis_global_var'") "#") + (("'sign_integration'") "#"))))))) + (native-inputs (list pkg-config)) + (inputs + (list capstone file libuv libzip lz4 openssl tree-sitter xxhash zlib)) + (home-page "https://rizin.re") + (synopsis "Disasm, debug, analyze and manipulate binary files") + (description + "Rizin is a reverse engineering framework and a set of small command-line +utilities, providing a complete binary analysis experience with features like +disassembler, hexadecimal editor, emulation, binary inspection, debugger, and +more.") + ;; Most files are under LGPL-3.0-only, other are under: Apache-2.0, + ;; BSD-2-Clause, BSD-3-Clause, CC0-1.0, CC-BY-SA-4.0, GPL-1.0-or-later, + ;; GPL-2.0-only, GPL-2.0-or-later, GPL-3.0-or-later, LGPL-2.0-or-later, + ;; LGPL-2.1-only, LGPL-2.1-or-later, LGPL-3.0-only, MIT, NCSA. + (license license:gpl3+))) -- 2.37.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [bug#57133] [PATCH] gnu: Add rizin. 2022-08-11 6:37 [bug#57133] [PATCH] gnu: Add rizin iyzsong--- via Guix-patches via @ 2022-08-11 12:44 ` Jean Pierre De Jesus DIAZ via Guix-patches via 2022-08-15 1:36 ` 宋文武 via Guix-patches via 2022-08-11 19:07 ` Maxime Devos 1 sibling, 1 reply; 8+ messages in thread From: Jean Pierre De Jesus DIAZ via Guix-patches via @ 2022-08-11 12:44 UTC (permalink / raw) To: 57133@debbugs.gnu.org Hello, >+ (add-after 'unpack 'prepare-testbins >+ (lambda _ >+ (copy-recursively >+ #$(origin >+ (method git-fetch) >+ (uri (git-reference >+ (url "https://github.com/rizinorg/rizin-testbins") >+ (commit "7d0c31ac7711de9c4d37f5047200dc5a407ff713"))) >+ (sha256 >+ (base32 >+ "00cmc7pws9m4hcm0bpdjm6n4agl5mqgczc4ccswfhywyzzvr7sqh"))) >+ "test/bins"))) Could this instead be replaced with a package? The repository also says that the binaries could be regenerated and it's worth a look looking into if it can be done so the built binaries can be removed (through snippets for example) and re-compiled from sources, of course, those that can be re-generated should be left as is. If the binaries can't be regenerated feel free to ignore this comment :). — Jean-Pierre De Jesus DIAZ ^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#57133] [PATCH] gnu: Add rizin. 2022-08-11 12:44 ` Jean Pierre De Jesus DIAZ via Guix-patches via @ 2022-08-15 1:36 ` 宋文武 via Guix-patches via 0 siblings, 0 replies; 8+ messages in thread From: 宋文武 via Guix-patches via @ 2022-08-15 1:36 UTC (permalink / raw) To: Jean Pierre De Jesus DIAZ; +Cc: 57133@debbugs.gnu.org Jean Pierre De Jesus DIAZ <me@jeandudey.tech> writes: > Hello, > >>+ (add-after 'unpack 'prepare-testbins >>+ (lambda _ >>+ (copy-recursively >>+ #$(origin >>+ (method git-fetch) >>+ (uri (git-reference >>+ (url "https://github.com/rizinorg/rizin-testbins") >>+ (commit "7d0c31ac7711de9c4d37f5047200dc5a407ff713"))) >>+ (sha256 >>+ (base32 >>+ "00cmc7pws9m4hcm0bpdjm6n4agl5mqgczc4ccswfhywyzzvr7sqh"))) >>+ "test/bins"))) > > Could this instead be replaced with a package? The repository also says that > the binaries could be regenerated and it's worth a look looking into if it > can be done so the built binaries can be removed (through snippets for example) > and re-compiled from sources, of course, those that can be re-generated should > be left as is. If the binaries can't be regenerated feel free to ignore this > comment :). Well I find no way to regenerate those binaries, so I'd remove it and skip integration tests as suggested by Maxime Devos. Thanks for the comment! ^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#57133] [PATCH] gnu: Add rizin. 2022-08-11 6:37 [bug#57133] [PATCH] gnu: Add rizin iyzsong--- via Guix-patches via 2022-08-11 12:44 ` Jean Pierre De Jesus DIAZ via Guix-patches via @ 2022-08-11 19:07 ` Maxime Devos 2022-08-15 1:34 ` 宋文武 via Guix-patches via 1 sibling, 1 reply; 8+ messages in thread From: Maxime Devos @ 2022-08-11 19:07 UTC (permalink / raw) To: iyzsong, 57133; +Cc: 宋文武 [-- Attachment #1.1.1: Type: text/plain, Size: 1560 bytes --] On 11-08-2022 08:37, iyzsong--- via Guix-patches via wrote: > + #$(origin > + (method git-fetch) > + (uri (git-reference > + (url"https://github.com/rizinorg/rizin-testbins") > + (commit "7d0c31ac7711de9c4d37f5047200dc5a407ff713"))) > + (sha256 > + (base32 > + "00cmc7pws9m4hcm0bpdjm6n4agl5mqgczc4ccswfhywyzzvr7sqh"))) > + "test/bins"))) What's the license for those binaries? I doubt all of them are gpl3+. I'm seeing a copy of libstdc++.so.6 in there. IIRC, it has a license of the GPL family, which requires providing the source, so we need the source code of it as well because of the licensing terms (the source code of that particular variant of libstdc++, which might differ from the version currently in Guix). Likewise for the other binaries. Personally, I think it would be more practical to ignore rizin-testbins, even if that requires skipping some of the tests (hopefully not all of them). > + ;; Most files are under LGPL-3.0-only, other are under: Apache-2.0, > + ;; BSD-2-Clause, BSD-3-Clause, CC0-1.0, CC-BY-SA-4.0, GPL-1.0-or-later, > + ;; GPL-2.0-only, GPL-2.0-or-later, GPL-3.0-or-later, LGPL-2.0-or-later, > + ;; LGPL-2.1-only, LGPL-2.1-or-later, LGPL-3.0-only, MIT, NCSA. > + (license license:gpl3+))) You can put multiple licenses in the license field, using (license (list this that foo bar ...)). Greetings, Maxime. [-- Attachment #1.1.2: OpenPGP public key --] [-- Type: application/pgp-keys, Size: 929 bytes --] [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 236 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#57133] [PATCH] gnu: Add rizin. 2022-08-11 19:07 ` Maxime Devos @ 2022-08-15 1:34 ` 宋文武 via Guix-patches via 2022-08-19 1:20 ` bug#57133: " 宋文武 via Guix-patches via ` (2 more replies) 0 siblings, 3 replies; 8+ messages in thread From: 宋文武 via Guix-patches via @ 2022-08-15 1:34 UTC (permalink / raw) To: Maxime Devos; +Cc: 宋文武, 57133 [-- Attachment #1: Type: text/plain, Size: 2214 bytes --] Maxime Devos <maximedevos@telenet.be> writes: Hello, thank for the review! > On 11-08-2022 08:37, iyzsong--- via Guix-patches via wrote: >> + #$(origin >> + (method git-fetch) >> + (uri (git-reference >> + (url"https://github.com/rizinorg/rizin-testbins") >> + (commit "7d0c31ac7711de9c4d37f5047200dc5a407ff713"))) >> + (sha256 >> + (base32 >> + "00cmc7pws9m4hcm0bpdjm6n4agl5mqgczc4ccswfhywyzzvr7sqh"))) >> + "test/bins"))) > > What's the license for those binaries? I doubt all of them are gpl3+. > > I'm seeing a copy of libstdc++.so.6 in there. IIRC, it has a license > of the GPL family, which requires providing the source, so we need the > source code of it as well because of the licensing terms (the source > code of that particular variant of libstdc++, which might differ from > the version currently in Guix). Likewise for the other binaries. > > Personally, I think it would be more practical to ignore > rizin-testbins, even if that requires skipping some of the tests > (hopefully not all of them). I think those binaries as data, not programs to be run. Well, most of them don't have sources in the repository, so I'll remove it and skip the integration tests. >> + ;; Most files are under LGPL-3.0-only, other are under: Apache-2.0, >> + ;; BSD-2-Clause, BSD-3-Clause, CC0-1.0, CC-BY-SA-4.0, GPL-1.0-or-later, >> + ;; GPL-2.0-only, GPL-2.0-or-later, GPL-3.0-or-later, LGPL-2.0-or-later, >> + ;; LGPL-2.1-only, LGPL-2.1-or-later, LGPL-3.0-only, MIT, NCSA. >> + (license license:gpl3+))) > > You can put multiple licenses in the license field, using (license > (list this that foo bar ...)). For the license field, do we need to list all licenses of source code files, or the whole license of the package? And if the later, `(list license:gpl2+ license:lgpl3+)` would say the package is dual licenses, under GPL2+ or LGPL3+ at user's choice. I think with all those licenses, the whole package is under GPL-3.0-or-later. Correct me if wrong, thank you! Patch updated to remove rizin-testsbin and skip integration tests: [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: 0001-gnu-Add-rizin.patch --] [-- Type: text/x-patch, Size: 4077 bytes --] From 26b9a23efd456ec3ef439fbf3159823e0984c0eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@member.fsf.org> Date: Thu, 11 Aug 2022 14:37:49 +0800 Subject: [PATCH v2] gnu: Add rizin. * gnu/packages/engineering.scm (rizin): New variable. --- gnu/packages/engineering.scm | 57 ++++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index f350da0042..892a05d5d0 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -67,6 +67,7 @@ (define-module (gnu packages engineering) #:use-module (guix build-system cmake) #:use-module (guix build-system emacs) #:use-module (guix build-system gnu) + #:use-module (guix build-system meson) #:use-module (guix build-system python) #:use-module (guix build-system qt) #:use-module (gnu packages) @@ -88,6 +89,7 @@ (define-module (gnu packages engineering) #:use-module (gnu packages digest) #:use-module (gnu packages docbook) #:use-module (gnu packages documentation) + #:use-module (gnu packages file) #:use-module (gnu packages flex) #:use-module (gnu packages fontutils) #:use-module (gnu packages fpga) @@ -142,6 +144,7 @@ (define-module (gnu packages engineering) #:use-module (gnu packages tbb) #:use-module (gnu packages tcl) #:use-module (gnu packages texinfo) + #:use-module (gnu packages text-editors) #:use-module (gnu packages tls) #:use-module (gnu packages tex) #:use-module (gnu packages version-control) @@ -3757,3 +3760,57 @@ (define-public candle @item Visualizing G-code files. @end itemize") (license license:gpl3+)))) + +(define-public rizin + (package + (name "rizin") + (version "0.4.0") + (source (origin + (method url-fetch) + (uri (string-append + "https://github.com/rizinorg/rizin/releases/download/v" + version "/rizin-src-v" version ".tar.xz")) + (sha256 + (base32 + "0nkb6v9lks25w5sv5s6p2ghgqnnnsf39md8nlx1cy4z89xlaisq9")))) + (build-system meson-build-system) + (arguments + (list + #:configure-flags + #~(list "-Dpackager=guix" + (string-append "-Dpackager_version=" #$version) + "-Duse_sys_capstone=enabled" + "-Duse_sys_magic=enabled" + "-Duse_sys_libzip=enabled" + "-Duse_sys_zlib=enabled" + "-Duse_sys_lz4=enabled" + "-Duse_sys_xxhash=enabled" + "-Duse_sys_openssl=enabled" + "-Duse_sys_tree_sitter=enabled" + "-Duse_sys_libuv=enabled" + "-Duse_gpl=true") + #:phases + #~(modify-phases %standard-phases + (add-before 'configure 'skip-integration-tests + (lambda _ + ;; Skip integration tests, which require prebuilt binaries at: + ;; <https://github.com/rizinorg/rizin-testbins>. + ;; And 2 of them are failing, reported upstream: + ;; <https://github.com/rizinorg/rizin/issues/2905>. + (substitute* "test/meson.build" + (("subdir\\('integration'\\)") ""))))))) + (native-inputs (list pkg-config)) + (inputs + (list capstone file libuv libzip lz4 openssl tree-sitter xxhash zlib)) + (home-page "https://rizin.re") + (synopsis "Disasm, debug, analyze and manipulate binary files") + (description + "Rizin is a reverse engineering framework and a set of small command-line +utilities, providing a complete binary analysis experience with features like +disassembler, hexadecimal editor, emulation, binary inspection, debugger, and +more.") + ;; Most files are under LGPL-3.0-only, other are under: Apache-2.0, + ;; BSD-2-Clause, BSD-3-Clause, CC0-1.0, CC-BY-SA-4.0, GPL-1.0-or-later, + ;; GPL-2.0-only, GPL-2.0-or-later, GPL-3.0-or-later, LGPL-2.0-or-later, + ;; LGPL-2.1-only, LGPL-2.1-or-later, LGPL-3.0-only, MIT, NCSA. + (license license:gpl3+))) -- 2.37.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* bug#57133: [PATCH] gnu: Add rizin. 2022-08-15 1:34 ` 宋文武 via Guix-patches via @ 2022-08-19 1:20 ` 宋文武 via Guix-patches via 2022-08-26 13:49 ` [bug#57133] " Maxime Devos 2022-08-26 13:54 ` Maxime Devos 2 siblings, 0 replies; 8+ messages in thread From: 宋文武 via Guix-patches via @ 2022-08-19 1:20 UTC (permalink / raw) To: Maxime Devos; +Cc: 宋文武, 57133-done Pushed now! ^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#57133] [PATCH] gnu: Add rizin. 2022-08-15 1:34 ` 宋文武 via Guix-patches via 2022-08-19 1:20 ` bug#57133: " 宋文武 via Guix-patches via @ 2022-08-26 13:49 ` Maxime Devos 2022-08-26 13:54 ` Maxime Devos 2 siblings, 0 replies; 8+ messages in thread From: Maxime Devos @ 2022-08-26 13:49 UTC (permalink / raw) To: 宋文武; +Cc: 宋文武, 57133 [-- Attachment #1.1.1.1: Type: text/plain, Size: 845 bytes --] On 15-08-2022 03:34, 宋文武 wrote: >> You can put multiple licenses in the license field, using (license >> (list this that foo bar ...)). > For the license field, do we need to list all licenses of source code > files, or the whole license of the package? And if the later, > `(list license:gpl2+ license:lgpl3+)` would say the package is dual > licenses, under GPL2+ or LGPL3+ at user's choice. > > I think with all those licenses, the whole package is under > GPL-3.0-or-later. > > Correct me if wrong, thank you! I do not think it's stated anywhere which one exactly, but my own interpretation of the 'license' field is 'all the relevant licenses', without any claims whether it is a 'choose this or that' situation or a 'one component is licensed as X, another is licensed as Y' situation. Greetings, Maxime. [-- Attachment #1.1.1.2: Type: text/html, Size: 1336 bytes --] [-- Attachment #1.1.2: OpenPGP public key --] [-- Type: application/pgp-keys, Size: 929 bytes --] [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 236 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#57133] [PATCH] gnu: Add rizin. 2022-08-15 1:34 ` 宋文武 via Guix-patches via 2022-08-19 1:20 ` bug#57133: " 宋文武 via Guix-patches via 2022-08-26 13:49 ` [bug#57133] " Maxime Devos @ 2022-08-26 13:54 ` Maxime Devos 2 siblings, 0 replies; 8+ messages in thread From: Maxime Devos @ 2022-08-26 13:54 UTC (permalink / raw) To: 宋文武; +Cc: 宋文武, 57133 [-- Attachment #1.1.1.1: Type: text/plain, Size: 1005 bytes --] On 15-08-2022 03:34, 宋文武 wrote: >> What's the license for those binaries? I doubt all of them are gpl3+. >> >> I'm seeing a copy of libstdc++.so.6 in there. IIRC, it has a license >> of the GPL family, which requires providing the source, so we need the >> source code of it as well because of the licensing terms (the source >> code of that particular variant of libstdc++, which might differ from >> the version currently in Guix). Likewise for the other binaries. >> >> Personally, I think it would be more practical to ignore >> rizin-testbins, even if that requires skipping some of the tests >> (hopefully not all of them). > I think those binaries as data, not programs to be run. Well, most of > them don't have sources in the repository, so I'll remove it and skip > the integration tests. This 'data' is still under various different licenses, some of which require providing source code. Copyright law not only covers programs to be run. Greetings, Maxime. [-- Attachment #1.1.1.2: Type: text/html, Size: 1439 bytes --] [-- Attachment #1.1.2: OpenPGP public key --] [-- Type: application/pgp-keys, Size: 929 bytes --] [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 236 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-08-26 13:55 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-08-11 6:37 [bug#57133] [PATCH] gnu: Add rizin iyzsong--- via Guix-patches via 2022-08-11 12:44 ` Jean Pierre De Jesus DIAZ via Guix-patches via 2022-08-15 1:36 ` 宋文武 via Guix-patches via 2022-08-11 19:07 ` Maxime Devos 2022-08-15 1:34 ` 宋文武 via Guix-patches via 2022-08-19 1:20 ` bug#57133: " 宋文武 via Guix-patches via 2022-08-26 13:49 ` [bug#57133] " Maxime Devos 2022-08-26 13:54 ` Maxime Devos
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).