From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GNdCI8yi+WIUqwAAbAwnHQ (envelope-from ) for ; Mon, 15 Aug 2022 03:35:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yOozI8yi+WKW1gAAauVa8A (envelope-from ) for ; Mon, 15 Aug 2022 03:35:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 22AC1D6FD for ; Mon, 15 Aug 2022 03:35:08 +0200 (CEST) Received: from localhost ([::1]:42446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNP0V-00007T-0Z for larch@yhetil.org; Sun, 14 Aug 2022 21:35:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNP0Q-00007H-IL for guix-patches@gnu.org; Sun, 14 Aug 2022 21:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50359) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oNP0Q-00015C-9A for guix-patches@gnu.org; Sun, 14 Aug 2022 21:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oNP0Q-0002eJ-3Q for guix-patches@gnu.org; Sun, 14 Aug 2022 21:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57133] [PATCH] gnu: Add rizin. Resent-From: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 Aug 2022 01:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57133 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= , 57133@debbugs.gnu.org Received: via spool by 57133-submit@debbugs.gnu.org id=B57133.166052726710133 (code B ref 57133); Mon, 15 Aug 2022 01:35:02 +0000 Received: (at 57133) by debbugs.gnu.org; 15 Aug 2022 01:34:27 +0000 Received: from localhost ([127.0.0.1]:40108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNOzq-0002dM-Hs for submit@debbugs.gnu.org; Sun, 14 Aug 2022 21:34:27 -0400 Received: from envs.net ([89.163.145.170]:37582 helo=mail.envs.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNOzm-0002d9-K0 for 57133@debbugs.gnu.org; Sun, 14 Aug 2022 21:34:25 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 4730038A0DEA; Mon, 15 Aug 2022 01:34:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1660527260; bh=aBeYXrqLuIeaWEdKLftvneqBoBts5qNVwHxhH8gC4YU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RlcQNcsHw4zJBweQ5GE8xPF4eV0HnmMkuaWvJLX3EujBfKPYXFVpSvDRbcANnyCbq b5iDHNMzUXZbozl1i2GL3CwXuGfvIi5MZzxZEkZXq4OujJhKMFq328JH4MCDeRGu6A yrShxAor7hpVmMobeeQQ1UJfPg1zJli7DctxAkhCnngHsusx67K8GzzzJlDSrQz98w G6A1XfW6s2gozLlWCXW0BlzpIzef73/av7PR/pjVPL18rnK0fwsG8v4C0w/hjEHoA/ EBq0UCPjv3uhT7d+b7Q3HqGpgc+ARn6c9Au1RQxIGZQAePp9DHfJKfYq+K4aYgkhRK IXfDL2+hc8uYjM/KBKYOy8re9t61OhgZH+HvIEIJBoQf33OLT1HsOM3JgVa4mMhZXf eC1TOVWz9Q1BcKLayvh7ZPWwWi3h8trW99XBjj9K7lE19rpNzNvvNpSKYYH8HTPDSc vd/DXyvuNOgIyN4StRhXX7hpqp50k2cUf0iigyH7yVazebUd+/GmlYCpXooG4vOgtf J3u+RLzy4IviZQqC/Knz0R5kBYbwX0zNdolKtqnwPOJiGIzpIncO42Cg8wJPMCKr3o ffvlR9UO1K7FkpUA4v5SzEygTMnQ6MpDByQzL+MgG/+XCuTOzJi82rqPU4e2/e+k9/ rYptrT3ZQ2rZh1Sqp1S5CPuM= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 9LRa1tAgTteh; Mon, 15 Aug 2022 01:34:16 +0000 (UTC) Received: from localhost (unknown [182.150.116.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: iyzsong@envs.net) by mail.envs.net (Postfix) with ESMTPSA; Mon, 15 Aug 2022 01:34:15 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 47a9b9bc; Mon, 15 Aug 2022 01:34:16 +0000 (UTC) References: <20220811063749.8293-1-iyzsong@envs.net> <13b3d37d-f4c6-4850-900c-49b5cce8d4a8@telenet.be> Date: Mon, 15 Aug 2022 09:34:16 +0800 In-Reply-To: <13b3d37d-f4c6-4850-900c-49b5cce8d4a8@telenet.be> (Maxime Devos's message of "Thu, 11 Aug 2022 21:07:18 +0200") Message-ID: <87wnbai92f.fsf_-_@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-ACL-Warn: , =?utf-8?b?5a6L5paH5q2mIHZpYSBHdWl4LXBhdGNoZXM=?= From: =?utf-8?b?5a6L5paH5q2mIHZpYSBHdWl4LXBhdGNoZXM=?= via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660527308; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=aBeYXrqLuIeaWEdKLftvneqBoBts5qNVwHxhH8gC4YU=; b=ZYnRKJlzZsHcslZN7jjVsQElo67h7zfrtd+L3QdRFssgP5juw5FY0CSiWQ8Mvqa/vkg/yB iN3PXvqMEriT6nwiMJ3anrJP4rgr4Ifk2hf3hq9ty6wD28CMPRmpYJ2TGdNiTkpKPkPK0c tmJ2lE5TVKFqjtoNmmQazzj0+8zeNq3WI4MlL+93WjVQAb9LS2w7e7Fl5z8gXtN/8jz45E kpkjs51gVUFR8/3sB05g3X+y0Snty4eugIUMjYl2oUaPn9p7/JABNKS3xzhDbxAPplgDp3 mfwXB4Lj/w/0cnuEA42Nf1hXtueLUORaGSOB5sfOyM6PLPZOC1VVHxapC37L9g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660527308; a=rsa-sha256; cv=none; b=Ew6IpOlUjb3gMUkypFRlWguTWirW9gDRjZdw9xpPZ+zolR4TO44Vcsnu0RFr8YM5q7lg/P MRlhBWXP/vnxmINraWSr678Qy30OkVsQyv9V22BUsEbsNw812RJYAswznXT4RUF74p3F/8 2EHsDmBfECiYe+SgcV95gj+WjpEnW0zKHqQUzO49oi84nkQ4/dR3EzjRQ+xzyg3TmOKTBR BKfqoboz9UM1x6r8Z83lwEeo4Ht6hc03Aoz9Fkih+/3l+mDH8ZPw80BaS5MK1oXNK2mRhn yOdgiRHtsUJhCyRtxWC9wjS4sMVkUt2d8gsNmF5smfbqTQvgzFU+VtRwmeejug== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=envs.net header.s=modoboa header.b=RlcQNcsH; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.16 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=envs.net header.s=modoboa header.b=RlcQNcsH; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 22AC1D6FD X-Spam-Score: -4.16 X-Migadu-Scanner: scn0.migadu.com X-TUID: gDePmtEblHt3 --=-=-= Content-Type: text/plain Maxime Devos writes: Hello, thank for the review! > On 11-08-2022 08:37, iyzsong--- via Guix-patches via wrote: >> + #$(origin >> + (method git-fetch) >> + (uri (git-reference >> + (url"https://github.com/rizinorg/rizin-testbins") >> + (commit "7d0c31ac7711de9c4d37f5047200dc5a407ff713"))) >> + (sha256 >> + (base32 >> + "00cmc7pws9m4hcm0bpdjm6n4agl5mqgczc4ccswfhywyzzvr7sqh"))) >> + "test/bins"))) > > What's the license for those binaries? I doubt all of them are gpl3+. > > I'm seeing a copy of libstdc++.so.6 in there. IIRC, it has a license > of the GPL family, which requires providing the source, so we need the > source code of it as well because of the licensing terms (the source > code of that particular variant of libstdc++, which might differ from > the version currently in Guix). Likewise for the other binaries. > > Personally, I think it would be more practical to ignore > rizin-testbins, even if that requires skipping some of the tests > (hopefully not all of them). I think those binaries as data, not programs to be run. Well, most of them don't have sources in the repository, so I'll remove it and skip the integration tests. >> + ;; Most files are under LGPL-3.0-only, other are under: Apache-2.0, >> + ;; BSD-2-Clause, BSD-3-Clause, CC0-1.0, CC-BY-SA-4.0, GPL-1.0-or-later, >> + ;; GPL-2.0-only, GPL-2.0-or-later, GPL-3.0-or-later, LGPL-2.0-or-later, >> + ;; LGPL-2.1-only, LGPL-2.1-or-later, LGPL-3.0-only, MIT, NCSA. >> + (license license:gpl3+))) > > You can put multiple licenses in the license field, using (license > (list this that foo bar ...)). For the license field, do we need to list all licenses of source code files, or the whole license of the package? And if the later, `(list license:gpl2+ license:lgpl3+)` would say the package is dual licenses, under GPL2+ or LGPL3+ at user's choice. I think with all those licenses, the whole package is under GPL-3.0-or-later. Correct me if wrong, thank you! Patch updated to remove rizin-testsbin and skip integration tests: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-Add-rizin.patch >From 26b9a23efd456ec3ef439fbf3159823e0984c0eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Date: Thu, 11 Aug 2022 14:37:49 +0800 Subject: [PATCH v2] gnu: Add rizin. * gnu/packages/engineering.scm (rizin): New variable. --- gnu/packages/engineering.scm | 57 ++++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index f350da0042..892a05d5d0 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -67,6 +67,7 @@ (define-module (gnu packages engineering) #:use-module (guix build-system cmake) #:use-module (guix build-system emacs) #:use-module (guix build-system gnu) + #:use-module (guix build-system meson) #:use-module (guix build-system python) #:use-module (guix build-system qt) #:use-module (gnu packages) @@ -88,6 +89,7 @@ (define-module (gnu packages engineering) #:use-module (gnu packages digest) #:use-module (gnu packages docbook) #:use-module (gnu packages documentation) + #:use-module (gnu packages file) #:use-module (gnu packages flex) #:use-module (gnu packages fontutils) #:use-module (gnu packages fpga) @@ -142,6 +144,7 @@ (define-module (gnu packages engineering) #:use-module (gnu packages tbb) #:use-module (gnu packages tcl) #:use-module (gnu packages texinfo) + #:use-module (gnu packages text-editors) #:use-module (gnu packages tls) #:use-module (gnu packages tex) #:use-module (gnu packages version-control) @@ -3757,3 +3760,57 @@ (define-public candle @item Visualizing G-code files. @end itemize") (license license:gpl3+)))) + +(define-public rizin + (package + (name "rizin") + (version "0.4.0") + (source (origin + (method url-fetch) + (uri (string-append + "https://github.com/rizinorg/rizin/releases/download/v" + version "/rizin-src-v" version ".tar.xz")) + (sha256 + (base32 + "0nkb6v9lks25w5sv5s6p2ghgqnnnsf39md8nlx1cy4z89xlaisq9")))) + (build-system meson-build-system) + (arguments + (list + #:configure-flags + #~(list "-Dpackager=guix" + (string-append "-Dpackager_version=" #$version) + "-Duse_sys_capstone=enabled" + "-Duse_sys_magic=enabled" + "-Duse_sys_libzip=enabled" + "-Duse_sys_zlib=enabled" + "-Duse_sys_lz4=enabled" + "-Duse_sys_xxhash=enabled" + "-Duse_sys_openssl=enabled" + "-Duse_sys_tree_sitter=enabled" + "-Duse_sys_libuv=enabled" + "-Duse_gpl=true") + #:phases + #~(modify-phases %standard-phases + (add-before 'configure 'skip-integration-tests + (lambda _ + ;; Skip integration tests, which require prebuilt binaries at: + ;; . + ;; And 2 of them are failing, reported upstream: + ;; . + (substitute* "test/meson.build" + (("subdir\\('integration'\\)") ""))))))) + (native-inputs (list pkg-config)) + (inputs + (list capstone file libuv libzip lz4 openssl tree-sitter xxhash zlib)) + (home-page "https://rizin.re") + (synopsis "Disasm, debug, analyze and manipulate binary files") + (description + "Rizin is a reverse engineering framework and a set of small command-line +utilities, providing a complete binary analysis experience with features like +disassembler, hexadecimal editor, emulation, binary inspection, debugger, and +more.") + ;; Most files are under LGPL-3.0-only, other are under: Apache-2.0, + ;; BSD-2-Clause, BSD-3-Clause, CC0-1.0, CC-BY-SA-4.0, GPL-1.0-or-later, + ;; GPL-2.0-only, GPL-2.0-or-later, GPL-3.0-or-later, LGPL-2.0-or-later, + ;; LGPL-2.1-only, LGPL-2.1-or-later, LGPL-3.0-only, MIT, NCSA. + (license license:gpl3+))) -- 2.37.1 --=-=-=--