unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "宋文武 via Guix-patches via" <guix-patches@gnu.org>
To: Jean Pierre De Jesus DIAZ <me@jeandudey.tech>
Cc: "57133@debbugs.gnu.org" <57133@debbugs.gnu.org>
Subject: [bug#57133] [PATCH] gnu: Add rizin.
Date: Mon, 15 Aug 2022 09:36:20 +0800	[thread overview]
Message-ID: <87tu6ei8yz.fsf_-_@envs.net> (raw)
In-Reply-To: <-qs8Pq5Vb7uSjqzSHMdR0GyyAjaomvLtncIYh9wNz4twTFBfX82vTKGVYk6bTghepDUm3TrNFmA9riCCdnRJdyFqqKjPCM0GPSRSE-fuS1Q=@jeandudey.tech> (Jean Pierre De Jesus DIAZ's message of "Thu, 11 Aug 2022 12:44:00 +0000")

Jean Pierre De Jesus DIAZ <me@jeandudey.tech> writes:

> Hello, 
>
>>+          (add-after 'unpack 'prepare-testbins
>>+            (lambda _
>>+              (copy-recursively
>>+               #$(origin
>>+                   (method git-fetch)
>>+                   (uri (git-reference
>>+                         (url "https://github.com/rizinorg/rizin-testbins")
>>+                         (commit "7d0c31ac7711de9c4d37f5047200dc5a407ff713")))
>>+                   (sha256
>>+                    (base32
>>+                     "00cmc7pws9m4hcm0bpdjm6n4agl5mqgczc4ccswfhywyzzvr7sqh")))
>>+               "test/bins")))
>
> Could this instead be replaced with a package? The repository also says that
> the binaries could be regenerated and it's worth a look looking into if it
> can be done so the built binaries can be removed (through snippets for example)
> and re-compiled from sources, of course, those that can be re-generated should
> be left as is. If the binaries can't be regenerated feel free to ignore this
> comment :).

Well I find no way to regenerate those binaries, so I'd remove it and
skip integration tests as suggested by Maxime Devos.  Thanks for the
comment!




  reply	other threads:[~2022-08-15  1:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11  6:37 [bug#57133] [PATCH] gnu: Add rizin iyzsong--- via Guix-patches via
2022-08-11 12:44 ` Jean Pierre De Jesus DIAZ via Guix-patches via
2022-08-15  1:36   ` 宋文武 via Guix-patches via [this message]
2022-08-11 19:07 ` Maxime Devos
2022-08-15  1:34   ` 宋文武 via Guix-patches via
2022-08-19  1:20     ` bug#57133: " 宋文武 via Guix-patches via
2022-08-26 13:49     ` [bug#57133] " Maxime Devos
2022-08-26 13:54     ` Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu6ei8yz.fsf_-_@envs.net \
    --to=guix-patches@gnu.org \
    --cc=57133@debbugs.gnu.org \
    --cc=iyzsong@envs.net \
    --cc=me@jeandudey.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).