From: Hilton Chain via Guix-patches via <guix-patches@gnu.org>
To: 59552@debbugs.gnu.org
Cc: Hilton Chain <hako@ultrarare.space>,
Nicolas Goaziou <mail@nicolasgoaziou.fr>,
Andrew Tropin <andrew@trop.in>,
Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: [bug#59552] [PATCH v2 0/1] gnu: Add emacs-wakatime-mode.
Date: Sat, 15 Jul 2023 23:01:40 +0800 [thread overview]
Message-ID: <cover.1689427041.git.hako@ultrarare.space> (raw)
In-Reply-To: <20221125011530.12585-1-hako@ultrarare.space>
Hello Guix!
After looking through waktime-mode's source and Guix's build phases, I think
it's OK to add the package first without packaging the wakatime-cli program.
(Actually I managed to package all the dependencies of that go program locally,
but it eventually failed to build without a clear error...)
For the package definition itself, phase 'patch-el-files is still deleted
because of the following error:
--8<---------------cut here---------------start------------->8---
In guix/build/emacs-build-system.scm:
148:13 3 (loop (#(" ((file-exists-p (format \"/bin/%s\" …" …)) …)
In ice-9/boot-9.scm:
1685:16 2 (raise-exception _ #:continuable? _)
1685:16 1 (raise-exception _ #:continuable? _)
1685:16 0 (raise-exception _ #:continuable? _)
ice-9/boot-9.scm:1685:16: In procedure raise-exception:
patch-el-files: unable to locate "%s"
--8<---------------cut here---------------end--------------->8---
I added a comment before suggesting that wakatime-cli is not available, but
that was inaccurate. The real cause is that 'patch-el-files can't handle the
following code:
--8<---------------cut here---------------start------------->8---
(defun wakatime-find-binary (program)
"Find the full path to an executable program."
(cond
[...]
((file-exists-p (format "/bin/%s" program))
(format "/bin/%s" program))
[...]))
--8<---------------cut here---------------end--------------->8---
This seems to be a bug of the phase, as it shouldn't handle unformatted
"/bin/%s" at all. And for the function finding an executable, it's
unnecessary to patch it, then I think it's fine to delete the phase.
And finally, it's wakatime-mode-test.el, the cases are so outdated that none
of them could pass... There's no Makefile for 'check phase to run the test
either, so no need to adjust for it.
As a result, I think it's OK to add the package first without packaging the
wakatime-cli program.
Hilton Chain (1):
gnu: Add emacs-wakatime-mode.
gnu/packages/emacs-xyz.scm | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
base-commit: 01412c6c6a98e4da10676560638640d0f33e1a02
--
2.41.0
next prev parent reply other threads:[~2023-07-15 15:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 1:15 [bug#59552] [PATCH] gnu: Add emacs-wakatime-mode Hilton Chain via Guix-patches via
2022-11-26 10:21 ` Nicolas Goaziou
2023-07-15 15:01 ` Hilton Chain via Guix-patches via [this message]
2023-07-15 15:05 ` [bug#59552] [PATCH v2 1/1] " Hilton Chain via Guix-patches via
2023-07-16 7:17 ` [bug#59552] [PATCH v2 0/1] " Liliana Marie Prikler
2023-07-18 16:35 ` Hilton Chain via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1689427041.git.hako@ultrarare.space \
--to=guix-patches@gnu.org \
--cc=59552@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=hako@ultrarare.space \
--cc=liliana.prikler@gmail.com \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).