unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Hilton Chain via Guix-patches via <guix-patches@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: Hilton Chain <hako@ultrarare.space>,
	59552@debbugs.gnu.org, Nicolas Goaziou <mail@nicolasgoaziou.fr>,
	Andrew Tropin <andrew@trop.in>
Subject: [bug#59552] [PATCH v2 0/1] gnu: Add emacs-wakatime-mode.
Date: Wed, 19 Jul 2023 00:35:25 +0800	[thread overview]
Message-ID: <875y6hyy7m.wl-hako@ultrarare.space> (raw)
In-Reply-To: <797011fcc7b4dc7f7b291e2a28e28b4e2f902017.camel@gmail.com>

On Sun, 16 Jul 2023 15:17:01 +0800,
Liliana Marie Prikler wrote:
> I think this should be 
>   (or (executable-find program) 
>       (cdr-safe (assoc program <some hardcoded table>))
> where some hardcoded table contains stubs to fill in via 
> (search-input-file …)

Thank you for the suggestion!

Sorry for the incomplete information, the PROGRAM argument is actually
nonsense because `wakatime-find-binary' is not a user-facing function
and is called with a fixed value of "wakatime-cli", so it's not
appropriate to use an alist.  

Other (hardcoded) values are actually handled as conditions within the
function. 

I tried replacing the conditions with yours, except for the `cdr-safe'
line, which is replaced by a `locate-file', and it seems to work fine.
The new function does not contain a "/bin/[...]" so 'patch-el-files
won't handle it.

This may not be expected but I think it's enough to improve the
function itself.

I'll send a patch to upstream and send v3 later.

Thanks




      reply	other threads:[~2023-07-18 16:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-25  1:15 [bug#59552] [PATCH] gnu: Add emacs-wakatime-mode Hilton Chain via Guix-patches via
2022-11-26 10:21 ` Nicolas Goaziou
2023-07-15 15:01 ` [bug#59552] [PATCH v2 0/1] " Hilton Chain via Guix-patches via
2023-07-15 15:05   ` [bug#59552] [PATCH v2 1/1] " Hilton Chain via Guix-patches via
2023-07-16  7:17   ` [bug#59552] [PATCH v2 0/1] " Liliana Marie Prikler
2023-07-18 16:35     ` Hilton Chain via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875y6hyy7m.wl-hako@ultrarare.space \
    --to=guix-patches@gnu.org \
    --cc=59552@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=hako@ultrarare.space \
    --cc=liliana.prikler@gmail.com \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).