unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Hilton Chain <hako@ultrarare.space>, 59552@debbugs.gnu.org
Cc: Nicolas Goaziou <mail@nicolasgoaziou.fr>, Andrew Tropin <andrew@trop.in>
Subject: [bug#59552] [PATCH v2 0/1] gnu: Add emacs-wakatime-mode.
Date: Sun, 16 Jul 2023 09:17:01 +0200	[thread overview]
Message-ID: <797011fcc7b4dc7f7b291e2a28e28b4e2f902017.camel@gmail.com> (raw)
In-Reply-To: <cover.1689427041.git.hako@ultrarare.space>

Am Samstag, dem 15.07.2023 um 23:01 +0800 schrieb Hilton Chain:
> --8<---------------cut here---------------start------------->8---
> (defun wakatime-find-binary (program)
>   "Find the full path to an executable program."
>   (cond
>     [...]
>     ((file-exists-p (format "/bin/%s" program))
>       (format "/bin/%s" program))
>     [...]))
> --8<---------------cut here---------------end--------------->8---
> 
> This seems to be a bug of the phase, as it shouldn't handle
> unformatted
> "/bin/%s" at all.  And for the function finding an executable, it's
> unnecessary to patch it, then I think it's fine to delete the phase.
I think this should be 
  (or (executable-find program) 
      (cdr-safe (assoc program <some hardcoded table>))
where some hardcoded table contains stubs to fill in via 
(search-input-file …)

Cheers  




  parent reply	other threads:[~2023-07-16  7:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-25  1:15 [bug#59552] [PATCH] gnu: Add emacs-wakatime-mode Hilton Chain via Guix-patches via
2022-11-26 10:21 ` Nicolas Goaziou
2023-07-15 15:01 ` [bug#59552] [PATCH v2 0/1] " Hilton Chain via Guix-patches via
2023-07-15 15:05   ` [bug#59552] [PATCH v2 1/1] " Hilton Chain via Guix-patches via
2023-07-16  7:17   ` Liliana Marie Prikler [this message]
2023-07-18 16:35     ` [bug#59552] [PATCH v2 0/1] " Hilton Chain via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=797011fcc7b4dc7f7b291e2a28e28b4e2f902017.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=59552@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=hako@ultrarare.space \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).