From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id +PSQE7e1smSe1wAASxT56A (envelope-from ) for ; Sat, 15 Jul 2023 17:05:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id +BtME7e1smQMOwAAauVa8A (envelope-from ) for ; Sat, 15 Jul 2023 17:05:27 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 63AD661370 for ; Sat, 15 Jul 2023 17:05:26 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=FiMpmcSh; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689433526; a=rsa-sha256; cv=none; b=m/DYRHi/J0g5RIhxQpQSzQ8v9t8cxrOi9xADF8TZh/WPNlbCw88Ei4W5dBz9qfUGzLLn/N iS8igvCdoEXYeh4n6ELCC5EUVkQ3XH1pWDWSVeD+6FjcLy9kPLdbjeV5nlHTPrFTReKF1l PPUjFZJDmqR+GyHuvUzbyvWbxN3bskK+hfEbEdNIybPTy9ZNykwWOdUVJXzvkg5LcLWchy EGfddHkkL4rJUtmokV29rX7LI16nDgYTngGaP0eZQnrBkHaY8W8LsqzhNqL1PJ48IB6jq5 AzP+1iCmSYtBm2EyQIoYifoNBAvmJ5uYM7vVdbth08Dj/7tXjHpFvW2nd6XguA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=FiMpmcSh; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689433526; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+LICoIeOeyo9JqqHeZ905kdZy+UzQMvI8YzofGeY/64=; b=cAbTlaF91zIKJ7n/bGJrIf+EoQdUSAcZ8NVy6b8XPFzSJCCq7deEVKSF5m5ecM7F8ySvXP J+vs/GJgpr6ihRk2t02BGlKmCI2P0jIBm2D6JyGAiH8zR5Zg2pedaOs76/W3E49VdG3DIs poA4s9uNkuKYyD6b0ky4CGb996HiqqUl1zZGPCfyCwdAAPmpOyTbnKBEk+e7ySL/BU2tNF w6Dbs/z6odi+5cCUYF/0SIndfai9qP25VaNKl5FzE/3xJQkGBc2EJFjbmCAGDZcO3X5lGr JSOd9e1x64MmI2L4HT3A6j8/hTuK1xk7Hyzjfk1RaBZvr5rBBrtWCjJWLHzZxQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKgpU-0002hG-UF; Sat, 15 Jul 2023 11:05:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKgpT-0002gr-Eo for guix-patches@gnu.org; Sat, 15 Jul 2023 11:05:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKgpT-0005Ix-6n for guix-patches@gnu.org; Sat, 15 Jul 2023 11:05:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKgpR-0008VC-S0; Sat, 15 Jul 2023 11:05:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#59552] [PATCH v2 0/1] gnu: Add emacs-wakatime-mode. Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: andrew@trop.in, liliana.prikler@gmail.com, guix-patches@gnu.org Resent-Date: Sat, 15 Jul 2023 15:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59552 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: 59552@debbugs.gnu.org Cc: Hilton Chain , Nicolas Goaziou , Andrew Tropin , Liliana Marie Prikler X-Debbugs-Original-Xcc: Andrew Tropin , Liliana Marie Prikler Received: via spool by 59552-submit@debbugs.gnu.org id=B59552.168943345532623 (code B ref 59552); Sat, 15 Jul 2023 15:05:01 +0000 Received: (at 59552) by debbugs.gnu.org; 15 Jul 2023 15:04:15 +0000 Received: from localhost ([127.0.0.1]:45754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKgog-0008U6-P0 for submit@debbugs.gnu.org; Sat, 15 Jul 2023 11:04:15 -0400 Received: from mail.boiledscript.com ([144.168.59.46]:34806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKgoe-0008Tx-9O for 59552@debbugs.gnu.org; Sat, 15 Jul 2023 11:04:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1689433205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+LICoIeOeyo9JqqHeZ905kdZy+UzQMvI8YzofGeY/64=; b=FiMpmcShCYYfElC+KfNsp7gGHWjW1j4zbHu7i+yAg0TwzbEZkKHTFVA+uL3Ge3jWLD/vYD q67XWEI0SXWzHGyW8TUAVKhse74/Ccwd4l2l1SKI8FrdLOKB4GBvxKCweZkN7n4UOmSpwy I+2ne0PK0SS3iPBV2xGG/+JYYkCeqfbo9yBdR1uivK6jDrWDgF26LO82lf0pW60p/k5Nk4 AQMAf8rgyjUL7GVGe5z4B2hKieF8/x5WqchLKP/h5vcUGYQBxL/Eavhb49rFUWuVpHCL8n LqVQU62nIcnP43VvH+KuJZqd/ZW+CGsKLLGLeebf9ifnoNK5vKVODqsMiprNZg== Date: Sat, 15 Jul 2023 23:01:40 +0800 Message-ID: In-Reply-To: <20221125011530.12585-1-hako@ultrarare.space> References: <20221125011530.12585-1-hako@ultrarare.space> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain X-ACL-Warn: , Hilton Chain via Guix-patches From: Hilton Chain via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -0.41 X-Spam-Score: -0.41 X-Migadu-Queue-Id: 63AD661370 X-TUID: UJbkONdkrFXi Hello Guix! After looking through waktime-mode's source and Guix's build phases, I think it's OK to add the package first without packaging the wakatime-cli program. (Actually I managed to package all the dependencies of that go program locally, but it eventually failed to build without a clear error...) For the package definition itself, phase 'patch-el-files is still deleted because of the following error: --8<---------------cut here---------------start------------->8--- In guix/build/emacs-build-system.scm: 148:13 3 (loop (#(" ((file-exists-p (format \"/bin/%s\" …" …)) …) In ice-9/boot-9.scm: 1685:16 2 (raise-exception _ #:continuable? _) 1685:16 1 (raise-exception _ #:continuable? _) 1685:16 0 (raise-exception _ #:continuable? _) ice-9/boot-9.scm:1685:16: In procedure raise-exception: patch-el-files: unable to locate "%s" --8<---------------cut here---------------end--------------->8--- I added a comment before suggesting that wakatime-cli is not available, but that was inaccurate. The real cause is that 'patch-el-files can't handle the following code: --8<---------------cut here---------------start------------->8--- (defun wakatime-find-binary (program) "Find the full path to an executable program." (cond [...] ((file-exists-p (format "/bin/%s" program)) (format "/bin/%s" program)) [...])) --8<---------------cut here---------------end--------------->8--- This seems to be a bug of the phase, as it shouldn't handle unformatted "/bin/%s" at all. And for the function finding an executable, it's unnecessary to patch it, then I think it's fine to delete the phase. And finally, it's wakatime-mode-test.el, the cases are so outdated that none of them could pass... There's no Makefile for 'check phase to run the test either, so no need to adjust for it. As a result, I think it's OK to add the package first without packaging the wakatime-cli program. Hilton Chain (1): gnu: Add emacs-wakatime-mode. gnu/packages/emacs-xyz.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) base-commit: 01412c6c6a98e4da10676560638640d0f33e1a02 -- 2.41.0