unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#39332] [PATCH] system: Add btrfs-progs to %BASE-PACKAGES.
@ 2020-01-28 22:26 Leo Famulari
  2020-01-28 22:42 ` Jonathan Brielmaier
  0 siblings, 1 reply; 5+ messages in thread
From: Leo Famulari @ 2020-01-28 22:26 UTC (permalink / raw)
  To: 39332

* gnu/system.scm (%base-packages): Add btrfs-progs.
---
 gnu/system.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/system.scm b/gnu/system.scm
index 01baa248a2..7cb6bef99d 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -586,7 +586,8 @@ of PROVENANCE-SERVICE-TYPE to its services."
          ;; already depends on it anyway.
          kmod eudev
 
-         e2fsprogs kbd
+         btrfs-progs e2fsprogs
+         kbd
 
          bash-completion
 
-- 
2.25.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#39332] [PATCH] system: Add btrfs-progs to %BASE-PACKAGES.
  2020-01-28 22:26 [bug#39332] [PATCH] system: Add btrfs-progs to %BASE-PACKAGES Leo Famulari
@ 2020-01-28 22:42 ` Jonathan Brielmaier
  2020-01-28 23:14   ` Leo Famulari
  0 siblings, 1 reply; 5+ messages in thread
From: Jonathan Brielmaier @ 2020-01-28 22:42 UTC (permalink / raw)
  To: 39332

On 28.01.20 23:26, Leo Famulari wrote:
> * gnu/system.scm (%base-packages): Add btrfs-progs.

This adds btrfs-progs, zstd and lzo to the closure with a total of
7.7MiB. So that doesn't seem to big. I'm just wondering if we need btrfs
support here at all, as I would call btrfs still kind of exotic apart
from *SUSE distros and Facebook's backend.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#39332] [PATCH] system: Add btrfs-progs to %BASE-PACKAGES.
  2020-01-28 22:42 ` Jonathan Brielmaier
@ 2020-01-28 23:14   ` Leo Famulari
  2020-01-29 11:19     ` Brice Waegeneire
  0 siblings, 1 reply; 5+ messages in thread
From: Leo Famulari @ 2020-01-28 23:14 UTC (permalink / raw)
  To: Jonathan Brielmaier; +Cc: 39332

On Tue, Jan 28, 2020 at 11:42:16PM +0100, Jonathan Brielmaier wrote:
> This adds btrfs-progs, zstd and lzo to the closure with a total of
> 7.7MiB. So that doesn't seem to big. I'm just wondering if we need btrfs
> support here at all, as I would call btrfs still kind of exotic apart
> from *SUSE distros and Facebook's backend.

Yeah, maybe it is too niche. I use it on all my machines but that's just
me. Let's wait to see if there are more comments before deciding.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#39332] [PATCH] system: Add btrfs-progs to %BASE-PACKAGES.
  2020-01-28 23:14   ` Leo Famulari
@ 2020-01-29 11:19     ` Brice Waegeneire
  2020-02-08  0:21       ` bug#39332: " Leo Famulari
  0 siblings, 1 reply; 5+ messages in thread
From: Brice Waegeneire @ 2020-01-29 11:19 UTC (permalink / raw)
  To: Leo Famulari; +Cc: 39332, Jonathan Brielmaier, Guix-patches

On 2020-01-28 23:14, Leo Famulari wrote:
> On Tue, Jan 28, 2020 at 11:42:16PM +0100, Jonathan Brielmaier wrote:
>> This adds btrfs-progs, zstd and lzo to the closure with a total of
>> 7.7MiB. So that doesn't seem to big. I'm just wondering if we need 
>> btrfs
>> support here at all, as I would call btrfs still kind of exotic apart
>> from *SUSE distros and Facebook's backend.
> 
> Yeah, maybe it is too niche. I use it on all my machines but that's 
> just
> me. Let's wait to see if there are more comments before deciding.

Maybe %base-packages is the wrong place to add it. But it should at 
least be added to the system profile if a file-systems entry uses btrfs 
which isn't the case as I recall.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#39332: [PATCH] system: Add btrfs-progs to %BASE-PACKAGES.
  2020-01-29 11:19     ` Brice Waegeneire
@ 2020-02-08  0:21       ` Leo Famulari
  0 siblings, 0 replies; 5+ messages in thread
From: Leo Famulari @ 2020-02-08  0:21 UTC (permalink / raw)
  To: Brice Waegeneire; +Cc: 39332-done

On Wed, Jan 29, 2020 at 11:19:18AM +0000, Brice Waegeneire wrote:
> On 2020-01-28 23:14, Leo Famulari wrote:
> > On Tue, Jan 28, 2020 at 11:42:16PM +0100, Jonathan Brielmaier wrote:
> > > This adds btrfs-progs, zstd and lzo to the closure with a total of
> > > 7.7MiB. So that doesn't seem to big. I'm just wondering if we need
> > > btrfs
> > > support here at all, as I would call btrfs still kind of exotic apart
> > > from *SUSE distros and Facebook's backend.
> > 
> > Yeah, maybe it is too niche. I use it on all my machines but that's just
> > me. Let's wait to see if there are more comments before deciding.
> 
> Maybe %base-packages is the wrong place to add it. But it should at least be
> added to the system profile if a file-systems entry uses btrfs which isn't
> the case as I recall.

You're right, that's a much better idea!

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-02-08  0:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-28 22:26 [bug#39332] [PATCH] system: Add btrfs-progs to %BASE-PACKAGES Leo Famulari
2020-01-28 22:42 ` Jonathan Brielmaier
2020-01-28 23:14   ` Leo Famulari
2020-01-29 11:19     ` Brice Waegeneire
2020-02-08  0:21       ` bug#39332: " Leo Famulari

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).