unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Vinicius Monego <monego@posteo.net>
To: Marius Bakke <marius@gnu.org>, 42082@debbugs.gnu.org
Subject: [bug#42082] [PATCH 1/6] gnu: Add python-covdefaults.
Date: Tue, 21 Jul 2020 15:28:40 -0300	[thread overview]
Message-ID: <9787249e066d55ae94bbd08f2c0b9dedfa3137bb.camel@posteo.net> (raw)
In-Reply-To: <87365lj3eu.fsf@gnu.org>

Em seg, 2020-07-20 às 23:13 +0200, Marius Bakke escreveu:
> Hi Vinicius,

Hello Marius,

Thanks for the tips!

> We now have a 'python-check.scm' which is preferable to
> check.scm.  Can
> you add this library there instead?

Sure. I overlooked that file. I sent another series of 6 pytest patches
before this, and will send a v2 for that as well.

> Should pytest be propagated here?
> 
> Also, as this package is a plugin for coverage, maybe it should not
> propagate coverage either.  The reason is that propagating prevents
> it
> from being (easily) used with other versions of coverage.  Let's say
> that a package needs a newer coverage than the default in Guix + this
> plugin, propagation here would bring in the wrong coverage version.

Oh, I thought that the pytest binary should be available as an
executable for the plugin to be used, similar to how APT has pytest as
a dependency for plugins. Maybe it's just me thinking in terms of
traditional package management.

The PyPI importer will propagate pytest by default, and it's common to
see it propagated in other plugins in check.scm. But now I see that
many plugins do not propagate it. Should pytest not be an input at all
(unless the plugin uses it for its own tests, in which case it should
be a native input)?

> I know it's a lot to ask :-) but can you try to expand on how it
> differs
> from the apparently unreasonable defaults in coverage?  "Sensible"
> also
> borders on "marketing speak", perhaps "opinionated" is a better term.

That's a slight rewording of the author's description in the
repository, and that's the only verbal information I could find about
the project. The differences can be seen in the README and in the
source code, but I don't know what to write about them, or even why the
changes are 'more sensible'.





  reply	other threads:[~2020-07-21 18:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-27 15:46 [bug#42082] [PATCH 1/6] gnu: Add python-covdefaults Vinicius Monego
2020-06-27 15:46 ` [bug#42083] [PATCH 2/6] gnu: Add python-cfgv Vinicius Monego
2020-07-20 21:17   ` Marius Bakke
2020-06-27 15:46 ` [bug#42084] [PATCH 3/6] gnu: Add python-identify Vinicius Monego
2020-07-20 21:17   ` Marius Bakke
2020-06-27 15:46 ` [bug#42085] [PATCH 4/6] gnu: Add python-nodeenv Vinicius Monego
2020-07-20 21:25   ` Marius Bakke
2020-07-21 18:42     ` Vinicius Monego
2020-06-27 15:46 ` [bug#42086] [PATCH 5/6] gnu: Add python-pytest-env Vinicius Monego
2020-07-20 21:27   ` Marius Bakke
2020-06-27 15:46 ` [bug#42087] [PATCH 6/6] gnu: Add python-pre-commit Vinicius Monego
2020-07-20 21:36   ` Marius Bakke
2020-07-21 18:57     ` Vinicius Monego
2020-07-20 21:13 ` [bug#42082] [PATCH 1/6] gnu: Add python-covdefaults Marius Bakke
2020-07-21 18:28   ` Vinicius Monego [this message]
2020-07-21 21:48     ` Marius Bakke
2020-07-24 12:01 ` [bug#42082] [PATCH v2 " Vinicius Monego
2020-07-24 12:01   ` [bug#42082] [PATCH v2 2/6] gnu: Add python-cfgv Vinicius Monego
2020-07-24 12:01   ` [bug#42082] [PATCH v2 3/6] gnu: Add python-identify Vinicius Monego
2020-07-25 16:33     ` Marius Bakke
2020-07-24 12:01   ` [bug#42082] [PATCH v2 4/6] gnu: Add python-nodeenv Vinicius Monego
2020-07-24 12:01   ` [bug#42082] [PATCH v2 5/6] gnu: Add python-pytest-env Vinicius Monego
2020-07-24 12:01   ` [bug#42082] [PATCH v2 6/6] gnu: Add python-pre-commit Vinicius Monego
2020-07-25 16:38     ` bug#42082: " Marius Bakke
2020-07-25  2:21 ` [bug#42082] [PATCH 1/6] gnu: Add python-covdefaults Brett Gilio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9787249e066d55ae94bbd08f2c0b9dedfa3137bb.camel@posteo.net \
    --to=monego@posteo.net \
    --cc=42082@debbugs.gnu.org \
    --cc=marius@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).