From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CF1SNPYzF18eZAAA0tVLHw (envelope-from ) for ; Tue, 21 Jul 2020 18:29:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id mCowMPYzF18+XgAAB5/wlQ (envelope-from ) for ; Tue, 21 Jul 2020 18:29:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0AEC09404CF for ; Tue, 21 Jul 2020 18:29:09 +0000 (UTC) Received: from localhost ([::1]:57568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxx0k-0000ZL-TG for larch@yhetil.org; Tue, 21 Jul 2020 14:29:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxx0g-0000XM-Gw for guix-patches@gnu.org; Tue, 21 Jul 2020 14:29:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57041) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jxx0g-0007Pe-8K for guix-patches@gnu.org; Tue, 21 Jul 2020 14:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jxx0g-0005hP-5k for guix-patches@gnu.org; Tue, 21 Jul 2020 14:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42082] [PATCH 1/6] gnu: Add python-covdefaults. Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Jul 2020 18:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42082 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke , 42082@debbugs.gnu.org Received: via spool by 42082-submit@debbugs.gnu.org id=B42082.159535613521895 (code B ref 42082); Tue, 21 Jul 2020 18:29:02 +0000 Received: (at 42082) by debbugs.gnu.org; 21 Jul 2020 18:28:55 +0000 Received: from localhost ([127.0.0.1]:40354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxx0Y-0005h4-PF for submit@debbugs.gnu.org; Tue, 21 Jul 2020 14:28:54 -0400 Received: from mout02.posteo.de ([185.67.36.66]:41079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxx0W-0005gq-3F for 42082@debbugs.gnu.org; Tue, 21 Jul 2020 14:28:53 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 4EFD12400FB for <42082@debbugs.gnu.org>; Tue, 21 Jul 2020 20:28:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1595356126; bh=4grLx/dfzVH+uS2YI7vjbvYCWM0NkhCzTiQhAmSaJ9I=; h=Subject:From:To:Date:From; b=pqBcObJHxIdBumkrknscxLuhhsTuxiXdk7ZBS3kEJh/pJq/fET4blL9R+tl9jo3cy LQkuQf+5xoKEBcN8LKNdsh1HteyGR/TBlWF7qlEWiGwLvzmumA1oFDaIMM3MxRQamb boOVi8Hk1GBM7OyepwFXucDSCU5XyrSLuwFeMCoRJwKqqJzS00ybiFIJc13IIVHmc9 ppydGwztgC6mZTG6wUBPKQx1AXkOJfW0f80aDIRI2ySwyewUPZs6rO7KmRq8PAf3qo e/PQRgI/qyNIaCbXafADuZu621l6syEGK5UPinBnELIDZhRe7nwZwq3X3IS5AKjoAJ YDyQl6sZoB0Nw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BB6YS33FRz9rxS; Tue, 21 Jul 2020 20:28:44 +0200 (CEST) Message-ID: <9787249e066d55ae94bbd08f2c0b9dedfa3137bb.camel@posteo.net> From: Vinicius Monego Date: Tue, 21 Jul 2020 15:28:40 -0300 In-Reply-To: <87365lj3eu.fsf@gnu.org> References: <20200627154645.64264-1-monego@posteo.net> <87365lj3eu.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=posteo.net header.s=2017 header.b=pqBcObJH; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: nkF+1ukKHDG8 Em seg, 2020-07-20 às 23:13 +0200, Marius Bakke escreveu: > Hi Vinicius, Hello Marius, Thanks for the tips! > We now have a 'python-check.scm' which is preferable to > check.scm. Can > you add this library there instead? Sure. I overlooked that file. I sent another series of 6 pytest patches before this, and will send a v2 for that as well. > Should pytest be propagated here? > > Also, as this package is a plugin for coverage, maybe it should not > propagate coverage either. The reason is that propagating prevents > it > from being (easily) used with other versions of coverage. Let's say > that a package needs a newer coverage than the default in Guix + this > plugin, propagation here would bring in the wrong coverage version. Oh, I thought that the pytest binary should be available as an executable for the plugin to be used, similar to how APT has pytest as a dependency for plugins. Maybe it's just me thinking in terms of traditional package management. The PyPI importer will propagate pytest by default, and it's common to see it propagated in other plugins in check.scm. But now I see that many plugins do not propagate it. Should pytest not be an input at all (unless the plugin uses it for its own tests, in which case it should be a native input)? > I know it's a lot to ask :-) but can you try to expand on how it > differs > from the apparently unreasonable defaults in coverage? "Sensible" > also > borders on "marketing speak", perhaps "opinionated" is a better term. That's a slight rewording of the author's description in the repository, and that's the only verbal information I could find about the project. The differences can be seen in the README and in the source code, but I don't know what to write about them, or even why the changes are 'more sensible'.