[bug#42087] [PATCH 6/6] gnu: Add python-pre-commit.

[Vinicius Monego <monego@posteo.net>]

Em seg, 2020-07-20 às 23:36 +0200, Marius Bakke escreveu:

> Do they really require Tox directly?  Tox is fairly redundant in
> Guix,
> as all it does is create an isolated environment for running tests,
> which Guix already does.  So the usual approach is to copy the
> command
> for running tests out of tox.ini and run it directly in the check
> phase.  Is that an option here?

I read CONTRIBUTING.md and those were the instructions. I was running
into weird error messages and assumed the cause was tox not being used.

But, nevermind. It was simply that, like in the previous packages, the
PyPI tarball does not include tests. I downloaded a git checkout and
now the tests are running, though with many deselections.

> Does this program produce a regular executable?  I.e. it's not
> intended
> for use as a library?  In that case you can simply add these as
> regular
> inputs, and the executable will be "wrapped" with the correct
> PYTHONPATH.

That's correct. It provides a regular executable.

> Also, maybe we can omit the python- prefix here too, and perhaps
> place
> it in version-control.scm?

That makes sense to me.

> Can you send a v2 series?

I will bump some versions, enable tests here and send a v2 by the
weekend.