From: Marius Bakke <marius@gnu.org>
To: Vinicius Monego <monego@posteo.net>, 42082@debbugs.gnu.org
Cc: Vinicius Monego <monego@posteo.net>
Subject: [bug#42082] [PATCH 1/6] gnu: Add python-covdefaults.
Date: Mon, 20 Jul 2020 23:13:29 +0200 [thread overview]
Message-ID: <87365lj3eu.fsf@gnu.org> (raw)
In-Reply-To: <20200627154645.64264-1-monego@posteo.net>
[-- Attachment #1: Type: text/plain, Size: 2406 bytes --]
Hi Vinicius,
Sorry for the slow response. The series look great overall, but I have
a few nitpicks. :-)
Vinicius Monego <monego@posteo.net> writes:
> * gnu/packages/check.scm (python-covdefaults): New variable.
We now have a 'python-check.scm' which is preferable to check.scm. Can
you add this library there instead?
Ideally we'd move the current Python test libraries over too, but that's
another issue.
[...]
> +(define-public python-covdefaults
> + (package
> + (name "python-covdefaults")
> + (version "1.1.0")
> + (source
> + (origin
> + ;; The PyPI tarball does not include tests.
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/asottile/covdefaults")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "11a24c0wzv01n55fy4kdpnyqna4m9k0mp58kmhiaks34xw4k37hq"))))
> + (build-system python-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (replace 'check
> + (lambda _
> + (invoke "pytest" "-vv")
> + #t)))))
Note: invoke returns #t on success, so no need for the explicit return
(though it does not hurt).
> + (propagated-inputs
> + `(("python-coverage" ,python-coverage)
> + ("python-pytest" ,python-pytest)))
Should pytest be propagated here?
Also, as this package is a plugin for coverage, maybe it should not
propagate coverage either. The reason is that propagating prevents it
from being (easily) used with other versions of coverage. Let's say
that a package needs a newer coverage than the default in Guix + this
plugin, propagation here would bring in the wrong coverage version.
> + (home-page "https://github.com/asottile/covdefaults")
> + (synopsis "Coverage plugin to provide sensible default settings")
> + (description
> + "Covdefaults is a coverage plugin to provide sensible default settings.")
I know it's a lot to ask :-) but can you try to expand on how it differs
from the apparently unreasonable defaults in coverage? "Sensible" also
borders on "marketing speak", perhaps "opinionated" is a better term.
This was more text than I intended for an otherwise good-looking patch!
Will comment on the others too.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-07-20 21:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-27 15:46 [bug#42082] [PATCH 1/6] gnu: Add python-covdefaults Vinicius Monego
2020-06-27 15:46 ` [bug#42083] [PATCH 2/6] gnu: Add python-cfgv Vinicius Monego
2020-07-20 21:17 ` Marius Bakke
2020-06-27 15:46 ` [bug#42084] [PATCH 3/6] gnu: Add python-identify Vinicius Monego
2020-07-20 21:17 ` Marius Bakke
2020-06-27 15:46 ` [bug#42085] [PATCH 4/6] gnu: Add python-nodeenv Vinicius Monego
2020-07-20 21:25 ` Marius Bakke
2020-07-21 18:42 ` Vinicius Monego
2020-06-27 15:46 ` [bug#42086] [PATCH 5/6] gnu: Add python-pytest-env Vinicius Monego
2020-07-20 21:27 ` Marius Bakke
2020-06-27 15:46 ` [bug#42087] [PATCH 6/6] gnu: Add python-pre-commit Vinicius Monego
2020-07-20 21:36 ` Marius Bakke
2020-07-21 18:57 ` Vinicius Monego
2020-07-20 21:13 ` Marius Bakke [this message]
2020-07-21 18:28 ` [bug#42082] [PATCH 1/6] gnu: Add python-covdefaults Vinicius Monego
2020-07-21 21:48 ` Marius Bakke
2020-07-24 12:01 ` [bug#42082] [PATCH v2 " Vinicius Monego
2020-07-24 12:01 ` [bug#42082] [PATCH v2 2/6] gnu: Add python-cfgv Vinicius Monego
2020-07-24 12:01 ` [bug#42082] [PATCH v2 3/6] gnu: Add python-identify Vinicius Monego
2020-07-25 16:33 ` Marius Bakke
2020-07-24 12:01 ` [bug#42082] [PATCH v2 4/6] gnu: Add python-nodeenv Vinicius Monego
2020-07-24 12:01 ` [bug#42082] [PATCH v2 5/6] gnu: Add python-pytest-env Vinicius Monego
2020-07-24 12:01 ` [bug#42082] [PATCH v2 6/6] gnu: Add python-pre-commit Vinicius Monego
2020-07-25 16:38 ` bug#42082: " Marius Bakke
2020-07-25 2:21 ` [bug#42082] [PATCH 1/6] gnu: Add python-covdefaults Brett Gilio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87365lj3eu.fsf@gnu.org \
--to=marius@gnu.org \
--cc=42082@debbugs.gnu.org \
--cc=monego@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).