unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <marius@gnu.org>
To: Nicolas Graves <ngraves@ngraves.fr>, 55966-done@debbugs.gnu.org
Cc: ngraves@ngraves.fr
Subject: bug#55966: Updated series
Date: Wed, 20 Jul 2022 17:16:48 +0200	[thread overview]
Message-ID: <87zgh3n7a7.fsf@gnu.org> (raw)
In-Reply-To: <875yjsawom.fsf@ngraves.fr>

[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]

Nicolas Graves <ngraves@ngraves.fr> skriver:

> Hi Marius,
>
> Sorry for the time it took me, here's the updated series.

No worries, thanks a lot for this work.

> Everything has been checked with guix lint. I use emacs, but couldn't get guix
> style to work the way you counselled, hope it's ok.

What was the issue?  :-)

I ran 'guix style' for each since I had to edit the commits anyway to
get the author right (for some reason it showed up as "Nicolas Graves
via Guix-patches <guix-patches@gnu.org>" -- NYF!).

> Also thanks for your advice! 

:-)

Some more advice for future pull requests, please first send a message
to 'guix-patches@gnu.org' to get a bug ID assigned (can be anything,
although often a 'git format-patch --cover-letter').  Then send the
patch series to NNNNN@debbugs.gnu.org, otherwise the patches will
be scattered across different issues and difficult to track.

Also, use "-n" with send-email/format-patch so that the ordering is
preserved.  It was lacking in the second series, but I used the
information from the first round to get it right.

Anyway, great work, pushed as c8f33b613e..cda3de3b7d!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  reply	other threads:[~2022-07-20 15:18 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14  9:49 [bug#55958] [PATCH 1/9] gnu: Add node-buffer-crc32 Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55964] [PATCH 2/9] gnu: Add node-yazl Nicolas Graves via Guix-patches via
2022-06-23 20:22   ` Marius Bakke
2022-06-23 22:23   ` Maxime Devos
2022-07-20  9:16   ` [bug#55964] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55961] [PATCH 3/9] gnu: Add node-protocol-buffers-schema Nicolas Graves via Guix-patches via
2022-06-23 20:25   ` Marius Bakke
2022-07-20  9:27   ` [bug#55961] [PATCH] " Nicolas Graves via Guix-patches via
2022-07-20  9:31   ` Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55959] [PATCH 4/9] gnu: Add node-resolve-protobuf-schema Nicolas Graves via Guix-patches via
2022-06-23 20:54   ` Marius Bakke
2022-07-20  9:34   ` [bug#55959] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55960] [PATCH 5/9] gnu: Add node-ieee754 Nicolas Graves via Guix-patches via
2022-06-23 21:07   ` Marius Bakke
2022-07-20 10:11   ` [bug#55960] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55962] [PATCH 6/9] gnu: Add node-pbf Nicolas Graves via Guix-patches via
2022-06-23 21:10   ` Marius Bakke
2022-07-20 10:15   ` [bug#55962] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55963] [PATCH 7/9] gnu: Add node-minimist Nicolas Graves via Guix-patches via
2022-06-23 21:14   ` Marius Bakke
2022-07-20 10:16   ` [bug#55963] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55965] [PATCH 8/9] gnu: Add node-crx3 Nicolas Graves via Guix-patches via
2022-06-23 21:17   ` Marius Bakke
2022-07-20 10:20   ` [bug#55965] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55966] [PATCH 9/9] gnu: chromium extensions lighter make-crx Nicolas Graves via Guix-patches via
2022-06-23 21:20   ` Marius Bakke
2022-06-23 22:28   ` Maxime Devos
2022-07-20 10:39   ` [bug#55966] [PATCH] gnu: modifying make-chromium-extension to rely on node-crx3 Nicolas Graves via Guix-patches via
2022-07-20 10:46   ` [bug#55966] Updated series Nicolas Graves via Guix-patches via
2022-07-20 15:16     ` Marius Bakke [this message]
2022-06-14 10:03 ` [bug#55958] Nicolas Graves via Guix-patches via
2022-06-23 20:07   ` [bug#55958] Marius Bakke
2022-06-23 20:15 ` [bug#55958] [PATCH 1/9] gnu: Add node-buffer-crc32 Marius Bakke
2022-07-19 21:28 ` [bug#55958] [PATCH] " Nicolas Graves via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgh3n7a7.fsf@gnu.org \
    --to=marius@gnu.org \
    --cc=55966-done@debbugs.gnu.org \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).