From: Marius Bakke <marius@gnu.org>
To: 55964@debbugs.gnu.org
Cc: Nicolas Graves <ngraves@ngraves.fr>
Subject: [bug#55964] [PATCH 2/9] gnu: Add node-yazl.
Date: Thu, 23 Jun 2022 22:22:56 +0200 [thread overview]
Message-ID: <87bkujruxr.fsf@gnu.org> (raw)
In-Reply-To: <20220614094954.15197-2-ngraves@ngraves.fr>
[-- Attachment #1: Type: text/plain, Size: 1767 bytes --]
Nicolas Graves via Guix-patches via <guix-patches@gnu.org> skriver:
> * gnu/packages/node-xyz.scm (node-yazl): New variable.
[...]
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/thejoshwolfe/yazl")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1lhwqqnvazpi4xw81ldpx0ky0h1j5rcx3br480q2bnzj21cm109n"))))
Indentation seems off here ('./pre-inst-env guix style node-yazl' can
take care of it if you don't use Emacs).
> + (build-system node-build-system)
> + (arguments
> + '(#:phases
> + (modify-phases %standard-phases
> + (delete 'check)
> + (replace 'configure
> + (lambda* (#:key inputs #:allow-other-keys)
> + (invoke (string-append (assoc-ref inputs "node") "/bin/npm")
> + "--offline" "--ignore-scripts" "install" "--production")
> + #t)))))
Same comments as previous patch.
> + (inputs (list node-buffer-crc32))
> + (home-page "https://github.com/thejoshwolfe/yazl")
> + (synopsis "Yet another zip library for node")
> + (description "This package provides a zip library for Node. It follows the following principles:
Keep lines < 78 characters if possible. Also use two spaces after
punctuation.
'./pre-inst-env guix lint PACKAGE' will warn about this and save review
time. ;-)
> +Don't block the JavaScript thread. Use and provide async APIs.
> +Keep memory usage under control. Don't attempt to buffer entire files in RAM at once.
> +Prefer to open input files one at a time than all at once. ")
Use @enumerate for "bullet lists" which this seems to be.
Otherwise LGTM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
next prev parent reply other threads:[~2022-06-23 20:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 9:49 [bug#55958] [PATCH 1/9] gnu: Add node-buffer-crc32 Nicolas Graves via Guix-patches via
2022-06-14 9:49 ` [bug#55964] [PATCH 2/9] gnu: Add node-yazl Nicolas Graves via Guix-patches via
2022-06-23 20:22 ` Marius Bakke [this message]
2022-06-23 22:23 ` Maxime Devos
2022-07-20 9:16 ` [bug#55964] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14 9:49 ` [bug#55961] [PATCH 3/9] gnu: Add node-protocol-buffers-schema Nicolas Graves via Guix-patches via
2022-06-23 20:25 ` Marius Bakke
2022-07-20 9:27 ` [bug#55961] [PATCH] " Nicolas Graves via Guix-patches via
2022-07-20 9:31 ` Nicolas Graves via Guix-patches via
2022-06-14 9:49 ` [bug#55959] [PATCH 4/9] gnu: Add node-resolve-protobuf-schema Nicolas Graves via Guix-patches via
2022-06-23 20:54 ` Marius Bakke
2022-07-20 9:34 ` [bug#55959] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14 9:49 ` [bug#55960] [PATCH 5/9] gnu: Add node-ieee754 Nicolas Graves via Guix-patches via
2022-06-23 21:07 ` Marius Bakke
2022-07-20 10:11 ` [bug#55960] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14 9:49 ` [bug#55962] [PATCH 6/9] gnu: Add node-pbf Nicolas Graves via Guix-patches via
2022-06-23 21:10 ` Marius Bakke
2022-07-20 10:15 ` [bug#55962] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14 9:49 ` [bug#55963] [PATCH 7/9] gnu: Add node-minimist Nicolas Graves via Guix-patches via
2022-06-23 21:14 ` Marius Bakke
2022-07-20 10:16 ` [bug#55963] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14 9:49 ` [bug#55965] [PATCH 8/9] gnu: Add node-crx3 Nicolas Graves via Guix-patches via
2022-06-23 21:17 ` Marius Bakke
2022-07-20 10:20 ` [bug#55965] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14 9:49 ` [bug#55966] [PATCH 9/9] gnu: chromium extensions lighter make-crx Nicolas Graves via Guix-patches via
2022-06-23 21:20 ` Marius Bakke
2022-06-23 22:28 ` Maxime Devos
2022-07-20 10:39 ` [bug#55966] [PATCH] gnu: modifying make-chromium-extension to rely on node-crx3 Nicolas Graves via Guix-patches via
2022-07-20 10:46 ` [bug#55966] Updated series Nicolas Graves via Guix-patches via
2022-07-20 15:16 ` bug#55966: " Marius Bakke
2022-06-14 10:03 ` [bug#55958] Nicolas Graves via Guix-patches via
2022-06-23 20:07 ` [bug#55958] Marius Bakke
2022-06-23 20:15 ` [bug#55958] [PATCH 1/9] gnu: Add node-buffer-crc32 Marius Bakke
2022-07-19 21:28 ` [bug#55958] [PATCH] " Nicolas Graves via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkujruxr.fsf@gnu.org \
--to=marius@gnu.org \
--cc=55964@debbugs.gnu.org \
--cc=ngraves@ngraves.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).