unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Nicolas Graves <ngraves@ngraves.fr>, 55966@debbugs.gnu.org
Subject: [bug#55966] [PATCH 9/9] gnu: chromium extensions lighter make-crx.
Date: Fri, 24 Jun 2022 00:28:16 +0200	[thread overview]
Message-ID: <e06e02fc7980f2d67048ec9fda1ab191618d42f4.camel@telenet.be> (raw)
In-Reply-To: <20220614094954.15197-9-ngraves@ngraves.fr>

[-- Attachment #1: Type: text/plain, Size: 798 bytes --]

Nicolas Graves via Guix-patches via schreef op di 14-06-2022 om 11:49
[+0200]:
> -         (let ((chromium #$(file-append ungoogled-chromium "/bin/chromium"))
> -               (xvfb #$(file-append xorg-server "/bin/Xvfb"))
> +         (let ((crx3 #$(file-append node-crx3 "/bin/crx3"))
>                 (packdir (string-append (getcwd) "/extension")))

You're invoking crx3 below, so it shouldn't be cross-compiled even if
the extension is cross-compiled, hence the #$(file-append node-crx3
...) should probably be #+(file-append node-crx ...) instead.

(Also was an issue in the old code that used chromium and xorg-server
..., and probably the chromium build system doesn't implement cross-
compilation yet ...)

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2022-06-23 22:29 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14  9:49 [bug#55958] [PATCH 1/9] gnu: Add node-buffer-crc32 Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55964] [PATCH 2/9] gnu: Add node-yazl Nicolas Graves via Guix-patches via
2022-06-23 20:22   ` Marius Bakke
2022-06-23 22:23   ` Maxime Devos
2022-07-20  9:16   ` [bug#55964] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55961] [PATCH 3/9] gnu: Add node-protocol-buffers-schema Nicolas Graves via Guix-patches via
2022-06-23 20:25   ` Marius Bakke
2022-07-20  9:27   ` [bug#55961] [PATCH] " Nicolas Graves via Guix-patches via
2022-07-20  9:31   ` Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55959] [PATCH 4/9] gnu: Add node-resolve-protobuf-schema Nicolas Graves via Guix-patches via
2022-06-23 20:54   ` Marius Bakke
2022-07-20  9:34   ` [bug#55959] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55960] [PATCH 5/9] gnu: Add node-ieee754 Nicolas Graves via Guix-patches via
2022-06-23 21:07   ` Marius Bakke
2022-07-20 10:11   ` [bug#55960] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55962] [PATCH 6/9] gnu: Add node-pbf Nicolas Graves via Guix-patches via
2022-06-23 21:10   ` Marius Bakke
2022-07-20 10:15   ` [bug#55962] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55963] [PATCH 7/9] gnu: Add node-minimist Nicolas Graves via Guix-patches via
2022-06-23 21:14   ` Marius Bakke
2022-07-20 10:16   ` [bug#55963] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55965] [PATCH 8/9] gnu: Add node-crx3 Nicolas Graves via Guix-patches via
2022-06-23 21:17   ` Marius Bakke
2022-07-20 10:20   ` [bug#55965] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55966] [PATCH 9/9] gnu: chromium extensions lighter make-crx Nicolas Graves via Guix-patches via
2022-06-23 21:20   ` Marius Bakke
2022-06-23 22:28   ` Maxime Devos [this message]
2022-07-20 10:39   ` [bug#55966] [PATCH] gnu: modifying make-chromium-extension to rely on node-crx3 Nicolas Graves via Guix-patches via
2022-07-20 10:46   ` [bug#55966] Updated series Nicolas Graves via Guix-patches via
2022-07-20 15:16     ` bug#55966: " Marius Bakke
2022-06-14 10:03 ` [bug#55958] Nicolas Graves via Guix-patches via
2022-06-23 20:07   ` [bug#55958] Marius Bakke
2022-06-23 20:15 ` [bug#55958] [PATCH 1/9] gnu: Add node-buffer-crc32 Marius Bakke
2022-07-19 21:28 ` [bug#55958] [PATCH] " Nicolas Graves via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e06e02fc7980f2d67048ec9fda1ab191618d42f4.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=55966@debbugs.gnu.org \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).