unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Graves via Guix-patches via <guix-patches@gnu.org>
To: 55966@debbugs.gnu.org
Cc: Nicolas Graves <ngraves@ngraves.fr>
Subject: [bug#55966] [PATCH 9/9] gnu: chromium extensions lighter make-crx.
Date: Tue, 14 Jun 2022 11:49:54 +0200	[thread overview]
Message-ID: <20220614094954.15197-9-ngraves@ngraves.fr> (raw)
In-Reply-To: <20220614094954.15197-1-ngraves@ngraves.fr>

---
 gnu/build/chromium-extension.scm | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/gnu/build/chromium-extension.scm b/gnu/build/chromium-extension.scm
index 8ca5251957..8d52153751 100644
--- a/gnu/build/chromium-extension.scm
+++ b/gnu/build/chromium-extension.scm
@@ -19,10 +19,9 @@
 (define-module (gnu build chromium-extension)
   #:use-module (guix gexp)
   #:use-module (guix packages)
-  #:use-module (gnu packages chromium)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages tls)
-  #:use-module (gnu packages xorg)
+  #:use-module (gnu packages node-xyz)
   #:use-module (guix build-system trivial)
   #:export (make-chromium-extension))
 
@@ -69,24 +68,14 @@ (define version (package-version package))
    (string-append name "-" version ".crx")
    (with-imported-modules '((guix build utils))
      #~(begin
-         ;; This is not great.  We pull Xorg and Chromium just to Zip and
-         ;; sign an extension.  This should be implemented with something
-         ;; lighter.  (TODO: where is the CRXv3 documentation..?)
          (use-modules (guix build utils))
-         (let ((chromium #$(file-append ungoogled-chromium "/bin/chromium"))
-               (xvfb #$(file-append xorg-server "/bin/Xvfb"))
+         (let ((crx3 #$(file-append node-crx3 "/bin/crx3"))
                (packdir (string-append (getcwd) "/extension")))
            (mkdir packdir)
            (copy-recursively (ungexp package package-output) packdir
                              ;; Ensure consistent file modification times.
                              #:keep-mtime? #t)
-           (system (string-append xvfb " :1 &"))
-           (setenv "DISPLAY" ":1")
-           (sleep 2)                    ;give Xorg some time to initialize...
-           (invoke chromium
-                   "--user-data-dir=chromium-profile"
-                   (string-append "--pack-extension=" packdir)
-                   (string-append "--pack-extension-key=" #$signing-key))
+           (invoke crx3 "--keyPath" #$signing-key packdir)
            (copy-file (string-append packdir ".crx") #$output))))
    #:local-build? #t))
 
-- 
2.36.1





  parent reply	other threads:[~2022-06-14  9:59 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14  9:49 [bug#55958] [PATCH 1/9] gnu: Add node-buffer-crc32 Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55964] [PATCH 2/9] gnu: Add node-yazl Nicolas Graves via Guix-patches via
2022-06-23 20:22   ` Marius Bakke
2022-06-23 22:23   ` Maxime Devos
2022-07-20  9:16   ` [bug#55964] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55961] [PATCH 3/9] gnu: Add node-protocol-buffers-schema Nicolas Graves via Guix-patches via
2022-06-23 20:25   ` Marius Bakke
2022-07-20  9:27   ` [bug#55961] [PATCH] " Nicolas Graves via Guix-patches via
2022-07-20  9:31   ` Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55959] [PATCH 4/9] gnu: Add node-resolve-protobuf-schema Nicolas Graves via Guix-patches via
2022-06-23 20:54   ` Marius Bakke
2022-07-20  9:34   ` [bug#55959] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55960] [PATCH 5/9] gnu: Add node-ieee754 Nicolas Graves via Guix-patches via
2022-06-23 21:07   ` Marius Bakke
2022-07-20 10:11   ` [bug#55960] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55962] [PATCH 6/9] gnu: Add node-pbf Nicolas Graves via Guix-patches via
2022-06-23 21:10   ` Marius Bakke
2022-07-20 10:15   ` [bug#55962] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55963] [PATCH 7/9] gnu: Add node-minimist Nicolas Graves via Guix-patches via
2022-06-23 21:14   ` Marius Bakke
2022-07-20 10:16   ` [bug#55963] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` [bug#55965] [PATCH 8/9] gnu: Add node-crx3 Nicolas Graves via Guix-patches via
2022-06-23 21:17   ` Marius Bakke
2022-07-20 10:20   ` [bug#55965] [PATCH] " Nicolas Graves via Guix-patches via
2022-06-14  9:49 ` Nicolas Graves via Guix-patches via [this message]
2022-06-23 21:20   ` [bug#55966] [PATCH 9/9] gnu: chromium extensions lighter make-crx Marius Bakke
2022-06-23 22:28   ` Maxime Devos
2022-07-20 10:39   ` [bug#55966] [PATCH] gnu: modifying make-chromium-extension to rely on node-crx3 Nicolas Graves via Guix-patches via
2022-07-20 10:46   ` [bug#55966] Updated series Nicolas Graves via Guix-patches via
2022-07-20 15:16     ` bug#55966: " Marius Bakke
2022-06-14 10:03 ` [bug#55958] Nicolas Graves via Guix-patches via
2022-06-23 20:07   ` [bug#55958] Marius Bakke
2022-06-23 20:15 ` [bug#55958] [PATCH 1/9] gnu: Add node-buffer-crc32 Marius Bakke
2022-07-19 21:28 ` [bug#55958] [PATCH] " Nicolas Graves via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220614094954.15197-9-ngraves@ngraves.fr \
    --to=guix-patches@gnu.org \
    --cc=55966@debbugs.gnu.org \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).