* [bug#70249] [PATCH] gnu: open-ssh-session: Don’t require public key.
@ 2024-04-06 23:17 Ian Eure
2024-04-07 19:32 ` bug#70249: " Christopher Baines
0 siblings, 1 reply; 2+ messages in thread
From: Ian Eure @ 2024-04-06 23:17 UTC (permalink / raw)
To: 70249
Cc: Ian Eure, Christopher Baines, Josselin Poiret,
Ludovic Courtès, Mathieu Othacehe, Ricardo Wurmus,
Simon Tournier, Tobias Geerinckx-Rice
* guix/scripts/offload.scm (open-ssh-session): Delete `public' binding.
Public keys aren’t required for client connections, and this binding is
unused. The behavior of assuming a ".pub"-suffixed file exists in the same
directory as the secret key is undocumented and surprising.
Change-Id: I9b532be2abe68dae0323e4ef6e1ceab1e5603359
---
guix/scripts/offload.scm | 3 ---
1 file changed, 3 deletions(-)
diff --git a/guix/scripts/offload.scm b/guix/scripts/offload.scm
index 137e3b5fe3..93e9d3759c 100644
--- a/guix/scripts/offload.scm
+++ b/guix/scripts/offload.scm
@@ -213,9 +213,6 @@ (define* (open-ssh-session machine #:optional max-silent-time)
When MAX-SILENT-TIME is true, it must be a positive integer denoting the
number of seconds after which the connection times out."
(let ((private (private-key-from-file* (build-machine-private-key machine)))
- (public (public-key-from-file
- (string-append (build-machine-private-key machine)
- ".pub")))
(session (make-session #:user (build-machine-user machine)
#:host (build-machine-name machine)
#:port (build-machine-port machine)
base-commit: ab3731d255ff1ac8d6874bc0f68ad94f21f08e79
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#70249: [PATCH] gnu: open-ssh-session: Don’t require public key.
2024-04-06 23:17 [bug#70249] [PATCH] gnu: open-ssh-session: Don’t require public key Ian Eure
@ 2024-04-07 19:32 ` Christopher Baines
0 siblings, 0 replies; 2+ messages in thread
From: Christopher Baines @ 2024-04-07 19:32 UTC (permalink / raw)
To: Ian Eure
Cc: Josselin Poiret, Simon Tournier, Mathieu Othacehe,
Ludovic Courtès, Tobias Geerinckx-Rice, Ricardo Wurmus,
70249-done, Christopher Baines
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
Ian Eure <ian@retrospec.tv> writes:
> * guix/scripts/offload.scm (open-ssh-session): Delete `public' binding.
> Public keys aren’t required for client connections, and this binding is
> unused. The behavior of assuming a ".pub"-suffixed file exists in the same
> directory as the secret key is undocumented and surprising.
>
> Change-Id: I9b532be2abe68dae0323e4ef6e1ceab1e5603359
> ---
> guix/scripts/offload.scm | 3 ---
> 1 file changed, 3 deletions(-)
I can't see how this binding is used either, so I've pushed this to
master as 298aed72a2a76be33f9a55bed22636acd7a4f9b9.
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-07 19:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-06 23:17 [bug#70249] [PATCH] gnu: open-ssh-session: Don’t require public key Ian Eure
2024-04-07 19:32 ` bug#70249: " Christopher Baines
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).