unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Ian Eure <ian@retrospec.tv>
Cc: "Josselin Poiret" <dev@jpoiret.xyz>,
	"Simon Tournier" <zimon.toutoune@gmail.com>,
	"Mathieu Othacehe" <othacehe@gnu.org>,
	"Ludovic Courtès" <ludo@gnu.org>,
	"Tobias Geerinckx-Rice" <me@tobias.gr>,
	"Ricardo Wurmus" <rekado@elephly.net>,
	70249-done@debbugs.gnu.org,
	"Christopher Baines" <guix@cbaines.net>
Subject: bug#70249: [PATCH] gnu: open-ssh-session: Don’t require public key.
Date: Sun, 07 Apr 2024 20:32:55 +0100	[thread overview]
Message-ID: <87zfu5dl3s.fsf@cbaines.net> (raw)
In-Reply-To: <b26edae0cd07082f812c6ab65d934ece9d0d3a4f.1712445373.git.ian@retrospec.tv> (Ian Eure's message of "Sat, 6 Apr 2024 16:17:06 -0700")

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Ian Eure <ian@retrospec.tv> writes:

> * guix/scripts/offload.scm (open-ssh-session): Delete `public' binding.
> Public keys aren’t required for client connections, and this binding is
> unused.  The behavior of assuming a ".pub"-suffixed file exists in the same
> directory as the secret key is undocumented and surprising.
>
> Change-Id: I9b532be2abe68dae0323e4ef6e1ceab1e5603359
> ---
>  guix/scripts/offload.scm | 3 ---
>  1 file changed, 3 deletions(-)

I can't see how this binding is used either, so I've pushed this to
master as 298aed72a2a76be33f9a55bed22636acd7a4f9b9.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

      reply	other threads:[~2024-04-07 19:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-06 23:17 [bug#70249] [PATCH] gnu: open-ssh-session: Don’t require public key Ian Eure
2024-04-07 19:32 ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfu5dl3s.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=70249-done@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    --cc=guix@cbaines.net \
    --cc=ian@retrospec.tv \
    --cc=ludo@gnu.org \
    --cc=me@tobias.gr \
    --cc=othacehe@gnu.org \
    --cc=rekado@elephly.net \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).