From: Ian Eure <ian@retrospec.tv>
To: 70249@debbugs.gnu.org
Cc: "Ian Eure" <ian@retrospec.tv>,
"Christopher Baines" <guix@cbaines.net>,
"Josselin Poiret" <dev@jpoiret.xyz>,
"Ludovic Courtès" <ludo@gnu.org>,
"Mathieu Othacehe" <othacehe@gnu.org>,
"Ricardo Wurmus" <rekado@elephly.net>,
"Simon Tournier" <zimon.toutoune@gmail.com>,
"Tobias Geerinckx-Rice" <me@tobias.gr>
Subject: [bug#70249] [PATCH] gnu: open-ssh-session: Don’t require public key.
Date: Sat, 6 Apr 2024 16:17:06 -0700 [thread overview]
Message-ID: <b26edae0cd07082f812c6ab65d934ece9d0d3a4f.1712445373.git.ian@retrospec.tv> (raw)
* guix/scripts/offload.scm (open-ssh-session): Delete `public' binding.
Public keys aren’t required for client connections, and this binding is
unused. The behavior of assuming a ".pub"-suffixed file exists in the same
directory as the secret key is undocumented and surprising.
Change-Id: I9b532be2abe68dae0323e4ef6e1ceab1e5603359
---
guix/scripts/offload.scm | 3 ---
1 file changed, 3 deletions(-)
diff --git a/guix/scripts/offload.scm b/guix/scripts/offload.scm
index 137e3b5fe3..93e9d3759c 100644
--- a/guix/scripts/offload.scm
+++ b/guix/scripts/offload.scm
@@ -213,9 +213,6 @@ (define* (open-ssh-session machine #:optional max-silent-time)
When MAX-SILENT-TIME is true, it must be a positive integer denoting the
number of seconds after which the connection times out."
(let ((private (private-key-from-file* (build-machine-private-key machine)))
- (public (public-key-from-file
- (string-append (build-machine-private-key machine)
- ".pub")))
(session (make-session #:user (build-machine-user machine)
#:host (build-machine-name machine)
#:port (build-machine-port machine)
base-commit: ab3731d255ff1ac8d6874bc0f68ad94f21f08e79
--
2.41.0
next reply other threads:[~2024-04-06 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 23:17 Ian Eure [this message]
2024-04-07 19:32 ` bug#70249: [PATCH] gnu: open-ssh-session: Don’t require public key Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b26edae0cd07082f812c6ab65d934ece9d0d3a4f.1712445373.git.ian@retrospec.tv \
--to=ian@retrospec.tv \
--cc=70249@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=guix@cbaines.net \
--cc=ludo@gnu.org \
--cc=me@tobias.gr \
--cc=othacehe@gnu.org \
--cc=rekado@elephly.net \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).