[bug#39457] Fix baud-rate option in inputattach-service

[bug#39457] Fix baud-rate option in inputattach-service

[Tim Gesthuizen via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

Hi,

the "baud-rate" option for inputattach-service is broken, the
inputattach program expects the option to be named just "--baud".
The attached patch fixes the issue.

Just out of interest: Should we stick in Guix to the option used by the
program or stick with the old name?
I would like to keep the "baud-rate" name as it is the thing the
parameter configures: The baud-rate for the connection.

Tim.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-services-inputattach-Fix-broken-baud-rate-option.patch --]
[-- Type: text/x-patch, Size: 1037 bytes --]

From 223608191ba3587b1e9f1e1257d482dc89c59709 Mon Sep 17 00:00:00 2001
From: Tim Gesthuizen <tim.gesthuizen@yahoo.de>
Date: Thu, 6 Feb 2020 19:26:03 +0100
Subject: [PATCH] services: inputattach: Fix broken baud rate option

* gnu/services/desktop.scm (inputattach-shepherd-service): Use "--baud" for
  setting the baud-rate.
---
 gnu/services/desktop.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm
index 9dcdf38be1..1294d748ac 100644
--- a/gnu/services/desktop.scm
+++ b/gnu/services/desktop.scm
@@ -1070,7 +1070,7 @@ as expected.")))
   (match-lambda
     (($ <inputattach-configuration> type device baud-rate log-file)
      (let ((args (append (if baud-rate
-                             (list "--baud-rate" (number->string baud-rate))
+                             (list "--baud" (number->string baud-rate))
                              '())
                          (list (string-append "--" type)
                                device))))
-- 
2.25.0

bug#39457: Fix baud-rate option in inputattach-service

[宋文武]

Tim Gesthuizen <tim.gesthuizen@yahoo.de> writes:

> Hi,
>
> the "baud-rate" option for inputattach-service is broken, the
> inputattach program expects the option to be named just "--baud".
> The attached patch fixes the issue.

Pushed, thank you!

>
> Just out of interest: Should we stick in Guix to the option used by the
> program or stick with the old name?
> I would like to keep the "baud-rate" name as it is the thing the
> parameter configures: The baud-rate for the connection.
>

I think both are fine, as we document it in our info manual.

:)