From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:35674) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izm2N-00084g-NG for guix-patches@gnu.org; Thu, 06 Feb 2020 13:38:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1izm2M-0005Y2-Hz for guix-patches@gnu.org; Thu, 06 Feb 2020 13:38:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42490) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1izm2M-0005X7-DG for guix-patches@gnu.org; Thu, 06 Feb 2020 13:38:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1izm2M-0000ys-At for guix-patches@gnu.org; Thu, 06 Feb 2020 13:38:02 -0500 Subject: [bug#39457] Fix baud-rate option in inputattach-service Resent-Message-ID: Received: from eggs.gnu.org ([2001:470:142:3::10]:35469) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izm20-0007RN-UT for guix-patches@gnu.org; Thu, 06 Feb 2020 13:37:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1izm1z-00046J-72 for guix-patches@gnu.org; Thu, 06 Feb 2020 13:37:40 -0500 Received: from sonic311-31.consmr.mail.ir2.yahoo.com ([77.238.176.163]:37238) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1izm1y-0003sw-Gx for guix-patches@gnu.org; Thu, 06 Feb 2020 13:37:39 -0500 Date: Thu, 06 Feb 2020 19:37:32 +0100 Message-ID: <87r1z7o93n.fsf@yahoo.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" References: <87r1z7o93n.fsf.ref@yahoo.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Reply-to: Tim Gesthuizen , Tim Gesthuizen via Guix-patches From: Tim Gesthuizen via Guix-patches via To: 39457@debbugs.gnu.org Cc: Raghav Gururajan --=-=-= Content-Type: text/plain Hi, the "baud-rate" option for inputattach-service is broken, the inputattach program expects the option to be named just "--baud". The attached patch fixes the issue. Just out of interest: Should we stick in Guix to the option used by the program or stick with the old name? I would like to keep the "baud-rate" name as it is the thing the parameter configures: The baud-rate for the connection. Tim. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-services-inputattach-Fix-broken-baud-rate-option.patch >From 223608191ba3587b1e9f1e1257d482dc89c59709 Mon Sep 17 00:00:00 2001 From: Tim Gesthuizen Date: Thu, 6 Feb 2020 19:26:03 +0100 Subject: [PATCH] services: inputattach: Fix broken baud rate option * gnu/services/desktop.scm (inputattach-shepherd-service): Use "--baud" for setting the baud-rate. --- gnu/services/desktop.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/services/desktop.scm b/gnu/services/desktop.scm index 9dcdf38be1..1294d748ac 100644 --- a/gnu/services/desktop.scm +++ b/gnu/services/desktop.scm @@ -1070,7 +1070,7 @@ as expected."))) (match-lambda (($ type device baud-rate log-file) (let ((args (append (if baud-rate - (list "--baud-rate" (number->string baud-rate)) + (list "--baud" (number->string baud-rate)) '()) (list (string-append "--" type) device)))) -- 2.25.0 --=-=-=--