From: Xinglu Chen <public@yoctocell.xyz>
To: jgart <jgart@dismail.de>, 47852@debbugs.gnu.org
Cc: Raghav Gururajan <rg@raghavgururajan.name>,
jackhill@jackhill.us, raghavgururajan@disroot.org,
Oliver Loaiza <olv345@hotmail.com>,
hello@elenq.tech
Subject: [bug#47852] [PATCH] gnu: Add sc-im
Date: Sun, 18 Apr 2021 11:25:28 +0200 [thread overview]
Message-ID: <87r1j8djw7.fsf@yoctocell.xyz> (raw)
In-Reply-To: <9635b393f2e4e1787a99c8f6ee2d3c43@dismail.de>
Thank you for working on this! I have some comments to add.
> * gnu/packages/visidata.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
I suggest adding it to (gnu packages terminals) instead of creating a
new file. You will find asciinema and fzf there.
> +(define-public sc-im
> + (let ((commit-ref "75ae3806844821cba1b2e3fdb9237d737944e850"))
> + (package
> + (name "sc-im")
> + (version "0.8.1")
> + (source (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/andmarti1424/sc-im")
> + (commit commit-ref)))
Why not just use ‘version’, or (string-append ... version) if needed?
> + (file-name (git-file-name name version))
Indentation is a bit off here.
> + (synopsis "Spreadsheet program with vim-like keybindings")
> + (description
> + "@code{sc-im} is a highly configurable spreadsheet program
> + providing a vim-like experience. @code{sc-im} supports @{gnuplot} interaction,
> + functions for sorting and filtering, 256 color support, and much more.")
> + (home-page "https://github.com/andmarti1424/sc-im")
Nit: ‘home-page’ usually goes above ‘synopsis’.
next prev parent reply other threads:[~2021-04-18 9:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-17 21:52 [bug#47852] [PATCH] gnu: Add sc-im jgart via Guix-patches via
2021-04-17 22:22 ` ElenQ Technology
2021-04-17 23:29 ` Jack Hill
2021-04-17 23:54 ` jgart via Guix-patches via
2021-04-18 0:32 ` jgart via Guix-patches via
2021-04-18 9:25 ` Xinglu Chen [this message]
2021-04-18 15:39 ` jgart via Guix-patches via
2021-04-18 16:40 ` Xinglu Chen
2021-04-18 16:57 ` jgart via Guix-patches via
2021-04-19 15:33 ` Xinglu Chen
2021-04-19 16:46 ` jgart via Guix-patches via
2021-04-19 21:48 ` Ekaitz Zarraga
2021-04-20 4:57 ` Leo Famulari
2021-04-22 19:56 ` jgart via Guix-patches via
2021-04-23 9:22 ` jgart via Guix-patches via
2021-04-23 16:41 ` Leo Famulari
2021-04-20 5:00 ` Leo Famulari
2021-11-19 1:22 ` [bug#47852] [PATCH 1/2 v6] " jgart via Guix-patches via
2021-11-19 1:22 ` [bug#47852] [PATCH 2/2] gnu: Move visidata to (gnu packages spreadsheet-apps) jgart via Guix-patches via
2021-11-22 21:20 ` [bug#47852] [PATCH 1/2 v6] gnu: Add sc-im Leo Famulari
2021-11-22 23:23 ` jgart via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1j8djw7.fsf@yoctocell.xyz \
--to=public@yoctocell.xyz \
--cc=47852@debbugs.gnu.org \
--cc=hello@elenq.tech \
--cc=jackhill@jackhill.us \
--cc=jgart@dismail.de \
--cc=olv345@hotmail.com \
--cc=raghavgururajan@disroot.org \
--cc=rg@raghavgururajan.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).