[bug#47852] [PATCH] gnu: Add sc-im

[jgart via Guix-patches via <guix-patches@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 4014 bytes --]

I attached an updated patch also including Jack's suggestions.

Thank you Raghav for help with sanity debugging over xmpp.

prefix is not PREFIX ;)

all the best,

jgart

April 17, 2021 7:54 PM, "jgart" <jgart@dismail.de> wrote:

> Attached is the updated patch with Ekaitz's suggestions. The linter is now a happy gnu!
> 
>> Also I wouldn't add the whole package in an independent file.
>> It may fit better in other of the categories.
> 
> I thought of that but I couldn't find a place I was happy with.
> 
> calcurse and visidata are two other packages that also have their own file.
> 
> Maybe these two packages can be merged in the future with sc-im?
> 
>> I'm not sure about all the compile flags
>> you set, you may be missing some interesting plugin support.
> 
> I left lua support out since that is an optional feature.
> 
> The sc-im package in nixpkgs also leaves it out:
> 
> https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/applications/misc/sc-im/default.nix#L35
> 
> I'm waiting until sc-im has guile support. ;)
> 
> Let me know if there are any other compiler features you think should be included.
> 
> I left tmux as the clipboard. It is already set in the Makefile by default.
> 
> I'll probably inherit from this package and substitute* for xclip instead, locally.
> 
> Does upstream guix prefer two versions of this package (A version compiled with tmux support and a
> version compiled with xclip support)?
> 
> all the best,
> 
> jgart
> 
> ps
> 
> Ekaitz, Saludos desde Miami!
> 
> Vas a venir a el guix meetup el próximo sábado? Cambié la hora a una hora normal ;)
> 
> https://events.nixnet.services/events/27955ca1-0aee-4ec5-be20-48e6c45fd0f6
> 
> April 17, 2021 6:22 PM, "ElenQ Technology" <hello@elenq.tech> wrote:
> 
>> Hey!
>> 
>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>> On Saturday, April 17, 2021 11:52 PM, jgart <jgart@dismail.de> wrote:
>> 
>>> Hi Guix!
>>> 
>>> Attached is a patch for sc-im, a terminal based spreadsheet program providing a vim-like
>>> experience.
>>> 
>>> I constructed this package starting from a template provided by Ekaitz that I found below dating
>>> from over a year ago:
>>> 
>>> https://gitlab.com/ekaitz-zarraga/guix-packages/-/blob/master/sc-im.scm
>>> 
>>> I added Ekaitz as a co-author and added both of our copyrights to the top of the file.
>>> 
>>> This new version of sc-im is from 16 days ago.
>>> 
>>> I'm currently getting the following two linter warnings:
>>> 
>>> the source file name should contain the package name
>>> permanent redirect from https://github.com/andmarti1424/sc-im.git to
>>> https://github.com/andmarti1424/sc-im
>>> 
>>> Any suggestions for what I need to adjust to make those pass?
>>> 
>>> best regards,
>>> 
>>> jgart
>> 
>> I didn't expect this!
>> 
>> My original package was broken, but I left it in my repo so IDK
>> if taking that as a base was a good idea.
>> I was trying to package a more complete solution and I left
>> the package broken...
>> 
>> I'm taking a look to it.
>> 
>> The first issue related with the name of the package is this:
>> 
>> ```
>> guix/gnu/packages/sc-im.scm:41:14: sc-im@0.8.1: the source file name should contain the package
>> name
>> ```
>> 
>> In order to solve this you can use this in the origin desc:
>> 
>> ```
>> (file-name (git-file-name name version))
>> ```
>> 
>> This is going to clone the repo to an specific filename that
>> matches Guix's naming style and it's going to remove the
>> warning.
>> 
>> The second:
>> 
>> ```
>> gnu/packages/sc-im.scm:41:14: sc-im@0.8.1: permanent redirect from
>> https://github.com/andmarti1424/sc-im.git to https://github.com/andmarti1424/sc-im
>> ```
>> 
>> Just change the url by the other and you're done.
>> 
>> HTH!
>> 
>> Thanks for keeping my name there, but you can clear it with
>> no issue, this is all your merit, my man.
>> 
>> Best,
>> Ekaitz

[-- Attachment #2: 0001-gnu-Add-sc-im.patch --]
[-- Type: application/octet-stream, Size: 4378 bytes --]

From aa1c940ebe14b6d3999f6cb57fc42b98d5b0cb3d Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Sat, 17 Apr 2021 17:43:16 -0400
Subject: [PATCH] gnu: Add sc-im.

    * gnu/packages/visidata.scm: New file.
    * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

    Co-authored-by: Ekaitz Zarraga <ekaitz@elenq.tech>
---
 gnu/local.mk           |  1 +
 gnu/packages/sc-im.scm | 82 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 83 insertions(+)
 create mode 100644 gnu/packages/sc-im.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 50b11a8ca2..ade8b400d0 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -496,6 +496,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/sawfish.scm			\
   %D%/packages/scanner.scm			\
   %D%/packages/scheme.scm			\
+  %D%/packages/sc-im.scm			\
   %D%/packages/screen.scm			\
   %D%/packages/scribus.scm			\
   %D%/packages/scsi.scm				\
diff --git a/gnu/packages/sc-im.scm b/gnu/packages/sc-im.scm
new file mode 100644
index 0000000000..8ff482365d
--- /dev/null
+++ b/gnu/packages/sc-im.scm
@@ -0,0 +1,82 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2020 Ekaitz Zarraga <ekaitz@elenq.tech>
+;;; Copyright © 2021 jgart <jgart@dismail.de>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages sc-im)
+  #:use-module (guix packages)
+  #:use-module (guix git-download)
+  #:use-module (guix download)
+  #:use-module (guix utils)
+  #:use-module (guix build-system gnu)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages base)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages maths)
+  #:use-module (gnu packages statistics)
+  #:use-module (gnu packages xml)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages bison)
+  #:use-module (gnu packages ncurses))
+
+(define-public sc-im
+  (let ((commit-ref "75ae3806844821cba1b2e3fdb9237d737944e850"))
+    (package
+      (name "sc-im")
+      (version "0.8.1")
+      (source (origin
+                (method git-fetch)
+                (uri
+                  (git-reference
+                    (url "https://github.com/andmarti1424/sc-im")
+                    (commit commit-ref)))
+                    (file-name (git-file-name name version))
+                (sha256
+                  (base32
+                    "1i1yq5mh9d7yi1bkgaq4p1lr8zrxhlvqmjnj33wmg5v6vpfim1h0"))))
+      (build-system gnu-build-system)
+      (arguments
+        ;; There are no tests at the moment.
+        ;; https://github.com/andmarti1424/sc-im/issues/537
+        ;; https://github.com/andmarti1424/sc-im/pull/385
+        `(#:tests? #f
+          #:make-flags (list "-C" "src"
+                          (string-append "CC=" ,(cc-for-target))
+                          (string-append "prefix=" %output))
+          #:phases
+            (modify-phases
+               %standard-phases
+                 (delete 'configure))))
+      (inputs
+        `(("gnuplot" ,gnuplot)
+          ("libxls" ,libxls)
+          ("libxlsxwriter" ,libxlsxwriter)
+          ("libxml2" ,libxml2)
+          ("libzip" ,libzip)
+          ("ncurses" ,ncurses)))
+      (native-inputs
+        `(("pkg-config" ,pkg-config)
+          ("which" ,which)
+          ("bison" ,bison)))
+      (synopsis "Spreadsheet program with vim-like keybindings")
+      (description
+ "@code{sc-im} is a highly configurable spreadsheet program
+ providing a vim-like experience.  @code{sc-im} supports @{gnuplot} interaction,
+ functions for sorting and filtering, 256 color support, and much more.")
+      (home-page "https://github.com/andmarti1424/sc-im")
+      (license license:bsd-4))))
-- 
2.29.3