unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ElenQ Technology <hello@elenq.tech>
To: jgart <jgart@dismail.de>
Cc: rg@raghavgururajan.name, olv345@hotmail.com,
	47852@debbugs.gnu.org, raghavgururajan@disroot.org
Subject: [bug#47852] [PATCH] gnu: Add sc-im
Date: Sat, 17 Apr 2021 22:22:26 +0000	[thread overview]
Message-ID: <CTPlfV7cgzOy1zPWttP-JOHAXWXOuqvzant3dNABlA1Llhq1PLctYr2dBcu_dw7Sa4_i07lLE6ePbQ4SqTyeOYY1T3KTeW57ejqk9c1EGyE=@elenq.tech> (raw)
In-Reply-To: <15c0925b25d9950553a55a4881922cc4@dismail.de>

Hey!

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Saturday, April 17, 2021 11:52 PM, jgart <jgart@dismail.de> wrote:

> Hi Guix!
>
> Attached is a patch for sc-im, a terminal based spreadsheet program providing a vim-like experience.
>
> I constructed this package starting from a template provided by Ekaitz that I found below dating from over a year ago:
>
> https://gitlab.com/ekaitz-zarraga/guix-packages/-/blob/master/sc-im.scm
>
> I added Ekaitz as a co-author and added both of our copyrights to the top of the file.
>
> This new version of sc-im is from 16 days ago.
>
> I'm currently getting the following two linter warnings:
>
> the source file name should contain the package name
> permanent redirect from https://github.com/andmarti1424/sc-im.git to https://github.com/andmarti1424/sc-im
>
> Any suggestions for what I need to adjust to make those pass?
>
> best regards,
>
> jgart


I didn't expect this!

My original package was broken, but I left it in my repo so IDK
if taking that as a base was a good idea.
I was trying to package a more complete solution and I left
the package broken... I'm not sure about all the compile flags
you set, you may be missing some interesting plugin support.

I'm taking a look to it.

The first issue related with the name of the package is this:

```
guix/gnu/packages/sc-im.scm:41:14: sc-im@0.8.1: the source file name should contain the package name
```

In order to solve this you can use this in the origin desc:

```
        (file-name (git-file-name name version))
```

This is going to clone the repo to an specific filename that
matches Guix's naming style and it's going to remove the
warning.

The second:

```
gnu/packages/sc-im.scm:41:14: sc-im@0.8.1: permanent redirect from https://github.com/andmarti1424/sc-im.git to https://github.com/andmarti1424/sc-im
```

Just change the url by the other and you're done.

Also I wouldn't add the whole package in an independent file.
It may fit better in other of the categories.

HTH!

Thanks for keeping my name there, but you can clear it with
no issue, this is all your merit, my man.

Best,
Ekaitz




  reply	other threads:[~2021-04-18  1:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-17 21:52 [bug#47852] [PATCH] gnu: Add sc-im jgart via Guix-patches via
2021-04-17 22:22 ` ElenQ Technology [this message]
2021-04-17 23:29 ` Jack Hill
2021-04-17 23:54 ` jgart via Guix-patches via
2021-04-18  0:32 ` jgart via Guix-patches via
2021-04-18  9:25   ` Xinglu Chen
2021-04-18 15:39   ` jgart via Guix-patches via
2021-04-18 16:40     ` Xinglu Chen
2021-04-18 16:57     ` jgart via Guix-patches via
2021-04-19 15:33       ` Xinglu Chen
2021-04-19 16:46       ` jgart via Guix-patches via
2021-04-19 21:48         ` Ekaitz Zarraga
2021-04-20  4:57         ` Leo Famulari
2021-04-22 19:56         ` jgart via Guix-patches via
2021-04-23  9:22         ` jgart via Guix-patches via
2021-04-23 16:41           ` Leo Famulari
2021-04-20  5:00     ` Leo Famulari
2021-11-19  1:22 ` [bug#47852] [PATCH 1/2 v6] " jgart via Guix-patches via
2021-11-19  1:22   ` [bug#47852] [PATCH 2/2] gnu: Move visidata to (gnu packages spreadsheet-apps) jgart via Guix-patches via
2021-11-22 21:20   ` [bug#47852] [PATCH 1/2 v6] gnu: Add sc-im Leo Famulari
2021-11-22 23:23     ` jgart via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CTPlfV7cgzOy1zPWttP-JOHAXWXOuqvzant3dNABlA1Llhq1PLctYr2dBcu_dw7Sa4_i07lLE6ePbQ4SqTyeOYY1T3KTeW57ejqk9c1EGyE=@elenq.tech' \
    --to=hello@elenq.tech \
    --cc=47852@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=olv345@hotmail.com \
    --cc=raghavgururajan@disroot.org \
    --cc=rg@raghavgururajan.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).